From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C2AFC48BE0 for ; Fri, 11 Jun 2021 07:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26E54613AD for ; Fri, 11 Jun 2021 07:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230370AbhFKHUO (ORCPT ); Fri, 11 Jun 2021 03:20:14 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:50550 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhFKHUO (ORCPT ); Fri, 11 Jun 2021 03:20:14 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1lrbQX-0005A7-Ly; Fri, 11 Jun 2021 15:18:01 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1lrbQ6-0002Kj-2m; Fri, 11 Jun 2021 15:17:34 +0800 Date: Fri, 11 Jun 2021 15:17:34 +0800 From: Herbert Xu To: Corentin Labbe Cc: davem@davemloft.net, linus.walleij@linaro.org, linux@armlinux.org.uk, robh+dt@kernel.org, ulli.kroll@googlemail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] crypto: add gemini/sl3516 crypto driver Message-ID: <20210611071733.GC23016@gondor.apana.org.au> References: <20210601151132.1893443-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210601151132.1893443-1-clabbe@baylibre.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jun 01, 2021 at 03:11:27PM +0000, Corentin Labbe wrote: > The gemini SL3516 SoC has a crypto IP. > This serie had support for it. > > It was tested with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y. > Furthermore, it survives hours and gigs of write/read to a luks2 using xts(ecb-aes-sl3516). > > Performance is quite good. > On a luks2 partition (2To with bs=4096), a fsck comes from 14m26(without CE) to 8m48(with CE). > So it is really usefull. > > With bs=512, the performance is similar with software. > > Changes since v1: > - reworded dt-binding subject patch > - fixed build with CRYPTO_DEV_SL3516_DEBUG > > Corentin Labbe (5): > dt-bindings: crypto: Add documentation for sl3516-ce > crypto: Add sl3516 crypto engine > ARM: dts: gemini: add crypto node > ARM: gemini_config: enable sl3516-ce crypto > MAINTAINERS: add gemini crypto sl3516-ce > > .../crypto/cortina,sl3516-crypto.yaml | 50 ++ > MAINTAINERS | 7 + > arch/arm/boot/dts/gemini.dtsi | 8 + > arch/arm/configs/gemini_defconfig | 1 + > drivers/crypto/Kconfig | 19 + > drivers/crypto/Makefile | 1 + > drivers/crypto/gemini/Makefile | 2 + > drivers/crypto/gemini/sl3516-ce-cipher.c | 388 +++++++++++++ > drivers/crypto/gemini/sl3516-ce-core.c | 535 ++++++++++++++++++ > drivers/crypto/gemini/sl3516-ce-rng.c | 61 ++ > drivers/crypto/gemini/sl3516-ce.h | 347 ++++++++++++ > 11 files changed, 1419 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/cortina,sl3516-crypto.yaml > create mode 100644 drivers/crypto/gemini/Makefile > create mode 100644 drivers/crypto/gemini/sl3516-ce-cipher.c > create mode 100644 drivers/crypto/gemini/sl3516-ce-core.c > create mode 100644 drivers/crypto/gemini/sl3516-ce-rng.c > create mode 100644 drivers/crypto/gemini/sl3516-ce.h Patches 1,2,5 applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 395C0C4743D for ; Fri, 11 Jun 2021 07:20:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07D19613AD for ; Fri, 11 Jun 2021 07:20:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07D19613AD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1IsMSCZcjuDg2pxQqQTht+IvI7v3oJTLyN+pTADdkzc=; b=SPj3Yi7JhbKDjH xzsPvDZL8J9zgiPfpbWULVWVVWU39lCtvQ25oMkbNKAPQ2/cDfTr0OtoXiXjxgRe8dcBcy3mzuopE Z9ZVdd0d76WEgrgaQ4aNlgAUbrjoygq2FX7JhpvMXY5QDYRalQ4Su3+uLxZJJFGII3P5/BdZNHS1r cWjzjQT9/R7oVyq2KiN1+d+91D0uVj9m4stz4qAJ2k1/7u+n0Uiwxd4c1WQyxS15JVpoA2eePFNiQ iF6zkpFq+OUKjbKO+B7voCyTB3nEitZoDn45BkkaCH0S2RE/hMFkL6Vv9ObZFxlo3xXNZaoE9JPFh A6zwqpcfp3VLfJjdRi3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrbR4-0047YN-LD; Fri, 11 Jun 2021 07:18:34 +0000 Received: from helcar.hmeau.com ([216.24.177.18] helo=deadmen.hmeau.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrbR0-0047T7-9j for linux-arm-kernel@lists.infradead.org; Fri, 11 Jun 2021 07:18:31 +0000 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtp (Exim 4.92 #5 (Debian)) id 1lrbQX-0005A7-Ly; Fri, 11 Jun 2021 15:18:01 +0800 Received: from herbert by gondobar with local (Exim 4.92) (envelope-from ) id 1lrbQ6-0002Kj-2m; Fri, 11 Jun 2021 15:17:34 +0800 Date: Fri, 11 Jun 2021 15:17:34 +0800 From: Herbert Xu To: Corentin Labbe Cc: davem@davemloft.net, linus.walleij@linaro.org, linux@armlinux.org.uk, robh+dt@kernel.org, ulli.kroll@googlemail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/5] crypto: add gemini/sl3516 crypto driver Message-ID: <20210611071733.GC23016@gondor.apana.org.au> References: <20210601151132.1893443-1-clabbe@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210601151132.1893443-1-clabbe@baylibre.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_001830_363696_BC34187C X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 01, 2021 at 03:11:27PM +0000, Corentin Labbe wrote: > The gemini SL3516 SoC has a crypto IP. > This serie had support for it. > > It was tested with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y. > Furthermore, it survives hours and gigs of write/read to a luks2 using xts(ecb-aes-sl3516). > > Performance is quite good. > On a luks2 partition (2To with bs=4096), a fsck comes from 14m26(without CE) to 8m48(with CE). > So it is really usefull. > > With bs=512, the performance is similar with software. > > Changes since v1: > - reworded dt-binding subject patch > - fixed build with CRYPTO_DEV_SL3516_DEBUG > > Corentin Labbe (5): > dt-bindings: crypto: Add documentation for sl3516-ce > crypto: Add sl3516 crypto engine > ARM: dts: gemini: add crypto node > ARM: gemini_config: enable sl3516-ce crypto > MAINTAINERS: add gemini crypto sl3516-ce > > .../crypto/cortina,sl3516-crypto.yaml | 50 ++ > MAINTAINERS | 7 + > arch/arm/boot/dts/gemini.dtsi | 8 + > arch/arm/configs/gemini_defconfig | 1 + > drivers/crypto/Kconfig | 19 + > drivers/crypto/Makefile | 1 + > drivers/crypto/gemini/Makefile | 2 + > drivers/crypto/gemini/sl3516-ce-cipher.c | 388 +++++++++++++ > drivers/crypto/gemini/sl3516-ce-core.c | 535 ++++++++++++++++++ > drivers/crypto/gemini/sl3516-ce-rng.c | 61 ++ > drivers/crypto/gemini/sl3516-ce.h | 347 ++++++++++++ > 11 files changed, 1419 insertions(+) > create mode 100644 Documentation/devicetree/bindings/crypto/cortina,sl3516-crypto.yaml > create mode 100644 drivers/crypto/gemini/Makefile > create mode 100644 drivers/crypto/gemini/sl3516-ce-cipher.c > create mode 100644 drivers/crypto/gemini/sl3516-ce-core.c > create mode 100644 drivers/crypto/gemini/sl3516-ce-rng.c > create mode 100644 drivers/crypto/gemini/sl3516-ce.h Patches 1,2,5 applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel