All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsahern@gmail.com>
Cc: Parav Pandit <parav@nvidia.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2] uapi: add missing virtio related headers
Date: Fri, 11 Jun 2021 09:21:32 -0700	[thread overview]
Message-ID: <20210611092132.5f66f710@hermes.local> (raw)
In-Reply-To: <41c8cf83-6b7d-1d55-fd88-5b84732f9d70@gmail.com>

On Thu, 10 Jun 2021 20:54:45 -0600
David Ahern <dsahern@gmail.com> wrote:

> On 6/8/21 11:15 PM, Parav Pandit wrote:
> > Hi Stephen,
> > 
> > vdpa headers were present in commit c2ecc82b9d4c at [1].
> > 
> > I added them at [1] after David's recommendation in [2].
> > 
> > Should we remove [1]?
> > Did you face compilation problem without this fix?
> > 
> > [1] ./vdpa/include/uapi/linux/vdpa.h
> > [2] https://lore.kernel.org/netdev/abc71731-012e-eaa4-0274-5347fc99c249@gmail.com/
> > 
> > Parav  
> 
> Stephen: Did you hit a compile issue? vdpa goes beyond networking and
> features go through other trees AIUI so the decision was to put the uapi
> file under the vdpa command similar to what rdma is doing.
> 

In iproute2, all kernel headers used during the build should come from include/uapi.
If new command or function needs a new header, then the sanitized version should be
included.

I update these with an automated script, and making special case for vdpa
seems to be needless effort. Please just let iproute's include/uapi just be
a copy of what kernel "make install_headers" generates.

  reply	other threads:[~2021-06-11 16:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 17:40 [PATCH iproute2] uapi: add missing virtio related headers Stephen Hemminger
2021-04-23 17:50 ` patchwork-bot+netdevbpf
2021-06-09  5:15 ` Parav Pandit
2021-06-11  2:54   ` David Ahern
2021-06-11 16:21     ` Stephen Hemminger [this message]
2021-06-15  1:03       ` David Ahern
2021-06-15  6:13         ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210611092132.5f66f710@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=parav@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.