All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] soc: mediatek: pwarp: delete confusing comments
@ 2021-06-11 11:13 ` matthias.bgg
  0 siblings, 0 replies; 6+ messages in thread
From: matthias.bgg @ 2021-06-11 11:13 UTC (permalink / raw)
  To: james.lo; +Cc: linux-mediatek, linux-kernel, linux-arm-kernel, Matthias Brugger

From: Matthias Brugger <matthias.bgg@gmail.com>

Comments sugguest that MT8195 arb_en_all and int_en_all values need to
be confirmed. But actually these values are correct.

Suggested-by: James Lo <james.lo@mediatek.com>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

---

 drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 952bc554f443..118eb4acdeb6 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = {
 static struct pmic_wrapper_type pwrap_mt8195 = {
 	.regs = mt8195_regs,
 	.type = PWRAP_MT8195,
-	.arb_en_all = 0x777f, /* NEED CONFIRM */
-	.int_en_all = 0x180000, /* NEED CONFIRM */
+	.arb_en_all = 0x777f,
+	.int_en_all = 0x180000,
 	.int1_en_all = 0,
 	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
 	.wdt_src = PWRAP_WDT_SRC_MASK_ALL,
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] soc: mediatek: pwarp: delete confusing comments
@ 2021-06-11 11:13 ` matthias.bgg
  0 siblings, 0 replies; 6+ messages in thread
From: matthias.bgg @ 2021-06-11 11:13 UTC (permalink / raw)
  To: james.lo; +Cc: linux-mediatek, linux-kernel, linux-arm-kernel, Matthias Brugger

From: Matthias Brugger <matthias.bgg@gmail.com>

Comments sugguest that MT8195 arb_en_all and int_en_all values need to
be confirmed. But actually these values are correct.

Suggested-by: James Lo <james.lo@mediatek.com>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

---

 drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 952bc554f443..118eb4acdeb6 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = {
 static struct pmic_wrapper_type pwrap_mt8195 = {
 	.regs = mt8195_regs,
 	.type = PWRAP_MT8195,
-	.arb_en_all = 0x777f, /* NEED CONFIRM */
-	.int_en_all = 0x180000, /* NEED CONFIRM */
+	.arb_en_all = 0x777f,
+	.int_en_all = 0x180000,
 	.int1_en_all = 0,
 	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
 	.wdt_src = PWRAP_WDT_SRC_MASK_ALL,
-- 
2.31.1


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] soc: mediatek: pwarp: delete confusing comments
@ 2021-06-11 11:13 ` matthias.bgg
  0 siblings, 0 replies; 6+ messages in thread
From: matthias.bgg @ 2021-06-11 11:13 UTC (permalink / raw)
  To: james.lo; +Cc: linux-mediatek, linux-kernel, linux-arm-kernel, Matthias Brugger

From: Matthias Brugger <matthias.bgg@gmail.com>

Comments sugguest that MT8195 arb_en_all and int_en_all values need to
be confirmed. But actually these values are correct.

Suggested-by: James Lo <james.lo@mediatek.com>
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

---

 drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index 952bc554f443..118eb4acdeb6 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type pwrap_mt8183 = {
 static struct pmic_wrapper_type pwrap_mt8195 = {
 	.regs = mt8195_regs,
 	.type = PWRAP_MT8195,
-	.arb_en_all = 0x777f, /* NEED CONFIRM */
-	.int_en_all = 0x180000, /* NEED CONFIRM */
+	.arb_en_all = 0x777f,
+	.int_en_all = 0x180000,
 	.int1_en_all = 0,
 	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
 	.wdt_src = PWRAP_WDT_SRC_MASK_ALL,
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] soc: mediatek: pwarp: delete confusing comments
  2021-06-11 11:13 ` matthias.bgg
  (?)
@ 2021-06-14  9:43   ` James Lo
  -1 siblings, 0 replies; 6+ messages in thread
From: James Lo @ 2021-06-14  9:43 UTC (permalink / raw)
  To: matthias.bgg
  Cc: linux-mediatek, linux-kernel, linux-arm-kernel, Matthias Brugger


Thank you for your kind assistance.

Many thanks
James Lo


On Fri, 2021-06-11 at 13:13 +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> Comments sugguest that MT8195 arb_en_all and int_en_all values need
> to
> be confirmed. But actually these values are correct.
> 
> Suggested-by: James Lo <james.lo@mediatek.com>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
> ---
> 
>  drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
> b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 952bc554f443..118eb4acdeb6 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type
> pwrap_mt8183 = {
>  static struct pmic_wrapper_type pwrap_mt8195 = {
>  	.regs = mt8195_regs,
>  	.type = PWRAP_MT8195,
> -	.arb_en_all = 0x777f, /* NEED CONFIRM */
> -	.int_en_all = 0x180000, /* NEED CONFIRM */
> +	.arb_en_all = 0x777f,
> +	.int_en_all = 0x180000,
>  	.int1_en_all = 0,
>  	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>  	.wdt_src = PWRAP_WDT_SRC_MASK_ALL,

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] soc: mediatek: pwarp: delete confusing comments
@ 2021-06-14  9:43   ` James Lo
  0 siblings, 0 replies; 6+ messages in thread
From: James Lo @ 2021-06-14  9:43 UTC (permalink / raw)
  To: matthias.bgg
  Cc: linux-mediatek, linux-kernel, linux-arm-kernel, Matthias Brugger


Thank you for your kind assistance.

Many thanks
James Lo


On Fri, 2021-06-11 at 13:13 +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> Comments sugguest that MT8195 arb_en_all and int_en_all values need
> to
> be confirmed. But actually these values are correct.
> 
> Suggested-by: James Lo <james.lo@mediatek.com>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
> ---
> 
>  drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
> b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 952bc554f443..118eb4acdeb6 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type
> pwrap_mt8183 = {
>  static struct pmic_wrapper_type pwrap_mt8195 = {
>  	.regs = mt8195_regs,
>  	.type = PWRAP_MT8195,
> -	.arb_en_all = 0x777f, /* NEED CONFIRM */
> -	.int_en_all = 0x180000, /* NEED CONFIRM */
> +	.arb_en_all = 0x777f,
> +	.int_en_all = 0x180000,
>  	.int1_en_all = 0,
>  	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>  	.wdt_src = PWRAP_WDT_SRC_MASK_ALL,
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] soc: mediatek: pwarp: delete confusing comments
@ 2021-06-14  9:43   ` James Lo
  0 siblings, 0 replies; 6+ messages in thread
From: James Lo @ 2021-06-14  9:43 UTC (permalink / raw)
  To: matthias.bgg
  Cc: linux-mediatek, linux-kernel, linux-arm-kernel, Matthias Brugger


Thank you for your kind assistance.

Many thanks
James Lo


On Fri, 2021-06-11 at 13:13 +0200, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> Comments sugguest that MT8195 arb_en_all and int_en_all values need
> to
> be confirmed. But actually these values are correct.
> 
> Suggested-by: James Lo <james.lo@mediatek.com>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> 
> ---
> 
>  drivers/soc/mediatek/mtk-pmic-wrap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c
> b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 952bc554f443..118eb4acdeb6 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -2047,8 +2047,8 @@ static const struct pmic_wrapper_type
> pwrap_mt8183 = {
>  static struct pmic_wrapper_type pwrap_mt8195 = {
>  	.regs = mt8195_regs,
>  	.type = PWRAP_MT8195,
> -	.arb_en_all = 0x777f, /* NEED CONFIRM */
> -	.int_en_all = 0x180000, /* NEED CONFIRM */
> +	.arb_en_all = 0x777f,
> +	.int_en_all = 0x180000,
>  	.int1_en_all = 0,
>  	.spi_w = PWRAP_MAN_CMD_SPI_WRITE,
>  	.wdt_src = PWRAP_WDT_SRC_MASK_ALL,
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-14  9:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 11:13 [PATCH] soc: mediatek: pwarp: delete confusing comments matthias.bgg
2021-06-11 11:13 ` matthias.bgg
2021-06-11 11:13 ` matthias.bgg
2021-06-14  9:43 ` James Lo
2021-06-14  9:43   ` James Lo
2021-06-14  9:43   ` James Lo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.