* [PATCH v2] Test comment for git-publish
@ 2021-06-11 16:43 Mauro Matteo Cascella
2021-06-11 17:11 ` Mauro Matteo Cascella
2021-06-14 22:30 ` no-reply
0 siblings, 2 replies; 3+ messages in thread
From: Mauro Matteo Cascella @ 2021-06-11 16:43 UTC (permalink / raw)
To: mcascell; +Cc: Yuval Shaia, qemu-devel
---
hw/rdma/vmw/pvrdma_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index 84ae8024fc..e229c19564 100644
--- a/hw/rdma/vmw/pvrdma_main.c
+++ b/hw/rdma/vmw/pvrdma_main.c
@@ -427,7 +427,7 @@ static void pvrdma_regs_write(void *opaque, hwaddr addr, uint64_t val,
case PVRDMA_REG_REQUEST:
if (val == 0) {
trace_pvrdma_regs_write(addr, val, "REQUEST", "");
- pvrdma_exec_cmd(dev);
+ pvrdma_exec_cmd(dev); // this is a test comment
}
break;
default:
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Test comment for git-publish
2021-06-11 16:43 [PATCH v2] Test comment for git-publish Mauro Matteo Cascella
@ 2021-06-11 17:11 ` Mauro Matteo Cascella
2021-06-14 22:30 ` no-reply
1 sibling, 0 replies; 3+ messages in thread
From: Mauro Matteo Cascella @ 2021-06-11 17:11 UTC (permalink / raw)
To: Mauro Matteo Cascella; +Cc: QEMU Developers
On Fri, Jun 11, 2021 at 6:43 PM Mauro Matteo Cascella
<mcascell@redhat.com> wrote:
>
> ---
> hw/rdma/vmw/pvrdma_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
> index 84ae8024fc..e229c19564 100644
> --- a/hw/rdma/vmw/pvrdma_main.c
> +++ b/hw/rdma/vmw/pvrdma_main.c
> @@ -427,7 +427,7 @@ static void pvrdma_regs_write(void *opaque, hwaddr addr, uint64_t val,
> case PVRDMA_REG_REQUEST:
> if (val == 0) {
> trace_pvrdma_regs_write(addr, val, "REQUEST", "");
> - pvrdma_exec_cmd(dev);
> + pvrdma_exec_cmd(dev); // this is a test comment
> }
> break;
> default:
> --
> 2.31.1
>
Again, sorry for the spam. Can someone please explain how to *not* use
the profiles defined in .gitpublish? I used the following command,
evidently with no success:
$ git publish --override-cc --override-to --to=mcascell@redhat.com
--
Mauro Matteo Cascella
Red Hat Product Security
PGP-Key ID: BB3410B0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Test comment for git-publish
2021-06-11 16:43 [PATCH v2] Test comment for git-publish Mauro Matteo Cascella
2021-06-11 17:11 ` Mauro Matteo Cascella
@ 2021-06-14 22:30 ` no-reply
1 sibling, 0 replies; 3+ messages in thread
From: no-reply @ 2021-06-14 22:30 UTC (permalink / raw)
To: mcascell; +Cc: mcascell, yuval.shaia.ml, qemu-devel
Patchew URL: https://patchew.org/QEMU/20210611164305.440633-1-mcascell@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210611164305.440633-1-mcascell@redhat.com
Subject: [PATCH v2] Test comment for git-publish
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
bf784f4 Test comment for git-publish
=== OUTPUT BEGIN ===
ERROR: do not use C99 // comments
#21: FILE: hw/rdma/vmw/pvrdma_main.c:430:
+ pvrdma_exec_cmd(dev); // this is a test comment
ERROR: Missing Signed-off-by: line(s)
total: 2 errors, 0 warnings, 8 lines checked
Commit bf784f48ac5f (Test comment for git-publish) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20210611164305.440633-1-mcascell@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-14 22:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 16:43 [PATCH v2] Test comment for git-publish Mauro Matteo Cascella
2021-06-11 17:11 ` Mauro Matteo Cascella
2021-06-14 22:30 ` no-reply
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.