From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8215FC48BD1 for ; Fri, 11 Jun 2021 21:06:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DC0B611CA for ; Fri, 11 Jun 2021 21:06:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DC0B611CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B3FE8803B9; Fri, 11 Jun 2021 23:06:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="d4nMtkBm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B17B7803E1; Fri, 11 Jun 2021 23:06:31 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B83FD8031F for ; Fri, 11 Jun 2021 23:06:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id o20so3656111qtr.8 for ; Fri, 11 Jun 2021 14:06:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OQ+gezTsYtTWyFyiQyDV20hIU6WaZWp1Ub1kBYG7a7c=; b=d4nMtkBmxHuTP1+J91Ulmexz6Ak2l4rlZbmGN7btUwKPeE52XaylPn8PYOpbY4Togk GmM/GXEf0KcZVxr0ka70Yv9zhAGJgkVzLwSdYj4UuDqQPcw45QgnbZtJD66f1TbShcH7 YmENwfzciLG0F1F4AtHNs6hegVbepA8bD/Cn4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OQ+gezTsYtTWyFyiQyDV20hIU6WaZWp1Ub1kBYG7a7c=; b=AXN6Y8R58saajIEosBWdq1B8LE7BASWsw5cbCP0Lpg6306oj5QoCFa/YrrhPGOODdn dnPu7HW+vB+oDg71xANe4h409l0Dc+mULbwQ9Yys1A+lIAdBpNhGqSJaQSH1bHJCA3IE oev9tej8iW7EV/MHmnRfLbRzsmS3ua5oO4gRF32bziuaJU5med6TF3chMF4OvdWgmtC4 XZEvjRMxF0YeUZnuzpjfC30oZxV0Sd8f9UsNkkK9ocoSyYUlv5xe0xzig4KzoDsMr84V //uFEeKVNUGWoE/prkCm5pGQnnDptNlmq1LQUN4UJNM6OmS939gk8zvVm/P79wC+nnX5 6Q2w== X-Gm-Message-State: AOAM532ZxajyzFBH8EfTX8EX58epxYa7VcvEnqjaOmMjmo2BV+LY3IFW /AkInY8xIYYQ3RwQN3ArOAk5JQ== X-Google-Smtp-Source: ABdhPJy5hfDNDc8/9wuKVLVMEPKyQ042dl2NJJiugHwti4UUV+I3TPjRl4MhTBDfXD5UrUPCVcfZjg== X-Received: by 2002:ac8:45cc:: with SMTP id e12mr5599394qto.227.1623445587454; Fri, 11 Jun 2021 14:06:27 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-3c24-afde-29e9-71af.res6.spectrum.com. [2603:6081:7b01:cbda:3c24:afde:29e9:71af]) by smtp.gmail.com with ESMTPSA id j127sm5408336qke.90.2021.06.11.14.06.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jun 2021 14:06:26 -0700 (PDT) Date: Fri, 11 Jun 2021 17:06:24 -0400 From: Tom Rini To: Trevor Woerner Cc: U-Boot Mailing List Subject: Re: [PATCH] scripts/get_maintainer.pl: obey ignore list Message-ID: <20210611210624.GY9516@bill-the-cat> References: <20210611033727.882-1-twoerner@gmail.com> <20210611142301.GW9516@bill-the-cat> <20210611145655.GA24653@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="M84Mp/hDKELh/AV5" Content-Disposition: inline In-Reply-To: <20210611145655.GA24653@localhost> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --M84Mp/hDKELh/AV5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 11, 2021 at 10:56:55AM -0400, Trevor Woerner wrote: > Hi Tom, >=20 > On Fri 2021-06-11 @ 10:23:01 AM, Tom Rini wrote: > > On Thu, Jun 10, 2021 at 11:37:27PM -0400, Trevor Woerner wrote: > >=20 > > > If the user creates a .get_maintainer.ignore file, make sure it is co= nsulted > > > and obeyed for *all* emails discovered by the script. > > >=20 > > > Signed-off-by: Trevor Woerner > > > --- > > > scripts/get_maintainer.pl | 1 + > > > 1 file changed, 1 insertion(+) > > >=20 > > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > > > index e3b41616c9..8c0fb8656e 100755 > > > --- a/scripts/get_maintainer.pl > > > +++ b/scripts/get_maintainer.pl > > > @@ -2435,6 +2435,7 @@ sub merge_email { > > > =20 > > > for (@_) { > > > my ($address, $role) =3D @$_; > > > + next if (ignore_email_address($address)); > > > if (!$saw{$address}) { > > > if ($output_roles) { > > > push(@lines, "$address ($role)"); > >=20 > > This got me to check and see that yes, our copy of get_maintainers.pl is > > out of date from Linux. And in fact, a re-sync will let us add a > > .get_maintainer.conf file and use upstream a lot more closely as it now > > has logic to find all MAINTAINERS files in a tree. > >=20 > > But this change isn't upstream. Please work with Joe Perches upstream > > to get this change accepted and it'll flow down to us and not get > > overwritten when I forget it was an intentional change :) Thanks! >=20 > Thanks for the tip! >=20 > I ran my patches through the kernel's latest get_maintainer.pl script and= it > correctly removes email entries that are listed in my ~/.get_maintainer.i= gnore > file without any changes required. Therefore a re-sync would appear to fi= x the > issue I found. >=20 > I can take a look at the re-sync if you wish? It's unclear to me whether > you're looking into the re-sync or not. Please do. I took a quick attempt at it, but I couldn't convince it to use all of our MAINTAINERS files, by default, for some reason. Thanks! --=20 Tom --M84Mp/hDKELh/AV5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDD0EwACgkQFHw5/5Y0 tyyuzAv/RHaZ3cAQWnKMQpBe3NJ27nmtEhigzJSnnV/Wh8u9+OOpB65vEJfh8h+P 2OPjwZ+wluCCWmp2NfzjC0GZKtf/k2uVecU52/Ch6h21RDjkWaw5DV2SqVKyy1BO kxZCrpdo5ICJMbTrgbJV5sVnBqV5aO9Xf6HIcAPY9CxV0acj7SYf83kLEIHXc+dH BH+GUGYjnnzu7TVmtE7aQzhixpTvxZ1jA4m6k6jlTb7bdrtBPBt87+AX0GZSugZS Mo9WPRbJvwqMPPBK1w7mQk8xIcQcVH8ZDHNOwUrBiQAidx3B9Qi1YhOCV0Roc6Xn W0qdIiuxu4jxHLH2fGilmtu7z89i/0zYKZXcABp8tECU8MJTxuQtMXCl7NEI9X74 01iwAWi5tSBeYXXtvt3gAJ8Ms4XBl+STKR/qQGXXrgGI7FHSf7FRbPzFeyhw0tlu If3uWhUdXsC2T9Jr9blP9KPb+8Xj4uZOV4CBMknpgvCO7YTVRyi5R6/LLsmH2ac5 6crCXK7E =X5sl -----END PGP SIGNATURE----- --M84Mp/hDKELh/AV5--