From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74FA6C48BE0 for ; Fri, 11 Jun 2021 21:25:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 460FA610C7 for ; Fri, 11 Jun 2021 21:25:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230040AbhFKV1V (ORCPT ); Fri, 11 Jun 2021 17:27:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229685AbhFKV1V (ORCPT ); Fri, 11 Jun 2021 17:27:21 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64612C061574; Fri, 11 Jun 2021 14:25:08 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id x73so5471410pfc.8; Fri, 11 Jun 2021 14:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EErh4AFEB9TSdc7WfIdaoOzA/fCcYXLQPgZuGLkqOcY=; b=PIam/HP72m4iEvTn90htVH+FbHnvL1D2rCMli854G13eHjMyEJkKuKhsZiEgnT+0zV JZoCZsRFU36/AppgDUousRi2batAyZ9sS+Te0AWQ9zeGS2Xqq3dp/roIikV0pNl1Lv3u 6hvdt/CEox765CXl/6xwBOvmJMARg7jzURTpB4YELmXBfDrFFRzgJENSCqRZVYvAKlDo m/wohIaYriksspHPys3RTZz0PO+C8X23qaauLHJ46rzt211nE7B9H57YokumoJ/hSiTq 488HAQdJGFbPnR5kRClIU9qHq3u5MZNJbeEPVZ3Bw8fkcmDCEGZyFuy3Ngi0jnk7S5S4 iAMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EErh4AFEB9TSdc7WfIdaoOzA/fCcYXLQPgZuGLkqOcY=; b=K9Y7QXYqiG8cfcWlirYJh/NcQs6pvkjGYKSkNexlwFn6N3m2cYhyB4jQTS03qz0gVr erLIUdGAopDzQzM7nGiHin/TWLkOfCRx9li6KsmZXEHUT3n0gq8NqptY4xXOMRb2eqkF t5dSNCxONRSInJC651sxFXEMuuQR+DaIZrwG3Ei+xkCQTlAXcpkqDQQqYy6hflgyh0Pz k7BaUQnw3uBLnUcJl5CP/c7Xuv5fmx+gfMdcQpSSRuwTrjR9W0bdo8/hmhTKxVKYFwXk 7kuR2xeN5aqnQohIPVIFMzjVll1GYBVTgdP0F9+N2UInKXOw2m6ifm21cA2b3skNBEHa KGvg== X-Gm-Message-State: AOAM532WrbQ5Qzvz/UUctnkTuJN3f7xrxCVyHHWhG62mMPCO0gepvQ2n XI5WtYmAv77vk8r7/nQixHc= X-Google-Smtp-Source: ABdhPJxUApQlw3zt2l1XcLt8eNiJyuprAK+wRCmqJ8EEL/EA8gYI5WeX2Oyi/8+iJZ3iyzamDYuK1g== X-Received: by 2002:a63:e0e:: with SMTP id d14mr5453612pgl.426.1623446707759; Fri, 11 Jun 2021 14:25:07 -0700 (PDT) Received: from localhost ([2409:4063:4d05:9fb3:bc63:2dba:460a:d70e]) by smtp.gmail.com with ESMTPSA id x206sm5960002pfc.211.2021.06.11.14.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 14:25:07 -0700 (PDT) Date: Sat, 12 Jun 2021 02:53:48 +0530 From: Kumar Kartikeya Dwivedi To: Andrii Nakryiko Cc: bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= , Shaun Crampton , Networking Subject: Re: [PATCH bpf-next v7 0/3] Add TC-BPF API Message-ID: <20210611212348.qnwkyvmpqar3qwjr@apollo> References: <20210512103451.989420-1-memxor@gmail.com> <20210611204611.4xdgvqwtcin6ckdc@apollo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sat, Jun 12, 2021 at 02:28:09AM IST, Andrii Nakryiko wrote: > On Fri, Jun 11, 2021 at 1:47 PM Kumar Kartikeya Dwivedi > wrote: > > > > On Sat, Jun 12, 2021 at 01:31:56AM IST, Andrii Nakryiko wrote: > > > On Wed, May 12, 2021 at 3:35 AM Kumar Kartikeya Dwivedi > > > wrote: > > > > > > > > This is the seventh version of the TC-BPF series. > > > > > > > > It adds a simple API that uses netlink to attach the tc filter and its bpf > > > > classifier program. Currently, a user needs to shell out to the tc command line > > > > to be able to create filters and attach SCHED_CLS programs as classifiers. With > > > > the help of this API, it will be possible to use libbpf for doing all parts of > > > > bpf program setup and attach. > > > > > > > > Changelog contains details of patchset evolution. > > > > > > > > In an effort to keep discussion focused, this series doesn't have the high level > > > > TC-BPF API. It was clear that there is a need for a bpf_link API in the kernel, > > > > hence that will be submitted as a separate patchset based on this. > > > > > > > > The individual commit messages contain more details, and also a brief summary of > > > > the API. > > > > > > > > Changelog: > > > > ---------- > > > > > > Hey Kartikeya, > > > > > > There were few issues flagged by Coverity after I synced libbpf to > > > Github. A bunch of them are netlink.c-related. Could you please take a > > > look and see if they are false positives or something that we can > > > actually fix? See links to the issues below. Thanks! > > > > > > [0] https://scan3.coverity.com/reports.htm#v40547/p11903/fileInstanceId=53874109&defectInstanceId=10901199&mergedDefectId=141815 > > > [1] https://scan3.coverity.com/reports.htm#v40547/p11903/fileInstanceId=53874109&defectInstanceId=10901193&mergedDefectId=322806 > > > [2] https://scan3.coverity.com/reports.htm#v40547/p11903/fileInstanceId=53874109&defectInstanceId=10901197&mergedDefectId=322807 > > > [3] https://scan3.coverity.com/reports.htm#v40547/p11903/fileInstanceId=53874109&defectInstanceId=10901195&mergedDefectId=322808 > > > > > > > Hi Andrii, > > > > These links don't work for me (I get a timeout). Would you know why? Is there > > some other link where I can look at them? > > > > Sorry, I don't know any other way to share them. > https://scan3.coverity.com/reports.htm#v40547/p11903 should show all > libbpf issues. Maybe try creating an account with coverity.com?.. > Thanks, that helped. I now see 401 Unauthorized, so I sent an approval request. -- Kartikeya