+ mm-slubc-include-swabh.patch added to -mm tree

+ mm-slubc-include-swabh.patch added to -mm tree

[akpm]

The patch titled
     Subject: mm/slub.c: include swab.h
has been added to the -mm tree.  Its filename is
     mm-slubc-include-swabh.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/mm-slubc-include-swabh.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/mm-slubc-include-swabh.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm/slub.c: include swab.h

Fixes build with CONFIG_SLAB_FREELIST_HARDENED=y.

Fixes: 1ad53d9fa3f61 ("slub: improve bit diffusion for freelist ptr obfuscation")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=213417
Reported-by: <vannguye@cisco.com>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/slub.c |    1 +
 1 file changed, 1 insertion(+)

--- a/mm/slub.c~mm-slubc-include-swabh
+++ a/mm/slub.c
@@ -15,6 +15,7 @@
 #include <linux/module.h>
 #include <linux/bit_spinlock.h>
 #include <linux/interrupt.h>
+#include <linux/swab.h>
 #include <linux/bitops.h>
 #include <linux/slab.h>
 #include "slab.h"
_

Patches currently in -mm which might be from akpm@linux-foundation.org are

mm-slubc-include-swabh.patch
mm.patch
mm-slub-kunit-add-a-kunit-test-for-slub-debugging-functionality-fix-2.patch
slub-force-on-no_hash_pointers-when-slub_debug-is-enabled-fix.patch
mm-gup-pack-has_pinned-in-mmf_has_pinned-checkpatch-fixes.patch
mm-memcg-optimize-user-context-object-stock-access-checkpatch-fixes.patch
mm-memcg-slab-create-a-new-set-of-kmalloc-cg-n-caches-v5-fix.patch
binfmt-remove-in-tree-usage-of-map_executable-fix.patch
mm-mmap-introduce-unlock_range-for-code-cleanup-fix.patch
lazy-tlb-allow-lazy-tlb-mm-refcounting-to-be-configurable-fix.patch
mm-page_alloc-convert-per-cpu-list-protection-to-local_lock-fix-checkpatch-fixes.patch
mm-memory-failure-use-a-mutex-to-avoid-memory_failure-races-fix.patch
mm-memory_hotplug-disable-memmap_on_memory-when-hugetlb_free_vmemmap-enabled-fix.patch
nommu-remove-__gfp_highmem-in-vmalloc-vzalloc-checkpatch-fixes.patch
mm-madvise-introduce-madv_populate_readwrite-to-prefault-page-tables-checkpatch-fixes.patch
mmmemory_hotplug-drop-unneeded-locking-fix.patch
fs-proc-kcorec-add-mmap-interface-fix.patch
kernelh-split-out-panic-and-oops-helpers-fix.patch
lib-math-rational-add-kunit-test-cases-fix.patch
lib-decompressors-remove-set-but-not-used-variabled-level-fix.patch
ipc-utilc-use-binary-search-for-max_idx-fix.patch
linux-next-pre.patch
linux-next-post.patch
linux-next-rejects.patch
mm-introduce-memfd_secret-system-call-to-create-secret-memory-areas-fix.patch
module-add-printk-formats-to-add-module-build-id-to-stacktraces-fix.patch
module-add-printk-formats-to-add-module-build-id-to-stacktraces-fix-fix.patch
kernel-forkc-export-kernel_thread-to-modules.patch

Re: + mm-slubc-include-swabh.patch added to -mm tree

[Kees Cook]

On Fri, Jun 11, 2021 at 03:27:52PM -0700, akpm@linux-foundation.org wrote:
> 
> The patch titled
>      Subject: mm/slub.c: include swab.h
> has been added to the -mm tree.  Its filename is
>      mm-slubc-include-swabh.patch
> 
> This patch should soon appear at
>     https://ozlabs.org/~akpm/mmots/broken-out/mm-slubc-include-swabh.patch
> and later at
>     https://ozlabs.org/~akpm/mmotm/broken-out/mm-slubc-include-swabh.patch
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
> 
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: mm/slub.c: include swab.h
> 
> Fixes build with CONFIG_SLAB_FREELIST_HARDENED=y.
> 
> Fixes: 1ad53d9fa3f61 ("slub: improve bit diffusion for freelist ptr obfuscation")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=213417
> Reported-by: <vannguye@cisco.com>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Is this for a backport in v4.18? Regardless, yes:

Acked-by: Kees Cook <keescook@chromium.org>

> ---
> 
>  mm/slub.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/mm/slub.c~mm-slubc-include-swabh
> +++ a/mm/slub.c
> @@ -15,6 +15,7 @@
>  #include <linux/module.h>
>  #include <linux/bit_spinlock.h>
>  #include <linux/interrupt.h>
> +#include <linux/swab.h>
>  #include <linux/bitops.h>
>  #include <linux/slab.h>
>  #include "slab.h"
> _
> 
> Patches currently in -mm which might be from akpm@linux-foundation.org are
> 
> mm-slubc-include-swabh.patch
> mm.patch
> mm-slub-kunit-add-a-kunit-test-for-slub-debugging-functionality-fix-2.patch
> slub-force-on-no_hash_pointers-when-slub_debug-is-enabled-fix.patch
> mm-gup-pack-has_pinned-in-mmf_has_pinned-checkpatch-fixes.patch
> mm-memcg-optimize-user-context-object-stock-access-checkpatch-fixes.patch
> mm-memcg-slab-create-a-new-set-of-kmalloc-cg-n-caches-v5-fix.patch
> binfmt-remove-in-tree-usage-of-map_executable-fix.patch
> mm-mmap-introduce-unlock_range-for-code-cleanup-fix.patch
> lazy-tlb-allow-lazy-tlb-mm-refcounting-to-be-configurable-fix.patch
> mm-page_alloc-convert-per-cpu-list-protection-to-local_lock-fix-checkpatch-fixes.patch
> mm-memory-failure-use-a-mutex-to-avoid-memory_failure-races-fix.patch
> mm-memory_hotplug-disable-memmap_on_memory-when-hugetlb_free_vmemmap-enabled-fix.patch
> nommu-remove-__gfp_highmem-in-vmalloc-vzalloc-checkpatch-fixes.patch
> mm-madvise-introduce-madv_populate_readwrite-to-prefault-page-tables-checkpatch-fixes.patch
> mmmemory_hotplug-drop-unneeded-locking-fix.patch
> fs-proc-kcorec-add-mmap-interface-fix.patch
> kernelh-split-out-panic-and-oops-helpers-fix.patch
> lib-math-rational-add-kunit-test-cases-fix.patch
> lib-decompressors-remove-set-but-not-used-variabled-level-fix.patch
> ipc-utilc-use-binary-search-for-max_idx-fix.patch
> linux-next-pre.patch
> linux-next-post.patch
> linux-next-rejects.patch
> mm-introduce-memfd_secret-system-call-to-create-secret-memory-areas-fix.patch
> module-add-printk-formats-to-add-module-build-id-to-stacktraces-fix.patch
> module-add-printk-formats-to-add-module-build-id-to-stacktraces-fix-fix.patch
> kernel-forkc-export-kernel_thread-to-modules.patch
> 

-- 
Kees Cook