All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] musl: Set UPSTREAM_CHECK_COMMITS
@ 2021-06-12 22:10 Khem Raj
  2021-06-14 13:12 ` [OE-core] " Michael Opdenacker
  0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2021-06-12 22:10 UTC (permalink / raw)
  To: openembedded-core; +Cc: Khem Raj

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-core/musl/musl_git.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb
index 6569d1b37b..bd9d5f1d4b 100644
--- a/meta/recipes-core/musl/musl_git.bb
+++ b/meta/recipes-core/musl/musl_git.bb
@@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
 LEAD_SONAME = "libc.so"
 INSANE_SKIP_${PN}-dev = "staticdev"
 INSANE_SKIP_${PN} = "libdir"
+
+UPSTREAM_CHECK_COMMITS = "1"
-- 
2.32.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [OE-core] [PATCH] musl: Set UPSTREAM_CHECK_COMMITS
  2021-06-12 22:10 [PATCH] musl: Set UPSTREAM_CHECK_COMMITS Khem Raj
@ 2021-06-14 13:12 ` Michael Opdenacker
  2021-06-14 13:17   ` [docs] " Alexander Kanavin
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Opdenacker @ 2021-06-14 13:12 UTC (permalink / raw)
  To: Khem Raj, openembedded-core; +Cc: YP docs mailing list

Hi Khem

On 6/13/21 12:10 AM, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-core/musl/musl_git.bb | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb
> index 6569d1b37b..bd9d5f1d4b 100644
> --- a/meta/recipes-core/musl/musl_git.bb
> +++ b/meta/recipes-core/musl/musl_git.bb
> @@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
>  LEAD_SONAME = "libc.so"
>  INSANE_SKIP_${PN}-dev = "staticdev"
>  INSANE_SKIP_${PN} = "libdir"
> +
> +UPSTREAM_CHECK_COMMITS = "1"


Thanks for the patch.
Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>

I realize that the UPSTREAM_CHECK_COMMITS variable doesn't appear in the
documentation, and it's in relatively frequent use.

Would it make sense to propose to add a description based on the initial
commit
(https://git.openembedded.org/openembedded-core/commit/?id=591d57877d3d3e659d78c0ed33f4c515e3f6f8fb)?

Thanks in advance,
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [docs] [OE-core] [PATCH] musl: Set UPSTREAM_CHECK_COMMITS
  2021-06-14 13:12 ` [OE-core] " Michael Opdenacker
@ 2021-06-14 13:17   ` Alexander Kanavin
  2021-06-14 16:06     ` Michael Opdenacker
  0 siblings, 1 reply; 4+ messages in thread
From: Alexander Kanavin @ 2021-06-14 13:17 UTC (permalink / raw)
  To: Michael Opdenacker; +Cc: Khem Raj, OE-core, YP docs mailing list

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

That would be very useful, but you should check if the entire nomenclature
of UPSTREAM_CHECK_* variables is documented as well
(_COMMITS, _REGEX, _URI, _GITTAGREGEX).

Alex

On Mon, 14 Jun 2021 at 15:12, Michael Opdenacker <
michael.opdenacker@bootlin.com> wrote:

> Hi Khem
>
> On 6/13/21 12:10 AM, Khem Raj wrote:
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> >  meta/recipes-core/musl/musl_git.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/recipes-core/musl/musl_git.bb
> b/meta/recipes-core/musl/musl_git.bb
> > index 6569d1b37b..bd9d5f1d4b 100644
> > --- a/meta/recipes-core/musl/musl_git.bb
> > +++ b/meta/recipes-core/musl/musl_git.bb
> > @@ -84,3 +84,5 @@ RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"
> >  LEAD_SONAME = "libc.so"
> >  INSANE_SKIP_${PN}-dev = "staticdev"
> >  INSANE_SKIP_${PN} = "libdir"
> > +
> > +UPSTREAM_CHECK_COMMITS = "1"
>
>
> Thanks for the patch.
> Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>
> I realize that the UPSTREAM_CHECK_COMMITS variable doesn't appear in the
> documentation, and it's in relatively frequent use.
>
> Would it make sense to propose to add a description based on the initial
> commit
> (
> https://git.openembedded.org/openembedded-core/commit/?id=591d57877d3d3e659d78c0ed33f4c515e3f6f8fb
> )?
>
> Thanks in advance,
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 2715 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [docs] [OE-core] [PATCH] musl: Set UPSTREAM_CHECK_COMMITS
  2021-06-14 13:17   ` [docs] " Alexander Kanavin
@ 2021-06-14 16:06     ` Michael Opdenacker
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Opdenacker @ 2021-06-14 16:06 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: Khem Raj, OE-core, YP docs mailing list

Hi Alex,

On 6/14/21 3:17 PM, Alexander Kanavin wrote:
> That would be very useful, but you should check if the entire
> nomenclature of UPSTREAM_CHECK_* variables is documented as well
> (_COMMITS, _REGEX, _URI, _GITTAGREGEX).


Great, many thanks for the advise!
I filed a bug to keep track of this need:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14431

Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-14 16:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-12 22:10 [PATCH] musl: Set UPSTREAM_CHECK_COMMITS Khem Raj
2021-06-14 13:12 ` [OE-core] " Michael Opdenacker
2021-06-14 13:17   ` [docs] " Alexander Kanavin
2021-06-14 16:06     ` Michael Opdenacker

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.