From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A92BC49360 for ; Sun, 13 Jun 2021 08:26:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5FC9861042 for ; Sun, 13 Jun 2021 08:26:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231245AbhFMI2i convert rfc822-to-8bit (ORCPT ); Sun, 13 Jun 2021 04:28:38 -0400 Received: from out28-124.mail.aliyun.com ([115.124.28.124]:34219 "EHLO out28-124.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230136AbhFMI2h (ORCPT ); Sun, 13 Jun 2021 04:28:37 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.1052365|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_regular_dialog|0.0758817-0.0072256-0.916893;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047201;MF=zhouyanjie@wanyeetech.com;NM=1;PH=DS;RN=21;RT=21;SR=0;TI=SMTPD_---.KRgdwVg_1623572789; Received: from zhouyanjie-virtual-machine(mailfrom:zhouyanjie@wanyeetech.com fp:SMTPD_---.KRgdwVg_1623572789) by smtp.aliyun-inc.com(10.147.41.121); Sun, 13 Jun 2021 16:26:31 +0800 Date: Sun, 13 Jun 2021 16:26:28 +0800 From: =?UTF-8?B?5ZGo55Cw5p2w?= To: Andrew Lunn Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, sihui.liu@ingenic.com, jun.jiang@ingenic.com, sernia.zhou@foxmail.com, paul@crapouillou.net Subject: Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support. Message-ID: <20210613162628.2a21d7ea@zhouyanjie-virtual-machine> In-Reply-To: References: <1623260110-25842-1-git-send-email-zhouyanjie@wanyeetech.com> <1623260110-25842-3-git-send-email-zhouyanjie@wanyeetech.com> <405696cb-5987-0e56-87f8-5a1443eadc19@wanyeetech.com> <346f64d9-6949-b506-258f-4cfa7eb22784@wanyeetech.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, 于 Thu, 10 Jun 2021 16:42:24 +0200 Andrew Lunn 写道: > > We are much more strict about this now than before. You have to > > use standard units and convert to hardware values. It also makes it > > a lot easier for DT writers, if they have an idea what the units > > mean. > > > > Having the MAC add small delays is something you can add later, > > without breaking backwards compatibility. So if you cannot > > determine what the units are now, just submit the glue driver > > without support for this feature. If anybody really needs it, they > > can do the needed research, maybe do some measurements, and then > > add the code. > > > > > > I did an experiment, when the tx delay is not set, RGMII works a > > You had rgmii-id in your device tree, so that the PHY added the > delays? I have tried rgmii-id and rgmii-txid. If we don’t add a fine-tuning parameter, it still can’t work properly. In these two modes, we still need to add about 500ps delay on the mac side to ensure it works properly. Thanks and best regards! > > Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDEC3C48BDF for ; Sun, 13 Jun 2021 08:28:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 838046108D for ; Sun, 13 Jun 2021 08:28:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 838046108D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wanyeetech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0y3YZE9vTKRBXCYEszE8vxrLKZhcHYzCol+PAdHUhj8=; b=ULibWX5tpQKaTH jrGdCQjIJwZKVqvZ3cCNFuMJHjeo7v3INFrrK1XJEmKvRTl3Ay8PSonSwCWwZnuMyouPtCsf3QzbZ 3f8cRw7uQ0xdZtz1AhTwP4oJPDR+vGohGZsFjQTVonE9GNWTeFBl0RSD46qgL3jM0yMESHvT64M3k Bdnf6lctdnjKdoDzanXAdDAw6ckj764LcA3gKm9RK0qLJWMOYHFn4hgeqEqAWqyShi2QH2KkGdC8f 6OnpG4Oa7+HdeG1X7w4I3dvd5XJyRCml5n1GjpzNOnoAfoG96Q5zS1Dml3RPJVejN6WKiY0JkjSdy Lx8EWQ6vUo73Y8OM4RiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsLSW-009wex-4X; Sun, 13 Jun 2021 08:27:09 +0000 Received: from out28-147.mail.aliyun.com ([115.124.28.147]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsLS2-009wT2-CH for linux-arm-kernel@lists.infradead.org; Sun, 13 Jun 2021 08:26:40 +0000 X-Alimail-AntiSpam: AC=CONTINUE; BC=0.1052365|-1; CH=green; DM=|CONTINUE|false|; DS=CONTINUE|ham_regular_dialog|0.0758817-0.0072256-0.916893; FP=0|0|0|0|0|-1|-1|-1; HT=ay29a033018047201; MF=zhouyanjie@wanyeetech.com; NM=1; PH=DS; RN=21; RT=21; SR=0; TI=SMTPD_---.KRgdwVg_1623572789; Received: from zhouyanjie-virtual-machine(mailfrom:zhouyanjie@wanyeetech.com fp:SMTPD_---.KRgdwVg_1623572789) by smtp.aliyun-inc.com(10.147.41.121); Sun, 13 Jun 2021 16:26:31 +0800 Date: Sun, 13 Jun 2021 16:26:28 +0800 From: =?UTF-8?B?5ZGo55Cw5p2w?= To: Andrew Lunn Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, sihui.liu@ingenic.com, jun.jiang@ingenic.com, sernia.zhou@foxmail.com, paul@crapouillou.net Subject: Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support. Message-ID: <20210613162628.2a21d7ea@zhouyanjie-virtual-machine> In-Reply-To: References: <1623260110-25842-1-git-send-email-zhouyanjie@wanyeetech.com> <1623260110-25842-3-git-send-email-zhouyanjie@wanyeetech.com> <405696cb-5987-0e56-87f8-5a1443eadc19@wanyeetech.com> <346f64d9-6949-b506-258f-4cfa7eb22784@wanyeetech.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210613_012638_644989_DC59A7E8 X-CRM114-Status: GOOD ( 15.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQW5kcmV3LAoK5LqOIFRodSwgMTAgSnVuIDIwMjEgMTY6NDI6MjQgKzAyMDAKQW5kcmV3IEx1 bm4gPGFuZHJld0BsdW5uLmNoPiDlhpnpgZM6Cgo+ID4gICAgIFdlIGFyZSBtdWNoIG1vcmUgc3Ry aWN0IGFib3V0IHRoaXMgbm93IHRoYW4gYmVmb3JlLiBZb3UgaGF2ZSB0bwo+ID4gdXNlIHN0YW5k YXJkIHVuaXRzIGFuZCBjb252ZXJ0IHRvIGhhcmR3YXJlIHZhbHVlcy4gSXQgYWxzbyBtYWtlcyBp dAo+ID4gYSBsb3QgZWFzaWVyIGZvciBEVCB3cml0ZXJzLCBpZiB0aGV5IGhhdmUgYW4gaWRlYSB3 aGF0IHRoZSB1bml0cwo+ID4gbWVhbi4KPiA+IAo+ID4gICAgIEhhdmluZyB0aGUgTUFDIGFkZCBz bWFsbCBkZWxheXMgaXMgc29tZXRoaW5nIHlvdSBjYW4gYWRkIGxhdGVyLAo+ID4gICAgIHdpdGhv dXQgYnJlYWtpbmcgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkuIFNvIGlmIHlvdSBjYW5ub3QKPiA+ IGRldGVybWluZSB3aGF0IHRoZSB1bml0cyBhcmUgbm93LCBqdXN0IHN1Ym1pdCB0aGUgZ2x1ZSBk cml2ZXIKPiA+IHdpdGhvdXQgc3VwcG9ydCBmb3IgdGhpcyBmZWF0dXJlLiBJZiBhbnlib2R5IHJl YWxseSBuZWVkcyBpdCwgdGhleQo+ID4gY2FuIGRvIHRoZSBuZWVkZWQgcmVzZWFyY2gsIG1heWJl IGRvIHNvbWUgbWVhc3VyZW1lbnRzLCBhbmQgdGhlbgo+ID4gYWRkIHRoZSBjb2RlLgo+ID4gCj4g PiAKPiA+IEkgZGlkIGFuIGV4cGVyaW1lbnQsIHdoZW4gdGhlIHR4IGRlbGF5IGlzIG5vdCBzZXQs IFJHTUlJIHdvcmtzIGEgIAo+IAo+IFlvdSBoYWQgcmdtaWktaWQgaW4geW91ciBkZXZpY2UgdHJl ZSwgc28gdGhhdCB0aGUgUEhZIGFkZGVkIHRoZQo+IGRlbGF5cz8KCkkgaGF2ZSB0cmllZCByZ21p aS1pZCBhbmQgcmdtaWktdHhpZC4gSWYgd2UgZG9u4oCZdCBhZGQgYSBmaW5lLXR1bmluZwpwYXJh bWV0ZXIsIGl0IHN0aWxsIGNhbuKAmXQgd29yayBwcm9wZXJseS4gSW4gdGhlc2UgdHdvIG1vZGVz LCB3ZSBzdGlsbApuZWVkIHRvIGFkZCBhYm91dCA1MDBwcyBkZWxheSBvbiB0aGUgbWFjIHNpZGUg dG8gZW5zdXJlIGl0IHdvcmtzCnByb3Blcmx5LgoKVGhhbmtzIGFuZCBiZXN0IHJlZ2FyZHMhCgo+ IAo+IAlBbmRyZXcKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK