From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3492FC48BE8 for ; Sun, 13 Jun 2021 21:17:26 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE4B76120E for ; Sun, 13 Jun 2021 21:17:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE4B76120E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=me.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsXTw-0006tZ-Tt for qemu-devel@archiver.kernel.org; Sun, 13 Jun 2021 17:17:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33428) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsXT2-0005Kj-HA for qemu-devel@nongnu.org; Sun, 13 Jun 2021 17:16:28 -0400 Received: from mr85p00im-ztdg06021101.me.com ([17.58.23.180]:54940) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsXT1-0001KP-1a for qemu-devel@nongnu.org; Sun, 13 Jun 2021 17:16:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1623618986; bh=gkzEzR9JMEx0r3GztDkbytTr1BhXloZjlUExOBrQRNg=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=VDLP3reFWo+7l+Ghhj54kZsnUx2S2TIn9nv2q5ZWZYNapJWj1FMMWthNWHM6vZuqy QQIaLmjexjSiveISXUqjG5JLghFilNebLIIZ5hNxhQJrclnEY13KlX2HbIdTtxolmy WxJhpeqwuTrjDvlA5JtaxgH4Rmvj/W/D8o+WRlXiAu93XPxK7/F+M844LNd4f3uOis 3K9qOcWRC0Vgq4GTPUVSOocq2ilDOei3QjEoKsTqMQPPjnKU7Ltc49lSlkm8efbSRQ xthQlupadGJEcksvdlgtoYr+hicdL5Jqgsbp7SA/CoC6uyH2QxdGVDvhQfpigPZyeE y9DjmCQmGAIRQ== Received: from the-ripe-vessel.ktnet (c-67-180-181-196.hsd1.ca.comcast.net [67.180.181.196]) by mr85p00im-ztdg06021101.me.com (Postfix) with ESMTPSA id 8CAB5340267; Sun, 13 Jun 2021 21:16:25 +0000 (UTC) From: Jason Thorpe To: qemu-devel@nongnu.org Cc: Jason Thorpe , richard.henderson@linaro.org Subject: [PATCH 1/4] mc146818rtc: Make PF independent of PIE Date: Sun, 13 Jun 2021 14:15:46 -0700 Message-Id: <20210613211549.18094-2-thorpej@me.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210613211549.18094-1-thorpej@me.com> References: <20210613211549.18094-1-thorpej@me.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.391,18.0.761,17.0.607.475.0000000_definitions?= =?UTF-8?Q?=3D2021-06-13=5F09:2021-06-11=5F06,2021-06-13=5F09,2020-04-07?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=625 mlxscore=0 spamscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2106130151 Received-SPF: pass client-ip=17.58.23.180; envelope-from=thorpej@me.com; helo=mr85p00im-ztdg06021101.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Make the PF flag behave like real hardware by always running the periodic timer without regard to the setting of the PIE bit, so that the PF will be set when the period expires even if an interrupt will not be raised. This behavior is documented on page 16 of the MC146818A advance information datasheet. Signed-off-by: Jason Thorpe --- hw/rtc/mc146818rtc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c index 4fbafddb22..366b8f13de 100644 --- a/hw/rtc/mc146818rtc.c +++ b/hw/rtc/mc146818rtc.c @@ -155,10 +155,6 @@ static uint32_t rtc_periodic_clock_ticks(RTCState *s) { int period_code; - if (!(s->cmos_data[RTC_REG_B] & REG_B_PIE)) { - return 0; - } - period_code = s->cmos_data[RTC_REG_A] & 0x0f; return periodic_period_to_clock(period_code); -- 2.30.2