From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8790FC48BE6 for ; Mon, 14 Jun 2021 07:22:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66420613C6 for ; Mon, 14 Jun 2021 07:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232538AbhFNHZA (ORCPT ); Mon, 14 Jun 2021 03:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232482AbhFNHY7 (ORCPT ); Mon, 14 Jun 2021 03:24:59 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8725CC061574 for ; Mon, 14 Jun 2021 00:22:56 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id p17so19408392lfc.6 for ; Mon, 14 Jun 2021 00:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TuRZz017BBgAVMKoaGy8N3HYwV0bwLZwAUPuHJ32orA=; b=j3sOCJmU0K3TcI1KaLS+R0w+7P4R3fFjhK6QrhK/0X3pmdqGTXcLOu9Mh+/PRHiVjp ng8pGzd/d32BjnDvgz6z8K4NIdl6EGusDd9sTUM093jnnIl6qvkKH2Ska/1JVnQ5QSvP g4sBX5WqMiYo3up8gTRaq9Qk3U1/Qdqyx7dfO39kNGcg7OHhT916iippBIYouH9gKV+h OcvehJpHou6mwIp9dmXDM6GxIG05eKdOJnvYX0Ojkc45xTt2BB6mzP3+7QELscdwKobF AJLVee+P8OlUIGuy3x/mFcZm6E5dfkT4graQf5gbDGqgxzRopeT2tj51qBCyhMJc2/E3 9V5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TuRZz017BBgAVMKoaGy8N3HYwV0bwLZwAUPuHJ32orA=; b=K3w2bqRmtDgPtoBkFs0kufpRkufa7XXHhLbNcNuzCOiYEsclGb1rgiX+2k/i/htIuZ ag8P7o06ggNNjcoqhAr2v8HnU7lvcnENdNmmrGJPGPHP54Kzq5/iaU/DD7ArjVU1VmU+ nPsxMLkwT2C9aqXLwXkNOz4OL4XbMrsAad2k7WqnFfhsTuyBJsf3zze4mKUBC5xCACVg H0uXPwyrqWqBu9JLHn9dEMkjn/IIYVawxDa4gv6GkdnjNZ0Zp4gnNkWiAQyiZklDuwFE ZRCz/Wn6fQ/jhL/z/MFYAFyBah+S0Is2I6Rq2ps2rVTuE9Chpjf1blbadKJ9AV7GTvuO TK8w== X-Gm-Message-State: AOAM533Tcgie8GpujGMy6D7FkpehvyW+rTlvsEjeX+xlLDISWbe1JvD6 /+Kt339EXWbJrl2igP6NIQ5kdA== X-Google-Smtp-Source: ABdhPJyqZXHBxomzhuOZfIuf8Zs1x2UeitiGj4p9X56ysLMGca0c8XfXDemfx0jK2rmoRfMdEvLh9w== X-Received: by 2002:a19:5e5b:: with SMTP id z27mr7650041lfi.403.1623655374886; Mon, 14 Jun 2021 00:22:54 -0700 (PDT) Received: from jade (h-79-136-85-3.A175.priv.bahnhof.se. [79.136.85.3]) by smtp.gmail.com with ESMTPSA id v2sm1390309lfi.115.2021.06.14.00.22.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jun 2021 00:22:54 -0700 (PDT) Date: Mon, 14 Jun 2021 09:22:52 +0200 From: Jens Wiklander To: Tyler Hicks Cc: Allen Pais , Sumit Garg , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Vikas Gupta , Thirupathaiah Annapureddy , Pavel Tatashin , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , op-tee@lists.trustedfirmware.org, linux-integrity@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 3/8] optee: fix tee out of memory failure seen during kexec reboot Message-ID: <20210614072252.GB1033436@jade> References: <20210610210913.536081-1-tyhicks@linux.microsoft.com> <20210610210913.536081-4-tyhicks@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210610210913.536081-4-tyhicks@linux.microsoft.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 04:09:08PM -0500, Tyler Hicks wrote: > From: Allen Pais > > The following out of memory errors are seen on kexec reboot > from the optee core. > > [ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed > [ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22 > > tee_shm_release() is not invoked on dma shm buffer. > > Implement .shutdown() method to handle the release of the buffers > correctly. > > More info: > https://github.com/OP-TEE/optee_os/issues/3637 > > Signed-off-by: Allen Pais > Reviewed-by: Tyler Hicks > --- > drivers/tee/optee/core.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) Reviewed-by: Jens Wiklander