From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77167C48BE8 for ; Mon, 14 Jun 2021 07:35:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 013C2610A2 for ; Mon, 14 Jun 2021 07:35:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 013C2610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsh8V-00089k-IZ for qemu-devel@archiver.kernel.org; Mon, 14 Jun 2021 03:35:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsh6k-0005SI-96 for qemu-devel@nongnu.org; Mon, 14 Jun 2021 03:34:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsh6h-0004uu-0R for qemu-devel@nongnu.org; Mon, 14 Jun 2021 03:34:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623656042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=M7dxoDED9iUmUnEg0oC536in8eHKFuvecxS6b2sGT9g=; b=fkhYbXLhFozSZpqmtHcsUiR2rx89F7u/utvzzyWZe6KXlRrXEGWF3QN//5vFoAlWWT1uSr XhVkcXaiX4lFTN0fc+Nwdt27jw17MK30UHO2GheKMu4pyliXedC81TqQmIk0wbQTBO2Kp2 6MNkYWrFhzHnzpD9LSExpVpeOdHw3PQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-3vFmRC6gNqO2t3oEiLEIww-1; Mon, 14 Jun 2021 03:33:59 -0400 X-MC-Unique: 3vFmRC6gNqO2t3oEiLEIww-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1DB7D100C660; Mon, 14 Jun 2021 07:33:58 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-49.ams2.redhat.com [10.36.113.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6BFE75D6A8; Mon, 14 Jun 2021 07:33:52 +0000 (UTC) From: Emanuele Giuseppe Esposito To: qemu-block@nongnu.org Subject: [PATCH v4 0/6] block-copy: protect block-copy internal structures Date: Mon, 14 Jun 2021 09:33:44 +0200 Message-Id: <20210614073350.17048-1-eesposit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eesposit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Received-SPF: pass client-ip=216.205.24.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Emanuele Giuseppe Esposito , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This serie of patches aims to reduce the usage of the AioContexlock in block-copy, by introducing smaller granularity locks thus on making the block layer thread safe. This serie depends on my previous serie that brings thread safety to the smaller API used by block-copy, like ratelimit, progressmeter abd co-shared-resource. What's missing for block-copy to be fully thread-safe is fixing the CoSleep API to allow cross-thread sleep and wakeup. Paolo is working on it. Patch 1 provides a small refactoring, patch 2 introduces the .method field in BlockCopyState, to be used instead of .use_copy_range, .copy_size and .zeros. Patch 3-4 provide comments and refactoring in preparation to the lock added in patch 5 on BlockCopyTask, BlockCopyCallState and BlockCopyState. Patch 6 uses load_acquire/store_release to make sure BlockCopyCallState OUT fields are updated before finished is set to true. Based-on: <20210518094058.25952-1-eesposit@redhat.com> Signed-off-by: Emanuele Giuseppe Esposito --- v4: * Introduce patch 1 (refactoring) * Adjust to Vladimir's style comments in patch 2 [Paolo, Vladimir] * Extend the lock to cover an additional race condition in block_copy_common [Vladimir] Emanuele Giuseppe Esposito (5): block-copy: small refactor in block_copy_task_entry and block_copy_common block-copy: improve comments of BlockCopyTask and BlockCopyState types and functions block-copy: move progress_set_remaining in block_copy_task_end block-copy: add a CoMutex block-copy: atomic .cancelled and .finished fields in BlockCopyCallState Paolo Bonzini (1): block-copy: streamline choice of copy_range vs. read/write block/block-copy.c | 327 ++++++++++++++++++++++--------------- include/block/block-copy.h | 2 + 2 files changed, 197 insertions(+), 132 deletions(-) -- 2.31.1