All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arkadiusz Hiler <arek@hiler.eu>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Petri Latvala <petri.latvala@intel.com>,
	IGT development <igt-dev@lists.freedesktop.org>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/7] Revert "test/i915/gem_exec_reloc: Restore interclient testings"
Date: Mon, 14 Jun 2021 13:40:32 +0300	[thread overview]
Message-ID: <20210614104003.enhrwqwa42tcwidn@hatecraft.localdomain> (raw)
In-Reply-To: <20210608094020.21598-2-daniel.vetter@ffwll.ch>

On Tue, Jun 08, 2021 at 11:40:15AM +0200, Daniel Vetter wrote:
> This reverts commit cf2f41b3d3dfabaf3a4837062f996f3491a350b1.
> 
> And I mean revert with extreme prejudice because this was already
> thrown out in
> 
> commit 39e9aa1032a4e60f776f34b3ccf4fb728abbfe5c
> Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Date:   Mon Aug 10 11:00:34 2020 +0200
> 
>     tests/i915: Remove subtests that rely on async relocation behavior
> 
> and Chris then decided to undo that without any acks from the people
> who've removed these tests. Or well anyone else. Commit fights in
> upstream repositories are not acceptable.

Acked-by: Arkadiusz Hiler <arek@hiler.eu>

on the whole series, but especially on this patch.

Thanks for catching it and calling it out.

The full review is up to people familiar with Intel's hardware.

-- 
Cheers,
Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2021-06-14 11:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08  9:40 [igt-dev] [PATCH i-g-t 1/7] tests/gem_exec_reloc: Remove banned tests Daniel Vetter
2021-06-08  9:40 ` [igt-dev] [PATCH i-g-t 2/7] Revert "test/i915/gem_exec_reloc: Restore interclient testings" Daniel Vetter
2021-06-09 17:56   ` Jason Ekstrand
2021-06-14 10:40   ` Arkadiusz Hiler [this message]
2021-06-08  9:40 ` [igt-dev] [PATCH i-g-t 3/7] Revert "i915/gem_exec_reloc: Verify engine isolation" Daniel Vetter
2021-06-09 17:59   ` Jason Ekstrand
2021-06-08  9:40 ` [igt-dev] [PATCH i-g-t 4/7] Revert "i915/gem_exec_reloc: Exercise concurrent relocations" Daniel Vetter
2021-06-09 18:12   ` Jason Ekstrand
2021-06-08  9:40 ` [igt-dev] [PATCH i-g-t 5/7] Revert "i915/gem_exec_reloc: Flood the ring with GPU relocs" Daniel Vetter
2021-06-09 18:05   ` Jason Ekstrand
2021-06-08  9:40 ` [igt-dev] [PATCH i-g-t 6/7] Revert "i915/gem_exec_reloc: Check that relocations do not block" Daniel Vetter
2021-06-09 18:03   ` Jason Ekstrand
2021-06-08  9:40 ` [igt-dev] [PATCH i-g-t 7/7] tests/gem_exec_schedule: Use store_dword_plug again Daniel Vetter
2021-06-08 11:22 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/7] tests/gem_exec_reloc: Remove banned tests Patchwork
2021-06-08 16:02 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-06-08 19:25 ` [igt-dev] [PATCH i-g-t] " Daniel Vetter
2021-06-09 17:53   ` Jason Ekstrand
2021-06-08 19:44 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t] tests/gem_exec_reloc: Remove banned tests (rev2) Patchwork
2021-06-08 20:08 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2021-06-09  0:49 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-06-08  9:38 [igt-dev] [PATCH i-g-t 1/7] tests/gem_exec_reloc: Remove banned tests Daniel Vetter
2021-06-08  9:38 ` [igt-dev] [PATCH i-g-t 2/7] Revert "test/i915/gem_exec_reloc: Restore interclient testings" Daniel Vetter
2021-06-07  9:29 [igt-dev] [PATCH i-g-t 1/7] tests/gem_exec_reloc: Remove banned tests Daniel Vetter
2021-06-07  9:29 ` [igt-dev] [PATCH i-g-t 2/7] Revert "test/i915/gem_exec_reloc: Restore interclient testings" Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210614104003.enhrwqwa42tcwidn@hatecraft.localdomain \
    --to=arek@hiler.eu \
    --cc=airlied@redhat.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.