All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: linux-media@vger.kernel.org, Lokesh Vutla <lokeshvutla@ti.com>,
	Pratyush Yadav <p.yadav@ti.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Subject: [PATCH v4 05/35] media: ti-vpe: cal: move global config from cal_ctx_wr_dma_config to runtime resume
Date: Mon, 14 Jun 2021 14:23:15 +0300	[thread overview]
Message-ID: <20210614112345.2032435-6-tomi.valkeinen@ideasonboard.com> (raw)
In-Reply-To: <20210614112345.2032435-1-tomi.valkeinen@ideasonboard.com>

For some reason CAL_CTRL is written at the end of cal_ctx_wr_dma_config.
CAL_CTRL is a global (for CAL) register, so it should be independent of
contexts.

Move the code to cal_runtime_resume().

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/media/platform/ti-vpe/cal.c | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
index 9446933b9189..2f70725a567b 100644
--- a/drivers/media/platform/ti-vpe/cal.c
+++ b/drivers/media/platform/ti-vpe/cal.c
@@ -403,17 +403,6 @@ static void cal_ctx_wr_dma_config(struct cal_ctx *ctx)
 	cal_write(ctx->cal, CAL_WR_DMA_XSIZE(ctx->index), val);
 	ctx_dbg(3, ctx, "CAL_WR_DMA_XSIZE(%d) = 0x%08x\n", ctx->index,
 		cal_read(ctx->cal, CAL_WR_DMA_XSIZE(ctx->index)));
-
-	val = cal_read(ctx->cal, CAL_CTRL);
-	cal_set_field(&val, CAL_CTRL_BURSTSIZE_BURST128,
-		      CAL_CTRL_BURSTSIZE_MASK);
-	cal_set_field(&val, 0xF, CAL_CTRL_TAGCNT_MASK);
-	cal_set_field(&val, CAL_CTRL_POSTED_WRITES_NONPOSTED,
-		      CAL_CTRL_POSTED_WRITES_MASK);
-	cal_set_field(&val, 0xFF, CAL_CTRL_MFLAGL_MASK);
-	cal_set_field(&val, 0xFF, CAL_CTRL_MFLAGH_MASK);
-	cal_write(ctx->cal, CAL_CTRL, val);
-	ctx_dbg(3, ctx, "CAL_CTRL = 0x%08x\n", cal_read(ctx->cal, CAL_CTRL));
 }
 
 void cal_ctx_set_dma_addr(struct cal_ctx *ctx, dma_addr_t addr)
@@ -1127,6 +1116,7 @@ static int cal_runtime_resume(struct device *dev)
 {
 	struct cal_dev *cal = dev_get_drvdata(dev);
 	unsigned int i;
+	u32 val;
 
 	if (cal->data->flags & DRA72_CAL_PRE_ES2_LDO_DISABLE) {
 		/*
@@ -1143,6 +1133,17 @@ static int cal_runtime_resume(struct device *dev)
 	 */
 	cal_write(cal, CAL_HL_IRQENABLE_SET(0), CAL_HL_IRQ_OCPO_ERR_MASK);
 
+	val = cal_read(cal, CAL_CTRL);
+	cal_set_field(&val, CAL_CTRL_BURSTSIZE_BURST128,
+		      CAL_CTRL_BURSTSIZE_MASK);
+	cal_set_field(&val, 0xf, CAL_CTRL_TAGCNT_MASK);
+	cal_set_field(&val, CAL_CTRL_POSTED_WRITES_NONPOSTED,
+		      CAL_CTRL_POSTED_WRITES_MASK);
+	cal_set_field(&val, 0xff, CAL_CTRL_MFLAGL_MASK);
+	cal_set_field(&val, 0xff, CAL_CTRL_MFLAGH_MASK);
+	cal_write(cal, CAL_CTRL, val);
+	cal_dbg(3, cal, "CAL_CTRL = 0x%08x\n", cal_read(cal, CAL_CTRL));
+
 	return 0;
 }
 
-- 
2.25.1


  parent reply	other threads:[~2021-06-14 11:28 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 11:23 [PATCH v4 00/35] media: ti-vpe: cal: improvements towards multistrea Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 01/35] media: ti-vpe: cal: add g/s_parm for legacy API Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 02/35] media: ti-vpe: cal: fix error handling in cal_camerarx_create Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 03/35] media: ti-vpe: cal: remove unused cal_camerarx->dev field Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 04/35] media: ti-vpe: cal: rename "sensor" to "source" Tomi Valkeinen
2021-06-14 11:23 ` Tomi Valkeinen [this message]
2021-06-14 11:23 ` [PATCH v4 06/35] media: ti-vpe: cal: use v4l2_get_link_freq Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 07/35] media: ti-vpe: cal: add cal_ctx_prepare/unprepare Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 08/35] media: ti-vpe: cal: change index and cport to u8 Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 09/35] media: ti-vpe: cal: Add CSI2 context Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 10/35] media: ti-vpe: cal: Add pixel processing context Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 11/35] media: ti-vpe: cal: rename cal_ctx->index to dma_ctx Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 12/35] media: ti-vpe: cal: rename CAL_HL_IRQ_MASK Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 13/35] media: ti-vpe: cal: clean up CAL_CSI2_VC_IRQ_* macros Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 14/35] media: ti-vpe: cal: catch VC errors Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 15/35] media: ti-vpe: cal: remove wait when stopping camerarx Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 16/35] media: ti-vpe: cal: disable csi2 ctx and pix proc at ctx_stop Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 17/35] media: ti-vpe: cal: allocate pix proc dynamically Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 18/35] media: ti-vpe: cal: add 'use_pix_proc' field Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 19/35] media: ti-vpe: cal: add cal_ctx_wr_dma_enable and fix a race Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 20/35] media: ti-vpe: cal: add vc and datatype fields to cal_ctx Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 21/35] media: ti-vpe: cal: handle cal_ctx_v4l2_register error Tomi Valkeinen
2021-06-14 20:36   ` Laurent Pinchart
2021-06-14 11:23 ` [PATCH v4 22/35] media: ti-vpe: cal: set field always to V4L2_FIELD_NONE Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 23/35] media: ti-vpe: cal: fix typo in a comment Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 24/35] media: ti-vpe: cal: add mbus_code support to cal_mc_enum_fmt_vid_cap Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 25/35] media: ti-vpe: cal: rename non-MC funcs to cal_legacy_* Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 26/35] media: ti-vpe: cal: init ctx->v_fmt correctly in MC mode Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 27/35] media: ti-vpe: cal: remove cal_camerarx->fmtinfo Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 28/35] media: ti-vpe: cal: support 8 DMA contexts Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 29/35] media: ti-vpe: cal: cleanup phy iteration in cal_remove Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 30/35] media: ti-vpe: cal: fix ctx uninitialization Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 31/35] media: ti-vpe: cal: fix queuing of the initial buffer Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 32/35] media: ti-vpe: cal: add camerarx locking Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 33/35] media: ti-vpe: cal: add camerarx enable/disable refcounting Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 34/35] media: ti-vpe: cal: allow more than 1 source pads Tomi Valkeinen
2021-06-14 11:23 ` [PATCH v4 35/35] media: ti-vpe: cal: add embedded data support Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210614112345.2032435-6-tomi.valkeinen@ideasonboard.com \
    --to=tomi.valkeinen@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=p.yadav@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.