From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 651A0C49EA2 for ; Mon, 14 Jun 2021 11:39:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4331361105 for ; Mon, 14 Jun 2021 11:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235588AbhFNLlT (ORCPT ); Mon, 14 Jun 2021 07:41:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:55708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236127AbhFNL3r (ORCPT ); Mon, 14 Jun 2021 07:29:47 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 64100610A1; Mon, 14 Jun 2021 11:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623670064; bh=2rY2tAo241vX6ekFHgV1yvqOPbGBmy18m5WLXiLqfeE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iOuiFxjSh80/mdRceoX2xOb5QbpLlHTQbi+rVVDf2f2VlXYzWQ8Ize0UMp/alOLaF AoOxZuDyYT4+GWocZ49wSxFKUrPDfxEWAGyYKlnU/Jgqo+mIVbBVuMaLmnni/mMiBv L9Ulk/ntWSNtHpUtjH4WFaAZ4sc21qCsB6BhM7grhPC7ZN1nH4n1xJCejKkuGuyApt ao1/BEpgn+k8QggMfxP6JXc4dWOEtSLugtluKJUxMvIVPYovSvlWSTX4R+xcPuS3zQ bihwlM5ANdd+WJQExzG902nQ9A3cQ3HzU0lTSxAdLry3+BJ5rlYCuumxkD2n6F8+G+ S+VRXos4WvSaA== Date: Mon, 14 Jun 2021 16:57:33 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] ARM: dts: owl-s500-roseapplepi: Add ethernet support Message-ID: <20210614112733.GA38584@thinkpad> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 11, 2021 at 12:11:33PM +0300, Cristian Ciocaltea wrote: > Add pinctrl configuration for enabling the Ethernet MAC on RoseapplePi > SBC. Additionally, provide the necessary properties for the generic S500 > ethernet node in order to setup PHY and MDIO. > > Signed-off-by: Cristian Ciocaltea Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > index b8c5db2344aa..eb555f385283 100644 > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > @@ -225,6 +225,27 @@ bias1-pinconf { > bias-pull-down; > }; > }; > + > + ethernet_pins: ethernet-pins { > + eth_rmii-pinmux { > + groups = "rmii_txd0_mfp", "rmii_txd1_mfp", > + "rmii_rxd0_mfp", "rmii_rxd1_mfp", > + "rmii_txen_mfp", "rmii_rxen_mfp", > + "rmii_crs_dv_mfp", "rmii_ref_clk_mfp"; > + function = "eth_rmii"; > + }; > + > + phy_clk-pinmux { > + groups = "clko_25m_mfp"; > + function = "clko_25m"; > + }; > + > + ref_clk-pinconf { > + groups = "rmii_ref_clk_drv"; > + drive-strength = <2>; > + }; > + > + }; > }; > > /* uSD */ > @@ -241,6 +262,30 @@ &mmc0 { > vqmmc-supply = <&sd_vcc>; > }; > > +ðernet { > + pinctrl-names = "default"; > + pinctrl-0 = <ðernet_pins>; > + phy-mode = "rmii"; > + phy-handle = <ð_phy>; > + status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reset-gpios = <&pinctrl 88 GPIO_ACTIVE_LOW>; /* GPIOC24 */ > + reset-delay-us = <10000>; > + reset-post-delay-us = <150000>; > + > + eth_phy: ethernet-phy@3 { > + reg = <0x3>; > + max-speed = <100>; > + interrupt-parent = <&sirq>; > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +}; > + > &twd_timer { > status = "okay"; > }; > -- > 2.32.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CF4C4743C for ; Mon, 14 Jun 2021 11:29:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E25F610A2 for ; Mon, 14 Jun 2021 11:29:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E25F610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zNc62xzpstCZAJ2wrGD7O0R6kgF1JVMf7K4q0sYRPS0=; b=rdFpWQEmYfoBMr urc518ERbFQdt8TCX5H10qtOW7pOFcLxErJxjGeD7F5faHhlnmYBp26I72OQN8LjyF7kB9kgeaA3u YO4S6j24N/KRYNQzfdfpI9sOAXEuAcKNUP+pMFj1z12ZKM4GLPqkaMOpzeoWGj0oDX3ug534E9/Sv 9d1rd0yG17thflL/CXrE0bd4J1rFHgtO41y/0mWApb3x3YOPVy3HqTmtsnxi5frL3cO4V8F1R0hOR z9PWGO1K2GYgcn7+ZFkPlXnOhUxGbjGI/CkpyHOAy2vGfWzfoVEBuHJGQwju1FNgYhP29iPMcoVIT iXDT7uqNYG7xLV3ZXH6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lskku-00DqqY-OS; Mon, 14 Jun 2021 11:27:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lskkr-00Dqpw-2A; Mon, 14 Jun 2021 11:27:46 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 64100610A1; Mon, 14 Jun 2021 11:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623670064; bh=2rY2tAo241vX6ekFHgV1yvqOPbGBmy18m5WLXiLqfeE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iOuiFxjSh80/mdRceoX2xOb5QbpLlHTQbi+rVVDf2f2VlXYzWQ8Ize0UMp/alOLaF AoOxZuDyYT4+GWocZ49wSxFKUrPDfxEWAGyYKlnU/Jgqo+mIVbBVuMaLmnni/mMiBv L9Ulk/ntWSNtHpUtjH4WFaAZ4sc21qCsB6BhM7grhPC7ZN1nH4n1xJCejKkuGuyApt ao1/BEpgn+k8QggMfxP6JXc4dWOEtSLugtluKJUxMvIVPYovSvlWSTX4R+xcPuS3zQ bihwlM5ANdd+WJQExzG902nQ9A3cQ3HzU0lTSxAdLry3+BJ5rlYCuumxkD2n6F8+G+ S+VRXos4WvSaA== Date: Mon, 14 Jun 2021 16:57:33 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] ARM: dts: owl-s500-roseapplepi: Add ethernet support Message-ID: <20210614112733.GA38584@thinkpad> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_042745_156199_6BD61619 X-CRM114-Status: GOOD ( 14.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 11, 2021 at 12:11:33PM +0300, Cristian Ciocaltea wrote: > Add pinctrl configuration for enabling the Ethernet MAC on RoseapplePi > SBC. Additionally, provide the necessary properties for the generic S500 > ethernet node in order to setup PHY and MDIO. > > Signed-off-by: Cristian Ciocaltea Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > arch/arm/boot/dts/owl-s500-roseapplepi.dts | 45 ++++++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm/boot/dts/owl-s500-roseapplepi.dts b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > index b8c5db2344aa..eb555f385283 100644 > --- a/arch/arm/boot/dts/owl-s500-roseapplepi.dts > +++ b/arch/arm/boot/dts/owl-s500-roseapplepi.dts > @@ -225,6 +225,27 @@ bias1-pinconf { > bias-pull-down; > }; > }; > + > + ethernet_pins: ethernet-pins { > + eth_rmii-pinmux { > + groups = "rmii_txd0_mfp", "rmii_txd1_mfp", > + "rmii_rxd0_mfp", "rmii_rxd1_mfp", > + "rmii_txen_mfp", "rmii_rxen_mfp", > + "rmii_crs_dv_mfp", "rmii_ref_clk_mfp"; > + function = "eth_rmii"; > + }; > + > + phy_clk-pinmux { > + groups = "clko_25m_mfp"; > + function = "clko_25m"; > + }; > + > + ref_clk-pinconf { > + groups = "rmii_ref_clk_drv"; > + drive-strength = <2>; > + }; > + > + }; > }; > > /* uSD */ > @@ -241,6 +262,30 @@ &mmc0 { > vqmmc-supply = <&sd_vcc>; > }; > > +ðernet { > + pinctrl-names = "default"; > + pinctrl-0 = <ðernet_pins>; > + phy-mode = "rmii"; > + phy-handle = <ð_phy>; > + status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + reset-gpios = <&pinctrl 88 GPIO_ACTIVE_LOW>; /* GPIOC24 */ > + reset-delay-us = <10000>; > + reset-post-delay-us = <150000>; > + > + eth_phy: ethernet-phy@3 { > + reg = <0x3>; > + max-speed = <100>; > + interrupt-parent = <&sirq>; > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +}; > + > &twd_timer { > status = "okay"; > }; > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel