From: Jakub Kicinski <kuba@kernel.org>
To: Jonathan Davies <jonathan.davies@nutanix.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, andrew@lunn.ch
Subject: Re: [PATCH] net: usbnet: allow overriding of default USB interface naming
Date: Mon, 14 Jun 2021 12:20:00 -0700 [thread overview]
Message-ID: <20210614122000.7cdef052@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <80b6e3ab-6b8f-abaa-9d20-859c89789add@nutanix.com>
On Mon, 14 Jun 2021 15:53:53 +0100 Jonathan Davies wrote:
> >> Compare implementations of rename_netif in
> >> https://git.kernel.org/pub/scm/linux/hotplug/udev.git/tree/src/udev-event.c
> >> (traditional udev, which handles collisions) and
> >> https://github.com/systemd/systemd/blob/main/src/udev/udev-event.c
> >> (systemd-udevd, which does not handle collisions).
That explains some user reports I've been seeing :o
> > Then submit a change to add the logic back. This looks like a userspace
> > tool breaking existing setups, so please take it up with the developers
> > of that tool. The kernel has not changed or "broken" anything here.
>
> (I didn't mean to imply that the kernel was to blame, merely that a
> kernel change could help make things tidier.)
If you're attempting to fix this in systemd please share the PR info
so we can voice support!
prev parent reply other threads:[~2021-06-14 19:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 15:23 [PATCH] net: usbnet: allow overriding of default USB interface naming Jonathan Davies
2021-06-11 17:16 ` Andrew Lunn
2021-06-14 9:32 ` Jonathan Davies
2021-06-14 12:40 ` Oliver Neukum
2021-06-12 7:01 ` Greg KH
2021-06-14 9:32 ` Jonathan Davies
2021-06-14 9:43 ` Greg KH
2021-06-14 10:58 ` Jonathan Davies
2021-06-14 12:23 ` Andrew Lunn
2021-06-14 14:53 ` Jonathan Davies
2021-06-14 13:51 ` Greg KH
2021-06-14 14:53 ` Jonathan Davies
2021-06-14 19:20 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614122000.7cdef052@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jonathan.davies@nutanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.