From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC8DDC2B9F4 for ; Mon, 14 Jun 2021 12:29:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 976F361208 for ; Mon, 14 Jun 2021 12:29:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233707AbhFNMbb (ORCPT ); Mon, 14 Jun 2021 08:31:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233291AbhFNMba (ORCPT ); Mon, 14 Jun 2021 08:31:30 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AAEAC061574 for ; Mon, 14 Jun 2021 05:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CYuIHF0T+b+/KoeFeu3HuaXS+reF8n/pa4hZBHRoCCA=; b=F9yuvg1E6OCpaYVw4mi8ngCdE /7Sb88u2ZNskCofK+1CLaQQGtoudMewRkYyTEyyETWBLcD46SW22IhY6o2cQGjsdY5cmwMxP+qEvU jhS7KGMSCe1Enrk5nRetb44q9zFk1raxn1DXBET+xI+5SQFnTRU0XV7BVaCJ02KruHsWOM69Jsjt7 vTP5rQTMlQL85si4b3wnZaLvmpuq9igFowPX4uiRXw3ehNA4FIPOj0qyYei1zumZeA5No/yBe9OUj U2spTIZw44oLo6kI0ZbLKYnqGENxSzjYUAd9jNOQq6Q6+AIvLb5GJnuFrS86AyR4MJzD6TzjH2Ebs fec+MpoEw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45000) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lsliT-0004F7-71; Mon, 14 Jun 2021 13:29:21 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lsliR-00046y-Ir; Mon, 14 Jun 2021 13:29:19 +0100 Date: Mon, 14 Jun 2021 13:29:19 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: Jakub Kicinski , "David S. Miller" , netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Heiner Kallweit , Radu Pirea , Vladimir Oltean Subject: Re: [PATCH net-next 3/3] net: phy: nxp-c45-tja11xx: enable MDIO write access to the master/slave registers Message-ID: <20210614122919.GR22278@shell.armlinux.org.uk> References: <20210614121849.437119-1-olteanv@gmail.com> <20210614121849.437119-4-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614121849.437119-4-olteanv@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 14, 2021 at 03:18:49PM +0300, Vladimir Oltean wrote: > diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c > index 118b393b1cbb..b4dc112d4881 100644 > --- a/drivers/net/phy/nxp-c45-tja11xx.c > +++ b/drivers/net/phy/nxp-c45-tja11xx.c > @@ -1035,6 +1035,9 @@ static int nxp_c45_config_init(struct phy_device *phydev) > return ret; > } > > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F8, 1); > + phy_write_mmd(phydev, MDIO_MMD_VEND1, 0x01F9, 2); I think this deserves a comment - especially since the code uses numeric values here. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!