From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6089BC2B9F4 for ; Mon, 14 Jun 2021 14:29:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EE4961209 for ; Mon, 14 Jun 2021 14:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234380AbhFNObK (ORCPT ); Mon, 14 Jun 2021 10:31:10 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:57612 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232984AbhFNObH (ORCPT ); Mon, 14 Jun 2021 10:31:07 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 15EESnwd040412; Mon, 14 Jun 2021 09:28:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623680929; bh=+4NtWY3cuQShN1zQE/NiVLAmhqWotJAF5lyZWU71+cQ=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=BosDe65qpSRNQ8+oFac8/3XawPJ7QQK+tMYxrP0X4+TGO4SI1BOmbXwHHz/ZpVG0a hAwxR5tkLqfvMg7raDq2yv6NCmcdHtkqFI2rU70X8oluoRqxwcIsid+iPuk6Vt6aWm SfYZIsDLW/vw4k3dorWGYUo3tKb8lp8rzAj21RfE= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 15EESn89073580 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Jun 2021 09:28:49 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 14 Jun 2021 09:28:49 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 14 Jun 2021 09:28:49 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 15EESn1T061901; Mon, 14 Jun 2021 09:28:49 -0500 Date: Mon, 14 Jun 2021 09:28:49 -0500 From: Nishanth Menon To: Aswath Govindraju CC: Vignesh Raghavendra , Rob Herring , , , Linux ARM Mailing List Subject: Re: [PATCH] arm64: dts: ti: k3-am64-main: Add SYSFW reserved ranges in OCRAM Message-ID: <20210614142849.ogi4emuqgxg3m7ls@constrict> References: <20210609140604.9490-1-vigneshr@ti.com> <20210611191640.lczsliyzasjie6lm@dismantle> <84e5865f-e107-f0e1-ca8b-b6bd655e92e6@ti.com> <36ff3c65-2f5e-2997-9fb5-a5e8d3230a75@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <36ff3c65-2f5e-2997-9fb5-a5e8d3230a75@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10:18-20210614, Aswath Govindraju wrote: > Hi Vignesh, > > On 12/06/21 12:51 pm, Vignesh Raghavendra wrote: > > +Aswath > > > > On 6/12/21 12:46 AM, Nishanth Menon wrote: > >> On 19:36-20210609, Vignesh Raghavendra wrote: > >>> Last 256K of OCRAM (256K@0x701c0000) is reserved for SYSFW usage. Hence > >>> add an entry in DT so that its not used for generic pool memory > >>> allocation. > >> > >> Are you really sure?? I know that I had set a budget for 16K in sysfw > >> when I did the memory split up for sysfw of which 16k is actually used. > >> > >> Not sure where this 256K bucket started off from.. am I missing > >> something here? > >> > > > > Per: http://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am64x/firewalls.html > > > > 24 dmsc 0x44060000 0x4407BFFF dmsc,rwcd // alias for 0x701E0000 > > 24 dmsc 0x701FC000 0x701FFFFF sproxy_private,rwcd > > 24 dmsc 0x4407C000 0x4407FFFF sproxy_private,rwcd > > 24 dmsc 0x701C0000 0x701DFFFF everyone,rwcd > > > > So it looks like only 128K@0x701E0000 is firewalled off. > > Will update the patch. > > > > This makes me wonder why ATF is being moved to 0x701a0000-0x701c0000 > > leaving a hole at 0x701C0000-0x701DFFFF? > > > > > > The reason for leaving the hole at 0x701C0000-0x701DFFFF was because > initially there was a bug in SYSFW which lead to the usage of the above > region too by it. However, this bug was recently fixed and the the above > region can be used for ATF. OK. I am going to drop the TF-A update patch from my queue. NOTE: a) Default device configuration (if no specific API call[1]) is done assumes last 128K is reserved. b) if bootloader does invoke optionally a call[1] then only 16K is reserved for communication and remainder of 128K is released for usage with the constraint that TF-A/OPTEE takes control of security resources. c) This is only a feature in AM64x devices so, handling is device specific. Hence, on AM64x: (a) should be our default configuration and (b) can be board specific configuration OR overlay depending on bootloader capability. [1] http://downloads.ti.com/tisci/esd/latest/6_topic_user_guides/security_handover.html#triggering-security-handover -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A7C8C2B9F4 for ; Mon, 14 Jun 2021 14:30:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA6AB61209 for ; Mon, 14 Jun 2021 14:30:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA6AB61209 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FPKMiqox1hMi0iHsUqqtRyjSPv43rp80PPUcsPyBszY=; b=0hRtnBjvlbpbvy bQs9yCifQGF5U52dn9VicFhvltdw1GUiaG4kknTajZHS6bsrC5o90lzL/7uCw7X51tw6cQcxNX3dN 7aVrA1y1lc56S5nnc9FW8aZ6aVqugWeoHTfNmNw+tbrHgwwoPzEltPqbgCDfHehux2ls6YLXb/6gg 6dNmmPIfRHWDiWzGHoM/0sOldKZ5SuqJ2cMPt6dZgt6WAg4AApC0Gjwt2XRgBz0nA++lko1P62YNR GXFrw9Qh2crnPhURfU+9Vmvznaw1jODyxQOONl50kdf9t+kljU+VMyjYI2kzcPCqvCTm8Zb+79BtC cmK4/PWJ9uJFv4hAFXOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsnaN-00EVvb-LT; Mon, 14 Jun 2021 14:29:07 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsnaH-00EVr7-Su for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 14:29:04 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 15EESnwd040412; Mon, 14 Jun 2021 09:28:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623680929; bh=+4NtWY3cuQShN1zQE/NiVLAmhqWotJAF5lyZWU71+cQ=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=BosDe65qpSRNQ8+oFac8/3XawPJ7QQK+tMYxrP0X4+TGO4SI1BOmbXwHHz/ZpVG0a hAwxR5tkLqfvMg7raDq2yv6NCmcdHtkqFI2rU70X8oluoRqxwcIsid+iPuk6Vt6aWm SfYZIsDLW/vw4k3dorWGYUo3tKb8lp8rzAj21RfE= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 15EESn89073580 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Jun 2021 09:28:49 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 14 Jun 2021 09:28:49 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 14 Jun 2021 09:28:49 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 15EESn1T061901; Mon, 14 Jun 2021 09:28:49 -0500 Date: Mon, 14 Jun 2021 09:28:49 -0500 From: Nishanth Menon To: Aswath Govindraju CC: Vignesh Raghavendra , Rob Herring , , , Linux ARM Mailing List Subject: Re: [PATCH] arm64: dts: ti: k3-am64-main: Add SYSFW reserved ranges in OCRAM Message-ID: <20210614142849.ogi4emuqgxg3m7ls@constrict> References: <20210609140604.9490-1-vigneshr@ti.com> <20210611191640.lczsliyzasjie6lm@dismantle> <84e5865f-e107-f0e1-ca8b-b6bd655e92e6@ti.com> <36ff3c65-2f5e-2997-9fb5-a5e8d3230a75@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <36ff3c65-2f5e-2997-9fb5-a5e8d3230a75@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_072902_135954_8E05F864 X-CRM114-Status: GOOD ( 23.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10:18-20210614, Aswath Govindraju wrote: > Hi Vignesh, > > On 12/06/21 12:51 pm, Vignesh Raghavendra wrote: > > +Aswath > > > > On 6/12/21 12:46 AM, Nishanth Menon wrote: > >> On 19:36-20210609, Vignesh Raghavendra wrote: > >>> Last 256K of OCRAM (256K@0x701c0000) is reserved for SYSFW usage. Hence > >>> add an entry in DT so that its not used for generic pool memory > >>> allocation. > >> > >> Are you really sure?? I know that I had set a budget for 16K in sysfw > >> when I did the memory split up for sysfw of which 16k is actually used. > >> > >> Not sure where this 256K bucket started off from.. am I missing > >> something here? > >> > > > > Per: http://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am64x/firewalls.html > > > > 24 dmsc 0x44060000 0x4407BFFF dmsc,rwcd // alias for 0x701E0000 > > 24 dmsc 0x701FC000 0x701FFFFF sproxy_private,rwcd > > 24 dmsc 0x4407C000 0x4407FFFF sproxy_private,rwcd > > 24 dmsc 0x701C0000 0x701DFFFF everyone,rwcd > > > > So it looks like only 128K@0x701E0000 is firewalled off. > > Will update the patch. > > > > This makes me wonder why ATF is being moved to 0x701a0000-0x701c0000 > > leaving a hole at 0x701C0000-0x701DFFFF? > > > > > > The reason for leaving the hole at 0x701C0000-0x701DFFFF was because > initially there was a bug in SYSFW which lead to the usage of the above > region too by it. However, this bug was recently fixed and the the above > region can be used for ATF. OK. I am going to drop the TF-A update patch from my queue. NOTE: a) Default device configuration (if no specific API call[1]) is done assumes last 128K is reserved. b) if bootloader does invoke optionally a call[1] then only 16K is reserved for communication and remainder of 128K is released for usage with the constraint that TF-A/OPTEE takes control of security resources. c) This is only a feature in AM64x devices so, handling is device specific. Hence, on AM64x: (a) should be our default configuration and (b) can be board specific configuration OR overlay depending on bootloader capability. [1] http://downloads.ti.com/tisci/esd/latest/6_topic_user_guides/security_handover.html#triggering-security-handover -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel