From: Christoph Hellwig <hch@lst.de> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jason Gunthorpe <jgg@nvidia.com>, Alex Williamson <alex.williamson@redhat.com>, Kirti Wankhede <kwankhede@nvidia.com> Cc: David Airlie <airlied@linux.ie>, Tony Krowiak <akrowiak@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Cornelia Huck <cohuck@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org, Vasily Gorbik <gor@linux.ibm.com>, Heiko Carstens <hca@linux.ibm.com>, intel-gfx@lists.freedesktop.org, Jani Nikula <jani.nikula@linux.intel.com>, Jason Herne <jjherne@linux.ibm.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-s390@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Rodrigo Vivi <rodrigo.vivi@intel.com> Subject: [PATCH 05/10] driver core: Export device_driver_attach() Date: Mon, 14 Jun 2021 17:08:41 +0200 [thread overview] Message-ID: <20210614150846.4111871-6-hch@lst.de> (raw) In-Reply-To: <20210614150846.4111871-1-hch@lst.de> From: Jason Gunthorpe <jgg@nvidia.com> This is intended as a replacement API for device_bind_driver(). It has at least the following benefits: - Internal locking. Few of the users of device_bind_driver() follow the locking rules - Calls device driver probe() internally. Notably this means that devm support for probe works correctly as probe() error will call devres_release_all() - struct device_driver -> dev_groups is supported - Simplified calling convention, no need to manually call probe(). The general usage is for situations that already know what driver to bind and need to ensure the bind is synchronized with other logic. Call device_driver_attach() after device_add(). If probe() returns a failure then this will be preserved up through to the error return of device_driver_attach(). Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/base/base.h | 1 - drivers/base/dd.c | 3 +++ include/linux/device.h | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/base/base.h b/drivers/base/base.h index e5f9b7e656c3..404db83ee5ec 100644 --- a/drivers/base/base.h +++ b/drivers/base/base.h @@ -152,7 +152,6 @@ extern int driver_add_groups(struct device_driver *drv, const struct attribute_group **groups); extern void driver_remove_groups(struct device_driver *drv, const struct attribute_group **groups); -int device_driver_attach(struct device_driver *drv, struct device *dev); void device_driver_detach(struct device *dev); extern char *make_class_name(const char *name, struct kobject *kobj); diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 8c65673e344c..aab47c0b356f 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -471,6 +471,8 @@ static void driver_sysfs_remove(struct device *dev) * (It is ok to call with no other effort from a driver's probe() method.) * * This function must be called with the device lock held. + * + * Callers should prefer to use device_driver_attach() instead. */ int device_bind_driver(struct device *dev) { @@ -1063,6 +1065,7 @@ int device_driver_attach(struct device_driver *drv, struct device *dev) return -EAGAIN; return ret; } +EXPORT_SYMBOL_GPL(device_driver_attach); static void __driver_attach_async_helper(void *_dev, async_cookie_t cookie) { diff --git a/include/linux/device.h b/include/linux/device.h index f1a00040fa53..d8b9c9e7d493 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -845,6 +845,8 @@ static inline void *dev_get_platdata(const struct device *dev) * Manual binding of a device to driver. See drivers/base/bus.c * for information on use. */ +int __must_check device_driver_attach(struct device_driver *drv, + struct device *dev); int __must_check device_bind_driver(struct device *dev); void device_release_driver(struct device *dev); int __must_check device_attach(struct device *dev); -- 2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jason Gunthorpe <jgg@nvidia.com>, Alex Williamson <alex.williamson@redhat.com>, Kirti Wankhede <kwankhede@nvidia.com> Cc: Tony Krowiak <akrowiak@linux.ibm.com>, Jason Herne <jjherne@linux.ibm.com>, kvm@vger.kernel.org, Vasily Gorbik <gor@linux.ibm.com>, Jonathan Corbet <corbet@lwn.net>, David Airlie <airlied@linux.ie>, linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, "Rafael J. Wysocki" <rafael@kernel.org>, intel-gfx@lists.freedesktop.org Subject: [Intel-gfx] [PATCH 05/10] driver core: Export device_driver_attach() Date: Mon, 14 Jun 2021 17:08:41 +0200 [thread overview] Message-ID: <20210614150846.4111871-6-hch@lst.de> (raw) In-Reply-To: <20210614150846.4111871-1-hch@lst.de> From: Jason Gunthorpe <jgg@nvidia.com> This is intended as a replacement API for device_bind_driver(). It has at least the following benefits: - Internal locking. Few of the users of device_bind_driver() follow the locking rules - Calls device driver probe() internally. Notably this means that devm support for probe works correctly as probe() error will call devres_release_all() - struct device_driver -> dev_groups is supported - Simplified calling convention, no need to manually call probe(). The general usage is for situations that already know what driver to bind and need to ensure the bind is synchronized with other logic. Call device_driver_attach() after device_add(). If probe() returns a failure then this will be preserved up through to the error return of device_driver_attach(). Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/base/base.h | 1 - drivers/base/dd.c | 3 +++ include/linux/device.h | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/base/base.h b/drivers/base/base.h index e5f9b7e656c3..404db83ee5ec 100644 --- a/drivers/base/base.h +++ b/drivers/base/base.h @@ -152,7 +152,6 @@ extern int driver_add_groups(struct device_driver *drv, const struct attribute_group **groups); extern void driver_remove_groups(struct device_driver *drv, const struct attribute_group **groups); -int device_driver_attach(struct device_driver *drv, struct device *dev); void device_driver_detach(struct device *dev); extern char *make_class_name(const char *name, struct kobject *kobj); diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 8c65673e344c..aab47c0b356f 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -471,6 +471,8 @@ static void driver_sysfs_remove(struct device *dev) * (It is ok to call with no other effort from a driver's probe() method.) * * This function must be called with the device lock held. + * + * Callers should prefer to use device_driver_attach() instead. */ int device_bind_driver(struct device *dev) { @@ -1063,6 +1065,7 @@ int device_driver_attach(struct device_driver *drv, struct device *dev) return -EAGAIN; return ret; } +EXPORT_SYMBOL_GPL(device_driver_attach); static void __driver_attach_async_helper(void *_dev, async_cookie_t cookie) { diff --git a/include/linux/device.h b/include/linux/device.h index f1a00040fa53..d8b9c9e7d493 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -845,6 +845,8 @@ static inline void *dev_get_platdata(const struct device *dev) * Manual binding of a device to driver. See drivers/base/bus.c * for information on use. */ +int __must_check device_driver_attach(struct device_driver *drv, + struct device *dev); int __must_check device_bind_driver(struct device *dev); void device_release_driver(struct device *dev); int __must_check device_attach(struct device *dev); -- 2.30.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-14 15:09 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-14 15:08 Allow mdev drivers to directly create the vfio_device (v2 / alternative) Christoph Hellwig 2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig 2021-06-14 15:08 ` [PATCH 01/10] driver core: Pull required checks into driver_probe_device() Christoph Hellwig 2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig 2021-06-15 5:16 ` Greg Kroah-Hartman 2021-06-15 5:16 ` [Intel-gfx] " Greg Kroah-Hartman 2021-06-15 5:16 ` Greg Kroah-Hartman 2021-06-15 10:27 ` Cornelia Huck 2021-06-15 10:27 ` [Intel-gfx] " Cornelia Huck 2021-06-15 10:27 ` Cornelia Huck 2021-06-14 15:08 ` [PATCH 02/10] driver core: Better distinguish probe errors in really_probe Christoph Hellwig 2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig 2021-06-14 18:47 ` Kirti Wankhede 2021-06-14 18:47 ` [Intel-gfx] " Kirti Wankhede 2021-06-14 18:47 ` Kirti Wankhede 2021-06-15 5:17 ` Greg Kroah-Hartman 2021-06-15 5:17 ` [Intel-gfx] " Greg Kroah-Hartman 2021-06-15 5:17 ` Greg Kroah-Hartman 2021-06-15 5:48 ` Christoph Hellwig 2021-06-15 5:48 ` [Intel-gfx] " Christoph Hellwig 2021-06-14 15:08 ` [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind Christoph Hellwig 2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig 2021-06-15 5:18 ` Greg Kroah-Hartman 2021-06-15 5:18 ` [Intel-gfx] " Greg Kroah-Hartman 2021-06-15 5:18 ` Greg Kroah-Hartman 2021-06-15 10:31 ` Cornelia Huck 2021-06-15 10:31 ` [Intel-gfx] " Cornelia Huck 2021-06-15 10:31 ` Cornelia Huck 2021-06-14 15:08 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during " Christoph Hellwig 2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig 2021-06-14 22:43 ` Jason Gunthorpe 2021-06-14 22:43 ` [Intel-gfx] " Jason Gunthorpe 2021-06-14 22:43 ` Jason Gunthorpe 2021-06-14 15:08 ` Christoph Hellwig [this message] 2021-06-14 15:08 ` [Intel-gfx] [PATCH 05/10] driver core: Export device_driver_attach() Christoph Hellwig 2021-06-15 5:20 ` Greg Kroah-Hartman 2021-06-15 5:20 ` [Intel-gfx] " Greg Kroah-Hartman 2021-06-15 5:20 ` Greg Kroah-Hartman 2021-06-15 10:49 ` Cornelia Huck 2021-06-15 10:49 ` [Intel-gfx] " Cornelia Huck 2021-06-15 10:49 ` Cornelia Huck 2021-06-14 15:08 ` [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE Christoph Hellwig 2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig 2021-06-15 10:50 ` Cornelia Huck 2021-06-15 10:50 ` [Intel-gfx] " Cornelia Huck 2021-06-15 10:50 ` Cornelia Huck 2021-06-14 15:08 ` [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind Christoph Hellwig 2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig 2021-06-15 10:54 ` Cornelia Huck 2021-06-15 10:54 ` [Intel-gfx] " Cornelia Huck 2021-06-15 10:54 ` Cornelia Huck 2021-06-14 15:08 ` [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev() Christoph Hellwig 2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig 2021-06-14 15:08 ` [PATCH 09/10] vfio/mdpy: " Christoph Hellwig 2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig 2021-06-14 15:08 ` [PATCH 10/10] vfio/mbochs: " Christoph Hellwig 2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig 2021-06-15 0:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] driver core: Pull required checks into driver_probe_device() Patchwork 2021-06-15 0:23 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2021-06-15 0:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-06-15 5:21 ` Allow mdev drivers to directly create the vfio_device (v2 / alternative) Greg Kroah-Hartman 2021-06-15 5:21 ` [Intel-gfx] " Greg Kroah-Hartman 2021-06-15 5:21 ` Greg Kroah-Hartman 2021-06-15 5:50 ` Christoph Hellwig 2021-06-15 5:50 ` [Intel-gfx] " Christoph Hellwig 2021-06-15 15:27 ` Jason Gunthorpe 2021-06-15 15:27 ` [Intel-gfx] " Jason Gunthorpe 2021-06-15 15:27 ` Jason Gunthorpe 2021-06-15 9:37 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/10] driver core: Pull required checks into driver_probe_device() Patchwork -- strict thread matches above, loose matches on Subject: below -- 2021-06-17 14:22 Allow mdev drivers to directly create the vfio_device (v4) Christoph Hellwig 2021-06-17 14:22 ` [PATCH 05/10] driver core: Export device_driver_attach() Christoph Hellwig 2021-06-15 13:35 Allow mdev drivers to directly create the vfio_device (v3) Christoph Hellwig 2021-06-15 13:35 ` [PATCH 05/10] driver core: Export device_driver_attach() Christoph Hellwig 2021-06-15 14:10 ` Greg Kroah-Hartman 2021-06-15 14:10 ` Greg Kroah-Hartman 2021-06-08 0:55 [PATCH 00/10] Allow mdev drivers to directly create the vfio_device Jason Gunthorpe 2021-06-08 0:55 ` [PATCH 05/10] driver core: Export device_driver_attach() Jason Gunthorpe 2021-06-08 6:19 ` Christoph Hellwig 2021-06-08 12:33 ` Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210614150846.4111871-6-hch@lst.de \ --to=hch@lst.de \ --cc=airlied@linux.ie \ --cc=akrowiak@linux.ibm.com \ --cc=alex.williamson@redhat.com \ --cc=borntraeger@de.ibm.com \ --cc=cohuck@redhat.com \ --cc=corbet@lwn.net \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=gor@linux.ibm.com \ --cc=gregkh@linuxfoundation.org \ --cc=hca@linux.ibm.com \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=jgg@nvidia.com \ --cc=jjherne@linux.ibm.com \ --cc=joonas.lahtinen@linux.intel.com \ --cc=kvm@vger.kernel.org \ --cc=kwankhede@nvidia.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=pasic@linux.ibm.com \ --cc=rafael@kernel.org \ --cc=rodrigo.vivi@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.