[tip:tmp.tmp2 100/364] kernel/torture.c:741:5: error: implicit declaration of function 'cond_resched'; did you mean 'need_resched'?

* [tip:tmp.tmp2 100/364] kernel/torture.c:741:5: error: implicit declaration of function 'cond_resched'; did you mean 'need_resched'?
@ 2021-06-14  7:45 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-06-14  7:45 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: kbuild-all, linux-kernel, x86

[-- Attachment #1: Type: text/plain, Size: 4414 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.tmp2
head:   adcceb5eb7aee38e4a9c15bdf599655f0e1b1324
commit: 54617112331a4cc28268a4321eab5b38baba4d9f [100/364] sched/headers: Remove <linux/sched/cond_resched.h> inclusion from <linux/sched.h>
config: x86_64-rhel-8.3 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=54617112331a4cc28268a4321eab5b38baba4d9f
        git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
        git fetch --no-tags tip tmp.tmp2
        git checkout 54617112331a4cc28268a4321eab5b38baba4d9f
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/torture.c: In function 'stutter_wait':
>> kernel/torture.c:728:2: error: implicit declaration of function 'cond_resched_tasks_rcu_qs' [-Werror=implicit-function-declaration]
     728 |  cond_resched_tasks_rcu_qs();
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~
>> kernel/torture.c:741:5: error: implicit declaration of function 'cond_resched'; did you mean 'need_resched'? [-Werror=implicit-function-declaration]
     741 |     cond_resched();
         |     ^~~~~~~~~~~~
         |     need_resched
   cc1: some warnings being treated as errors

vim +741 kernel/torture.c

628edaa5062282 Paul E. McKenney 2014-01-31  717  
628edaa5062282 Paul E. McKenney 2014-01-31  718  /*
628edaa5062282 Paul E. McKenney 2014-01-31  719   * Block until the stutter interval ends.  This must be called periodically
628edaa5062282 Paul E. McKenney 2014-01-31  720   * by all running kthreads that need to be subject to stuttering.
628edaa5062282 Paul E. McKenney 2014-01-31  721   */
474e59b476b339 Paul E. McKenney 2018-08-07  722  bool stutter_wait(const char *title)
628edaa5062282 Paul E. McKenney 2014-01-31  723  {
19012b786ecccb Paul E. McKenney 2020-09-01  724  	unsigned int i = 0;
e8516c64fe97e2 Paul E. McKenney 2019-04-09  725  	bool ret = false;
19012b786ecccb Paul E. McKenney 2020-09-01  726  	int spt;
4ced3314fd3a73 Paul E. McKenney 2017-11-21  727  
cee43939893337 Paul E. McKenney 2018-03-02 @728  	cond_resched_tasks_rcu_qs();
4ced3314fd3a73 Paul E. McKenney 2017-11-21  729  	spt = READ_ONCE(stutter_pause_test);
29d3939084583b Paul E. McKenney 2017-11-21  730  	for (; spt; spt = READ_ONCE(stutter_pause_test)) {
ab1b7880dec86b Paul E. McKenney 2020-09-22  731  		if (!ret) {
ab1b7880dec86b Paul E. McKenney 2020-09-22  732  			sched_set_normal(current, MAX_NICE);
e8516c64fe97e2 Paul E. McKenney 2019-04-09  733  			ret = true;
ab1b7880dec86b Paul E. McKenney 2020-09-22  734  		}
4ced3314fd3a73 Paul E. McKenney 2017-11-21  735  		if (spt == 1) {
628edaa5062282 Paul E. McKenney 2014-01-31  736  			schedule_timeout_interruptible(1);
4ced3314fd3a73 Paul E. McKenney 2017-11-21  737  		} else if (spt == 2) {
19012b786ecccb Paul E. McKenney 2020-09-01  738  			while (READ_ONCE(stutter_pause_test)) {
ed24affa71f7ab Paul E. McKenney 2020-11-17  739  				if (!(i++ & 0xffff))
ed24affa71f7ab Paul E. McKenney 2020-11-17  740  					torture_hrtimeout_us(10, 0, NULL);
ab7d45053f99f4 Paul E. McKenney 2014-03-04 @741  				cond_resched();
19012b786ecccb Paul E. McKenney 2020-09-01  742  			}
4ced3314fd3a73 Paul E. McKenney 2017-11-21  743  		} else {
628edaa5062282 Paul E. McKenney 2014-01-31  744  			schedule_timeout_interruptible(round_jiffies_relative(HZ));
4ced3314fd3a73 Paul E. McKenney 2017-11-21  745  		}
628edaa5062282 Paul E. McKenney 2014-01-31  746  		torture_shutdown_absorb(title);
628edaa5062282 Paul E. McKenney 2014-01-31  747  	}
e8516c64fe97e2 Paul E. McKenney 2019-04-09  748  	return ret;
628edaa5062282 Paul E. McKenney 2014-01-31  749  }
628edaa5062282 Paul E. McKenney 2014-01-31  750  EXPORT_SYMBOL_GPL(stutter_wait);
628edaa5062282 Paul E. McKenney 2014-01-31  751  

:::::: The code at line 741 was first introduced by commit
:::::: ab7d45053f99f44f81a221eb5c9fbe253ee94524 torture: Increase stutter-end intensity

:::::: TO: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
:::::: CC: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41434 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread