All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Palethorpe <rpalethorpe@suse.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] icmp_rate_limit01: Require CONFIG_VETH
Date: Tue, 15 Jun 2021 08:51:04 +0100	[thread overview]
Message-ID: <20210615075104.24870-1-rpalethorpe@suse.com> (raw)

The test fails with TBROK if it can not create a virtual ethernet
pair. So add it to the kconfigs.

Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
---

Just thinking about the config meta data and embedded users. Functions
like tst_create_veth_pair could check needs_kconfigs for the required
config and TBROK if it is not there.

Alternatively (or in addition to) static analyses can be used to check
(or add) missing config.

In either case this may be wrong when a function is only used in a
branch. OTOH then the test needs splitting otherwise the metadata
can't be known ahead of execution.

 testcases/cve/icmp_rate_limit01.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/cve/icmp_rate_limit01.c b/testcases/cve/icmp_rate_limit01.c
index 0c2ac44df..f24ea5bf9 100644
--- a/testcases/cve/icmp_rate_limit01.c
+++ b/testcases/cve/icmp_rate_limit01.c
@@ -260,6 +260,7 @@ static struct tst_test test = {
 	.setup = setup,
 	.cleanup = cleanup,
 	.needs_kconfigs = (const char *[]) {
+		"CONFIG_VETH",
 		"CONFIG_USER_NS=y",
 		"CONFIG_NET_NS=y",
 		NULL
-- 
2.31.1


             reply	other threads:[~2021-06-15  7:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15  7:51 Richard Palethorpe [this message]
2021-06-15  8:06 ` [LTP] [PATCH] icmp_rate_limit01: Require CONFIG_VETH Petr Vorel
2021-06-15 11:32 ` Martin Doucha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210615075104.24870-1-rpalethorpe@suse.com \
    --to=rpalethorpe@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.