Re: [PATCH] lscpu: get the processor information by DMI

From: Karel Zak <kzak@redhat.com>
To: Huang Shijie <shijie@os.amperecomputing.com>
Cc: util-linux@vger.kernel.org, patches@amperecomputing.com,
	zwang@amperecomputing.com, mas@amperecomputing.com,
	ilkka@os.amperecomputing.com,
	Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>,
	jbastian@redhat.com
Subject: Re: [PATCH] lscpu: get the processor information by DMI
Date: Tue, 15 Jun 2021 11:13:14 +0200	[thread overview]
Message-ID: <20210615091314.3hrkztuvnqyff3ll@ws.net.home> (raw)
In-Reply-To: <20210615084821.s2mcvmpaetb7fbjq@ws.net.home>

On Tue, Jun 15, 2021 at 10:48:25AM +0200, Karel Zak wrote:
> On Tue, Jun 15, 2021 at 09:20:55AM +0000, Huang Shijie wrote:
> > > > +	/* Get CPU family */
> > > > +	memset(buf, 0, sizeof(buf));
> > > > +	sprintf(buf, "%d", di.processor_family);
> > > > +	free(ct->family);
> > > > +	ct->family = xstrdup(buf);
> > > 
> > > is there any difference between "cpu family" from /proc/cpuinfo and
> > > this DMI field? Do we need a new field ct->bios_family or overwrite 
> > > the ct->family good enough? I don't know ;-)
> > > 
> > In the arm platform, it seems it does not show the "cpu family" info in lscpu.
> > And I did not find the "cpu family" in the /proc/cpuinfo, only find "cpu architecture: 8".
> > Unfortunately, the "cpu architecture :8 " is hardcode, it will be changed for armv9 in future.
> > 
> > In the DMI, the "cpu family" shows 0x101 which means "arm v8".
> 
> So, re-use ct->family for now. We can change it later.

Ah, I see you already send patch with "BIOS CPU Family". OK, let's use
it and ignore my previous email ;-)

  Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com