From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15F0CC48BDF for ; Tue, 15 Jun 2021 11:55:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EB5056145C for ; Tue, 15 Jun 2021 11:55:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbhFOL5E (ORCPT ); Tue, 15 Jun 2021 07:57:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:34194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230161AbhFOL5B (ORCPT ); Tue, 15 Jun 2021 07:57:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 863D660FF0; Tue, 15 Jun 2021 11:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623758097; bh=Ryg5gVD62jasf3/gyRRVCZbE2fmZc8ABQmAVPplc3YA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e2rvcPjFxkpDpzhUpoLfrAMqWsulNem2IX3ZJDmuUWk5+Cxf8x4Rl87KomsEp9RK+ +W3y7leleoManvGA37ngEuDjurweGrouI3y7HpPq34Ct2kjbQPYJI0Vd5d53LWTa0T Wr/bQB0ffYDxBGH2bqtsy3BeUHMAMsTUNAObO8JvnfrK/JmJVVx5uHNMEK5SyPGsJr 8mj1L5oTHhTuF7wOggMK2Iw6fpVqDwGLTzLSWNTyN89zP/GjMDXEBshNza6BS+l5Yn awpcsJtM97d0lezlo9+QEFDCR8x/1Butyy7fQsZqR0300FKqbhR4Bw0GuGxtSXDm8p RU/FLDkjswD2Q== Date: Tue, 15 Jun 2021 12:54:38 +0100 From: Mark Brown To: Claudius Heine Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Marek Vasut , Kuninori Morimoto , Sia Jee Heng , Pierre-Louis Bossart , Michael Sit Wei Hong , Miquel Raynal , Annaliese McDermond , Matthias Schiffer , open list Subject: Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants Message-ID: <20210615115438.GD5149@sirena.org.uk> References: <20210615094933.3076392-1-ch@denx.de> <20210615094933.3076392-2-ch@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MAH+hnPXVZWQ5cD/" Content-Disposition: inline In-Reply-To: <20210615094933.3076392-2-ch@denx.de> X-Cookie: See store for details. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --MAH+hnPXVZWQ5cD/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote: > With this change it will be possible to add different code paths for > similar devices. > static const struct i2c_device_id aic32x4_i2c_id[] = { > - { "tlv320aic32x4", 0 }, > - { "tlv320aic32x6", 1 }, > + { "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 }, > + { "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 }, > { /* sentinel */ } It appears that the device already supports multiple variants? --MAH+hnPXVZWQ5cD/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDIlP0ACgkQJNaLcl1U h9CYOwf/SlCmc7TAjtDwrSiQvdXEdliXBwxX5qNaJe+XWlWNKdt6nxq00rCJ4kH5 YOfjOL/FvF9oCEnUqdQSBOKiiLTPxtUVZPbUCZsaLC9h6euOxLVvmsMWRGvGBYeb O7Mfcuvik8fX4TtQPrlN+VkSKuHNprrMeyBlVV8t5r84ED39c63uWDa56WvY5J6S P/ZRzT1ZVVpJC0418lE+y+dnnzegalwiZTn2u4mFxyN+CrD7OC2GfDFROFO9IAcT 0PfaHIHrj5k+JdNqQUVGKeAgp77W7Tb9fdepVkGxYK4lw8RTlgFqjpSPpPVu2WId PPiI4st8jlpxYJOb9fg8ReQfQ9MMyQ== =F81b -----END PGP SIGNATURE----- --MAH+hnPXVZWQ5cD/-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0529C48BE8 for ; Tue, 15 Jun 2021 11:55:59 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CAC56145B for ; Tue, 15 Jun 2021 11:55:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CAC56145B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8EBDF1677; Tue, 15 Jun 2021 13:55:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8EBDF1677 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623758155; bh=Ryg5gVD62jasf3/gyRRVCZbE2fmZc8ABQmAVPplc3YA=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fzXsqqCpWxCPuvIU9RAyZFcV6YP47jjFV61KrfEAf1tjGYq7bp412bodE0Tbzq4/1 HOp2xhPsMw5j8phMtMvVU/ws8SZF6cvMOBkd8rAEHnjUvTN5/cZojfL4JQL7u8rNtJ 6fqObqQNBPMCvBZcmAV8o6yNFtTIWQa1MroqOvKA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1CED2F80113; Tue, 15 Jun 2021 13:55:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id ACFFBF80171; Tue, 15 Jun 2021 13:55:03 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 80E16F80113 for ; Tue, 15 Jun 2021 13:55:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 80E16F80113 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e2rvcPjF" Received: by mail.kernel.org (Postfix) with ESMTPSA id 863D660FF0; Tue, 15 Jun 2021 11:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623758097; bh=Ryg5gVD62jasf3/gyRRVCZbE2fmZc8ABQmAVPplc3YA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e2rvcPjFxkpDpzhUpoLfrAMqWsulNem2IX3ZJDmuUWk5+Cxf8x4Rl87KomsEp9RK+ +W3y7leleoManvGA37ngEuDjurweGrouI3y7HpPq34Ct2kjbQPYJI0Vd5d53LWTa0T Wr/bQB0ffYDxBGH2bqtsy3BeUHMAMsTUNAObO8JvnfrK/JmJVVx5uHNMEK5SyPGsJr 8mj1L5oTHhTuF7wOggMK2Iw6fpVqDwGLTzLSWNTyN89zP/GjMDXEBshNza6BS+l5Yn awpcsJtM97d0lezlo9+QEFDCR8x/1Butyy7fQsZqR0300FKqbhR4Bw0GuGxtSXDm8p RU/FLDkjswD2Q== Date: Tue, 15 Jun 2021 12:54:38 +0100 From: Mark Brown To: Claudius Heine Subject: Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants Message-ID: <20210615115438.GD5149@sirena.org.uk> References: <20210615094933.3076392-1-ch@denx.de> <20210615094933.3076392-2-ch@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MAH+hnPXVZWQ5cD/" Content-Disposition: inline In-Reply-To: <20210615094933.3076392-2-ch@denx.de> X-Cookie: See store for details. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Marek Vasut , Pierre-Louis Bossart , alsa-devel@alsa-project.org, Matthias Schiffer , Kuninori Morimoto , open list , Takashi Iwai , Sia Jee Heng , Liam Girdwood , Annaliese McDermond , Miquel Raynal , Michael Sit Wei Hong X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --MAH+hnPXVZWQ5cD/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote: > With this change it will be possible to add different code paths for > similar devices. > static const struct i2c_device_id aic32x4_i2c_id[] = { > - { "tlv320aic32x4", 0 }, > - { "tlv320aic32x6", 1 }, > + { "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 }, > + { "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 }, > { /* sentinel */ } It appears that the device already supports multiple variants? --MAH+hnPXVZWQ5cD/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDIlP0ACgkQJNaLcl1U h9CYOwf/SlCmc7TAjtDwrSiQvdXEdliXBwxX5qNaJe+XWlWNKdt6nxq00rCJ4kH5 YOfjOL/FvF9oCEnUqdQSBOKiiLTPxtUVZPbUCZsaLC9h6euOxLVvmsMWRGvGBYeb O7Mfcuvik8fX4TtQPrlN+VkSKuHNprrMeyBlVV8t5r84ED39c63uWDa56WvY5J6S P/ZRzT1ZVVpJC0418lE+y+dnnzegalwiZTn2u4mFxyN+CrD7OC2GfDFROFO9IAcT 0PfaHIHrj5k+JdNqQUVGKeAgp77W7Tb9fdepVkGxYK4lw8RTlgFqjpSPpPVu2WId PPiI4st8jlpxYJOb9fg8ReQfQ9MMyQ== =F81b -----END PGP SIGNATURE----- --MAH+hnPXVZWQ5cD/--