From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC78FC48BDF for ; Tue, 15 Jun 2021 12:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C22C61458 for ; Tue, 15 Jun 2021 12:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230211AbhFOMce (ORCPT ); Tue, 15 Jun 2021 08:32:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:45970 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbhFOMcd (ORCPT ); Tue, 15 Jun 2021 08:32:33 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A92A061420; Tue, 15 Jun 2021 12:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623760229; bh=Lb24lKt6MXXaaV3uULc+nVP704h2xY9cjKIbyq5ydTU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GtyeMzNjz9CHBPSCN2x9G3vn4txUnkQNsgXngp3iCbAOwwUcflMpOYcoRSsKpPkLL yX7/nwlWOT1M1FhN4SqHvYug2wAiciiNLjRU4Ts1NbrpSmiGfpCU9mcihq6p2SNkW6 5OVbvRhNoGJSRDvCxEeTzeRd/UfkTnQyaZx1ibrXXCdfrwMrgFW2r4f1vVKBe5NuzB d+Y4uXzvZQfnL1QTOQsBy3/w4uJWKV/urP2IXs+E8A1kphGhhWu9f06Quv9TBEd4Td rtvd1YzZCygTFZiHbxbrzZ48i6ojA2In932FqDbH0dqzbLgzzLvN/FT87F441v36GD CMeb4CQTGIhjQ== Date: Tue, 15 Jun 2021 13:30:08 +0100 From: Mark Brown To: Claudius Heine Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, Marek Vasut , Kuninori Morimoto , Sia Jee Heng , Pierre-Louis Bossart , Michael Sit Wei Hong , Miquel Raynal , Annaliese McDermond , Matthias Schiffer , open list Subject: Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants Message-ID: <20210615123008.GF5149@sirena.org.uk> References: <20210615094933.3076392-1-ch@denx.de> <20210615094933.3076392-2-ch@denx.de> <20210615115438.GD5149@sirena.org.uk> <32b82dae-45ea-c6d4-77b7-c8a234cbf803@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+jhVVhN62yS6hEJ8" Content-Disposition: inline In-Reply-To: <32b82dae-45ea-c6d4-77b7-c8a234cbf803@denx.de> X-Cookie: See store for details. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+jhVVhN62yS6hEJ8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 15, 2021 at 02:06:30PM +0200, Claudius Heine wrote: > On 2021-06-15 13:54, Mark Brown wrote: > > On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote: > > > With this change it will be possible to add different code paths for > > > similar devices. > > > - { "tlv320aic32x4", 0 }, > > > - { "tlv320aic32x6", 1 }, > > > + { "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 }, > > > + { "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 }, > > > { /* sentinel */ } > > It appears that the device already supports multiple variants? > Those values aren't used anywhere as far as I can see. The point here is that you need a better changelog, the driver clearly already supports multiple devices so we need a few more words to explain what this is doing. --+jhVVhN62yS6hEJ8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDInVAACgkQJNaLcl1U h9Dp4gf/ZQ2xpw5GNRXy86pCeJSO0K6PI3Zc3o8poYFgEjZfhzK7YQU789f9J8rf F/jcfgL0+w9jWwjTFv3kyyPJUUdxPB29u6n5pwleWkGEHQWxwn44slqR+9FQS8B9 8VT+Pu89UkfTgGQWAnOnaUom4VabbzDZivhyvk7EWL57gL/nqUF1q69AwR4AMaNj Ppb6Y/f0s252hjPX26WjP9Ni5F2lleiumxgFvW3WRmpY3U/nJ4gvB3Nbzq3vcgsz ICQ3wmyoK3OsouT+lAGa5hjsa12kTmQNf1vBkN58hz8eZj8i17O5brxZmv6JBPDB TNk/VD/CS0KENTEccw40Vqe/8UCwxQ== =JB4d -----END PGP SIGNATURE----- --+jhVVhN62yS6hEJ8-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB2F1C48BDF for ; Tue, 15 Jun 2021 12:31:40 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CFF861439 for ; Tue, 15 Jun 2021 12:31:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CFF861439 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2ECC71696; Tue, 15 Jun 2021 14:30:47 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2ECC71696 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623760297; bh=Lb24lKt6MXXaaV3uULc+nVP704h2xY9cjKIbyq5ydTU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lTh04DV8ppzitXJk7RFJRUrIoNF5OHaKhPgIG3vIAggeZAA5V/HBet248furw99pg eNmnxkvgKi/O7cuNWKqYFaQdhAyQmiLR51654cHFUuim7aqdb/+ACgcuBXwucOngS/ 3FUi/LccFckC6FtqF4ATBhHxuxrsFJSFiRUIfsIQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3BC48F80113; Tue, 15 Jun 2021 14:30:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 29324F80171; Tue, 15 Jun 2021 14:30:41 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A6B88F80113 for ; Tue, 15 Jun 2021 14:30:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A6B88F80113 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GtyeMzNj" Received: by mail.kernel.org (Postfix) with ESMTPSA id A92A061420; Tue, 15 Jun 2021 12:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623760229; bh=Lb24lKt6MXXaaV3uULc+nVP704h2xY9cjKIbyq5ydTU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GtyeMzNjz9CHBPSCN2x9G3vn4txUnkQNsgXngp3iCbAOwwUcflMpOYcoRSsKpPkLL yX7/nwlWOT1M1FhN4SqHvYug2wAiciiNLjRU4Ts1NbrpSmiGfpCU9mcihq6p2SNkW6 5OVbvRhNoGJSRDvCxEeTzeRd/UfkTnQyaZx1ibrXXCdfrwMrgFW2r4f1vVKBe5NuzB d+Y4uXzvZQfnL1QTOQsBy3/w4uJWKV/urP2IXs+E8A1kphGhhWu9f06Quv9TBEd4Td rtvd1YzZCygTFZiHbxbrzZ48i6ojA2In932FqDbH0dqzbLgzzLvN/FT87F441v36GD CMeb4CQTGIhjQ== Date: Tue, 15 Jun 2021 13:30:08 +0100 From: Mark Brown To: Claudius Heine Subject: Re: [PATCH 1/3] ASoC: tlv320aic32x4: prepare driver for different device variants Message-ID: <20210615123008.GF5149@sirena.org.uk> References: <20210615094933.3076392-1-ch@denx.de> <20210615094933.3076392-2-ch@denx.de> <20210615115438.GD5149@sirena.org.uk> <32b82dae-45ea-c6d4-77b7-c8a234cbf803@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+jhVVhN62yS6hEJ8" Content-Disposition: inline In-Reply-To: <32b82dae-45ea-c6d4-77b7-c8a234cbf803@denx.de> X-Cookie: See store for details. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Marek Vasut , Pierre-Louis Bossart , alsa-devel@alsa-project.org, Matthias Schiffer , Kuninori Morimoto , open list , Takashi Iwai , Sia Jee Heng , Liam Girdwood , Annaliese McDermond , Miquel Raynal , Michael Sit Wei Hong X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --+jhVVhN62yS6hEJ8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 15, 2021 at 02:06:30PM +0200, Claudius Heine wrote: > On 2021-06-15 13:54, Mark Brown wrote: > > On Tue, Jun 15, 2021 at 11:49:30AM +0200, Claudius Heine wrote: > > > With this change it will be possible to add different code paths for > > > similar devices. > > > - { "tlv320aic32x4", 0 }, > > > - { "tlv320aic32x6", 1 }, > > > + { "tlv320aic32x4", (kernel_ulong_t)AIC32X4_TYPE_AIC32X4 }, > > > + { "tlv320aic32x6", (kernel_ulong_t)AIC32X4_TYPE_AIC32X6 }, > > > { /* sentinel */ } > > It appears that the device already supports multiple variants? > Those values aren't used anywhere as far as I can see. The point here is that you need a better changelog, the driver clearly already supports multiple devices so we need a few more words to explain what this is doing. --+jhVVhN62yS6hEJ8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDInVAACgkQJNaLcl1U h9Dp4gf/ZQ2xpw5GNRXy86pCeJSO0K6PI3Zc3o8poYFgEjZfhzK7YQU789f9J8rf F/jcfgL0+w9jWwjTFv3kyyPJUUdxPB29u6n5pwleWkGEHQWxwn44slqR+9FQS8B9 8VT+Pu89UkfTgGQWAnOnaUom4VabbzDZivhyvk7EWL57gL/nqUF1q69AwR4AMaNj Ppb6Y/f0s252hjPX26WjP9Ni5F2lleiumxgFvW3WRmpY3U/nJ4gvB3Nbzq3vcgsz ICQ3wmyoK3OsouT+lAGa5hjsa12kTmQNf1vBkN58hz8eZj8i17O5brxZmv6JBPDB TNk/VD/CS0KENTEccw40Vqe/8UCwxQ== =JB4d -----END PGP SIGNATURE----- --+jhVVhN62yS6hEJ8--