* [PATCH] ath11k: Fix an error handling path in 'ath11k_core_fetch_board_data_api_n()'
@ 2021-05-22 9:50 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2021-05-22 9:50 UTC (permalink / raw)
To: kvalo, davem, kuba, bperumal, akolli, milehu, lkp
Cc: ath11k, linux-wireless, netdev, linux-kernel, kernel-janitors,
Christophe JAILLET
All error paths but this one 'goto err' in order to release some
resources.
Fix this.
Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/wireless/ath/ath11k/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 77ce3347ab86..595e83fe0990 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -488,7 +488,8 @@ static int ath11k_core_fetch_board_data_api_n(struct ath11k_base *ab,
if (len < ALIGN(ie_len, 4)) {
ath11k_err(ab, "invalid length for board ie_id %d ie_len %zu len %zu\n",
ie_id, ie_len, len);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err;
}
switch (ie_id) {
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ath11k: Fix an error handling path in 'ath11k_core_fetch_board_data_api_n()'
@ 2021-05-22 9:50 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2021-05-22 9:50 UTC (permalink / raw)
To: kvalo, davem, kuba, bperumal, akolli, milehu, lkp
Cc: ath11k, linux-wireless, netdev, linux-kernel, kernel-janitors,
Christophe JAILLET
All error paths but this one 'goto err' in order to release some
resources.
Fix this.
Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/wireless/ath/ath11k/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
index 77ce3347ab86..595e83fe0990 100644
--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c
@@ -488,7 +488,8 @@ static int ath11k_core_fetch_board_data_api_n(struct ath11k_base *ab,
if (len < ALIGN(ie_len, 4)) {
ath11k_err(ab, "invalid length for board ie_id %d ie_len %zu len %zu\n",
ie_id, ie_len, len);
- return -EINVAL;
+ ret = -EINVAL;
+ goto err;
}
switch (ie_id) {
--
2.30.2
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: Fix an error handling path in 'ath11k_core_fetch_board_data_api_n()'
2021-05-22 9:50 ` Christophe JAILLET
(?)
@ 2021-06-15 14:02 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-06-15 14:02 UTC (permalink / raw)
To: Christophe JAILLET
Cc: davem, kuba, bperumal, akolli, milehu, lkp, ath11k,
linux-wireless, netdev, linux-kernel, kernel-janitors,
Christophe JAILLET
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> All error paths but this one 'goto err' in order to release some
> resources.
> Fix this.
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
515bda1d1e51 ath11k: Fix an error handling path in ath11k_core_fetch_board_data_api_n()
--
https://patchwork.kernel.org/project/linux-wireless/patch/e959eb544f3cb04258507d8e25a6f12eab126bde.1621676864.git.christophe.jaillet@wanadoo.fr/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath11k: Fix an error handling path in 'ath11k_core_fetch_board_data_api_n()'
2021-05-22 9:50 ` Christophe JAILLET
(?)
(?)
@ 2021-06-15 14:02 ` Kalle Valo
-1 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-06-15 14:02 UTC (permalink / raw)
To: Christophe JAILLET
Cc: davem, kuba, bperumal, akolli, milehu, lkp, ath11k,
linux-wireless, netdev, linux-kernel, kernel-janitors,
Christophe JAILLET
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> All error paths but this one 'goto err' in order to release some
> resources.
> Fix this.
>
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
515bda1d1e51 ath11k: Fix an error handling path in ath11k_core_fetch_board_data_api_n()
--
https://patchwork.kernel.org/project/linux-wireless/patch/e959eb544f3cb04258507d8e25a6f12eab126bde.1621676864.git.christophe.jaillet@wanadoo.fr/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-15 18:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22 9:50 [PATCH] ath11k: Fix an error handling path in 'ath11k_core_fetch_board_data_api_n()' Christophe JAILLET
2021-05-22 9:50 ` Christophe JAILLET
2021-06-15 14:02 ` Kalle Valo
2021-06-15 14:02 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.