From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02884C48BE5 for ; Tue, 15 Jun 2021 18:21:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3764613CC for ; Tue, 15 Jun 2021 18:21:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231661AbhFOSXp (ORCPT ); Tue, 15 Jun 2021 14:23:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:39490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230349AbhFOSXp (ORCPT ); Tue, 15 Jun 2021 14:23:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE9E6610CD; Tue, 15 Jun 2021 18:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623781300; bh=SzyNItewNDf3JLfbNaHGlLNTLLwcqD7llt2uApYwFsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p0dXbmARm2inTC1UzBTVZL0vHWS1a7A8WbWw5Ya+27l1H/AVxTX/AIUi8BNa2m69S WldU9ZaDX171o/gB051qQ6RYH6l3R5QoMEvO39E8xySUu+8rbSZA58KJktl2Kydm+0 Ib5HqF2tEQmKvQoRWiQVGghg2pqwlk0Gc/ZlMQchF7PnelhopV3rLUdX64WF6z8yzP OXPLyHlbMxxfXE+ZMol8ZfV4RvHEaQY1GLEsRHREhGsms+hkI98ImehNq/tQ27X3z1 w4PHNaztggl49onc3oECs14PoZF8XmiU4ZYXVpVhKKqLOx77QVBnj7IPXYvCB9blnb cVAsZBHbBhvYg== Date: Tue, 15 Jun 2021 19:21:35 +0100 From: Will Deacon To: Krishna Reddy Cc: Marek Szyprowski , Thierry Reding , Krzysztof Kozlowski , Robin Murphy , Joerg Roedel , Jonathan Hunter , Nicolin Chen , "linux-tegra@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize() Message-ID: <20210615182135.GA21481@willie-the-truck> References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-4-thierry.reding@gmail.com> <46e65ade-49cb-5437-5863-1f11ccc2205e@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, Jun 15, 2021 at 06:12:13PM +0000, Krishna Reddy wrote: > > if (smmu->impl->probe_finalize) > > The above is the issue. It should be updated as below similar to other instances impl callbacks. > if (smmu->impl && smmu->impl->probe_finalize) I'll push a patch on top shortly... Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41CD3C48BDF for ; Tue, 15 Jun 2021 18:21:45 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4398610CD for ; Tue, 15 Jun 2021 18:21:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4398610CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B19FB40650; Tue, 15 Jun 2021 18:21:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ap1--COSrTs5; Tue, 15 Jun 2021 18:21:43 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 830D640393; Tue, 15 Jun 2021 18:21:43 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 16017C000D; Tue, 15 Jun 2021 18:21:43 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9BA28C000B for ; Tue, 15 Jun 2021 18:21:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 94BFA608C2 for ; Tue, 15 Jun 2021 18:21:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 55WgdMyAjAsC for ; Tue, 15 Jun 2021 18:21:41 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp3.osuosl.org (Postfix) with ESMTPS id 34B11607BC for ; Tue, 15 Jun 2021 18:21:41 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DE9E6610CD; Tue, 15 Jun 2021 18:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623781300; bh=SzyNItewNDf3JLfbNaHGlLNTLLwcqD7llt2uApYwFsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p0dXbmARm2inTC1UzBTVZL0vHWS1a7A8WbWw5Ya+27l1H/AVxTX/AIUi8BNa2m69S WldU9ZaDX171o/gB051qQ6RYH6l3R5QoMEvO39E8xySUu+8rbSZA58KJktl2Kydm+0 Ib5HqF2tEQmKvQoRWiQVGghg2pqwlk0Gc/ZlMQchF7PnelhopV3rLUdX64WF6z8yzP OXPLyHlbMxxfXE+ZMol8ZfV4RvHEaQY1GLEsRHREhGsms+hkI98ImehNq/tQ27X3z1 w4PHNaztggl49onc3oECs14PoZF8XmiU4ZYXVpVhKKqLOx77QVBnj7IPXYvCB9blnb cVAsZBHbBhvYg== Date: Tue, 15 Jun 2021 19:21:35 +0100 From: Will Deacon To: Krishna Reddy Subject: Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize() Message-ID: <20210615182135.GA21481@willie-the-truck> References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-4-thierry.reding@gmail.com> <46e65ade-49cb-5437-5863-1f11ccc2205e@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Krzysztof Kozlowski , Jonathan Hunter , "iommu@lists.linux-foundation.org" , Thierry Reding , Nicolin Chen , "linux-tegra@vger.kernel.org" , Robin Murphy , "linux-arm-kernel@lists.infradead.org" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Tue, Jun 15, 2021 at 06:12:13PM +0000, Krishna Reddy wrote: > > if (smmu->impl->probe_finalize) > > The above is the issue. It should be updated as below similar to other instances impl callbacks. > if (smmu->impl && smmu->impl->probe_finalize) I'll push a patch on top shortly... Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE797C48BE8 for ; Tue, 15 Jun 2021 21:55:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BC4A611AB for ; Tue, 15 Jun 2021 21:55:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BC4A611AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BMFuZS7U+++4A+cIx9wqF72G5c7ROszkoyLE0BRyvus=; b=MxGDTzQRdoW0uW YuloOmYspILUIlaEZVmP3lGTZ+OJ65xBD3oVtZIlbt7KcsdVJKHsaP2JGDSGLwPpPOBB8R5L3ixm3 C0d7vx5qbAlFVFZFDmWCrXYBVMIHMqNqhWnP7GWQnzNHZo3RcHZNS7vWx7c/nb1bjO+1kRZSsQGVs DbXfiu0vy4rUsYKDKl75U3rvaH6aNE7W6RapMzKi/iNi08K3tGQfuqnzM2iwkUT9POjv1aAa2nmFA 6HK5DmzfoukslwBAXTgcm6Gv2njlxf2DjABkwbsC+V8ABGpNIRjG2Is4esUdc0euPHfFCYeETxnd0 7Btg3Mf3YG7JTCFmwlXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltGzf-003Ks3-38; Tue, 15 Jun 2021 21:53:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltDgz-0024no-Ku for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 18:21:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE9E6610CD; Tue, 15 Jun 2021 18:21:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623781300; bh=SzyNItewNDf3JLfbNaHGlLNTLLwcqD7llt2uApYwFsc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p0dXbmARm2inTC1UzBTVZL0vHWS1a7A8WbWw5Ya+27l1H/AVxTX/AIUi8BNa2m69S WldU9ZaDX171o/gB051qQ6RYH6l3R5QoMEvO39E8xySUu+8rbSZA58KJktl2Kydm+0 Ib5HqF2tEQmKvQoRWiQVGghg2pqwlk0Gc/ZlMQchF7PnelhopV3rLUdX64WF6z8yzP OXPLyHlbMxxfXE+ZMol8ZfV4RvHEaQY1GLEsRHREhGsms+hkI98ImehNq/tQ27X3z1 w4PHNaztggl49onc3oECs14PoZF8XmiU4ZYXVpVhKKqLOx77QVBnj7IPXYvCB9blnb cVAsZBHbBhvYg== Date: Tue, 15 Jun 2021 19:21:35 +0100 From: Will Deacon To: Krishna Reddy Cc: Marek Szyprowski , Thierry Reding , Krzysztof Kozlowski , Robin Murphy , Joerg Roedel , Jonathan Hunter , Nicolin Chen , "linux-tegra@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 3/9] iommu/arm-smmu: Implement ->probe_finalize() Message-ID: <20210615182135.GA21481@willie-the-truck> References: <20210603164632.1000458-1-thierry.reding@gmail.com> <20210603164632.1000458-4-thierry.reding@gmail.com> <46e65ade-49cb-5437-5863-1f11ccc2205e@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_112141_854357_080709BF X-CRM114-Status: UNSURE ( 8.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 15, 2021 at 06:12:13PM +0000, Krishna Reddy wrote: > > if (smmu->impl->probe_finalize) > > The above is the issue. It should be updated as below similar to other instances impl callbacks. > if (smmu->impl && smmu->impl->probe_finalize) I'll push a patch on top shortly... Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel