From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931DA2FB8 for ; Tue, 15 Jun 2021 23:35:06 +0000 (UTC) Received: by mail-il1-f178.google.com with SMTP id b5so649474ilc.12 for ; Tue, 15 Jun 2021 16:35:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M7mtpARxZOramxjxaW7DY3FJniUk5KYYeFWsUiBQS4s=; b=m4K7GBan1XRZcTiGOs0DkrpV1PthIfCsRb+MvUzq3M1mCN2qIAsChA/rv4eUTyIF0L R4NWzQmX/hkCLDS3yB398wNbPEqNCg5Ol9C69UfvPBW0eMLdEgTZsd3VrL7IMl9BDSHM zDyN32lgtaDu6hpfKoYjZcISoIv7fwp4DlgMvNASYrRaE5K7rVOTXYWWRCHlQfAJhPRw 95ZBLk7G/St766PsFGX9PKqH6rPKOC0xkbbDiz/VLmaYL78uUmvTlhY5BBX9xvi/YYl0 IWpDZZyzzP8rdlAtvdI3lH/JJUccU7TIiM9h2UEDMGOhgW8seiqx7oJEiQuvAq4nKdO8 iq5g== X-Gm-Message-State: AOAM530nM0DtOLlyOs2Y4+7riJiqS0JTu7Hq9V8VKQXD7cK1eBjZAy64 XM1VG4rE+tOURAo4zVOrLQ== X-Google-Smtp-Source: ABdhPJzZpda2GZV56qSibl8HTwsctfk6cpz/tUqIyo+rWfUorW+b8tZ2HGW4F0404Loq2ti7RNgU4Q== X-Received: by 2002:a05:6e02:1d82:: with SMTP id h2mr1452459ila.180.1623800105906; Tue, 15 Jun 2021 16:35:05 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id a17sm263693ilb.57.2021.06.15.16.35.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 16:35:05 -0700 (PDT) Received: (nullmailer pid 1649131 invoked by uid 1000); Tue, 15 Jun 2021 23:35:02 -0000 Date: Tue, 15 Jun 2021 17:35:02 -0600 From: Rob Herring To: Andre Przywara Cc: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Icenowy Zheng , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ondrej Jirman , devicetree@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v7 03/19] dt-bindings: rtc: sun6i: Add H616 compatible string Message-ID: <20210615233502.GA1630203@robh.at.kernel.org> References: <20210615110636.23403-1-andre.przywara@arm.com> <20210615110636.23403-4-andre.przywara@arm.com> X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615110636.23403-4-andre.przywara@arm.com> On Tue, Jun 15, 2021 at 12:06:20PM +0100, Andre Przywara wrote: > Add the obvious compatible name to the existing RTC binding. > The actual RTC part of the device uses a different day/month/year > storage scheme, so it's not compatible with the previous devices. > Also the clock part is quite different, as there is no external 32K LOSC > oscillator input. > > Signed-off-by: Andre Przywara > --- > .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > index b1b0ee769b71..2c3fd72e17ee 100644 > --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > @@ -26,6 +26,7 @@ properties: > - const: allwinner,sun50i-a64-rtc > - const: allwinner,sun8i-h3-rtc > - const: allwinner,sun50i-h6-rtc > + - const: allwinner,sun50i-h616-rtc > > reg: > maxItems: 1 > @@ -105,6 +106,20 @@ allOf: > minItems: 3 > maxItems: 3 > > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun50i-h616-rtc > + > + then: > + properties: > + clock-output-names: > + minItems: 3 > + maxItems: 3 > + clocks: > + maxItems: 0 clocks: false if forbidding clocks is what you want. > + > - if: > properties: > compatible: > -- > 2.17.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A6FC48BDF for ; Tue, 15 Jun 2021 23:51:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5539860E0B for ; Tue, 15 Jun 2021 23:51:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5539860E0B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=reJ3s0JoN8eOd7alBOdpXDCFwIg1ptHXBltl3kR+0N0=; b=M4o9FWZSwkUDtx NwapUS+XdJsJz9rOB/gmxH0UJOPiHtGvbqhLMtRYyjL3t3E2YErnmxpR+Vgy7E4Xa42SBaOotW2AH t9bI36CkJ8Zii25KZkNckYc4fa2jauW/kVvQojZmczGjkn1W+ex3Po45u4BNGelVGL+NjFVBTIsMD fXpX6xr6dUMSELRYEVEEY3GnYnuyrQhiDWl7NUfUJ4YPpN258tWR1agNmOZKtB06J6UMf0JQB+0Eu 6S3YsVl5y0mrYg+ZXqTSwzZrcuU05MdIVipfxMDjBNOYmHL7I5VITrezQrvYhPLqZZgffGCdsiK9/ U5q4+U8Qm+P3VtyDZNaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltIog-003yeJ-Lv; Tue, 15 Jun 2021 23:49:59 +0000 Received: from mail-il1-f171.google.com ([209.85.166.171]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltIaI-003tvo-Qy for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 23:35:08 +0000 Received: by mail-il1-f171.google.com with SMTP id z1so737944ils.0 for ; Tue, 15 Jun 2021 16:35:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M7mtpARxZOramxjxaW7DY3FJniUk5KYYeFWsUiBQS4s=; b=cI/JEX49gFPQYldtgRnVVrNk3zJwHABuH1+/K7H0tCSu5u4B4BWBTXJu1dsyFnG6Hw ndl+ZoR5K0/vYzmwNKjGKNM0ARWWJg7HEEm/L1O5gKzJR8e6jGr3kQYAR8TwfQ7oMUNk vvVQqSvAEVzG/T/AkWg+fnmkLNiM7gAHSm+9IviFT2zx1PzivIzQHUnqXy6Ab/b5m3HV ovQRhkLhPKAibksQ+BRHItyvUif9HuQ/ZU+C8jU7MCLfPIs7Smy8f9j05SGlfTbE1Jgv YnW/pIf5vLhhLL6eAkqSRow95E1zQlioRrDM/FOJR4e2R8zhuiCW9kgZwqYslTBPebn6 35pg== X-Gm-Message-State: AOAM530GHRH6Cxx9QCTW1QiaZ72hx8YET1qYIYSqZNpKc8twDJ68HWlY 7+FpGknu4yezSP9aAAF+4xhZUzqzFw== X-Google-Smtp-Source: ABdhPJzZpda2GZV56qSibl8HTwsctfk6cpz/tUqIyo+rWfUorW+b8tZ2HGW4F0404Loq2ti7RNgU4Q== X-Received: by 2002:a05:6e02:1d82:: with SMTP id h2mr1452459ila.180.1623800105906; Tue, 15 Jun 2021 16:35:05 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id a17sm263693ilb.57.2021.06.15.16.35.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 16:35:05 -0700 (PDT) Received: (nullmailer pid 1649131 invoked by uid 1000); Tue, 15 Jun 2021 23:35:02 -0000 Date: Tue, 15 Jun 2021 17:35:02 -0600 From: Rob Herring To: Andre Przywara Cc: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Icenowy Zheng , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ondrej Jirman , devicetree@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v7 03/19] dt-bindings: rtc: sun6i: Add H616 compatible string Message-ID: <20210615233502.GA1630203@robh.at.kernel.org> References: <20210615110636.23403-1-andre.przywara@arm.com> <20210615110636.23403-4-andre.przywara@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210615110636.23403-4-andre.przywara@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_163506_941428_CC7FAA17 X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 15, 2021 at 12:06:20PM +0100, Andre Przywara wrote: > Add the obvious compatible name to the existing RTC binding. > The actual RTC part of the device uses a different day/month/year > storage scheme, so it's not compatible with the previous devices. > Also the clock part is quite different, as there is no external 32K LOSC > oscillator input. > > Signed-off-by: Andre Przywara > --- > .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > index b1b0ee769b71..2c3fd72e17ee 100644 > --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.yaml > @@ -26,6 +26,7 @@ properties: > - const: allwinner,sun50i-a64-rtc > - const: allwinner,sun8i-h3-rtc > - const: allwinner,sun50i-h6-rtc > + - const: allwinner,sun50i-h616-rtc > > reg: > maxItems: 1 > @@ -105,6 +106,20 @@ allOf: > minItems: 3 > maxItems: 3 > > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun50i-h616-rtc > + > + then: > + properties: > + clock-output-names: > + minItems: 3 > + maxItems: 3 > + clocks: > + maxItems: 0 clocks: false if forbidding clocks is what you want. > + > - if: > properties: > compatible: > -- > 2.17.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel