From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4B9CC48BE8 for ; Wed, 16 Jun 2021 01:56:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D553D61209 for ; Wed, 16 Jun 2021 01:56:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D553D61209 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DDABE82927; Wed, 16 Jun 2021 03:56:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 1E87C8293C; Wed, 16 Jun 2021 03:56:06 +0200 (CEST) Received: from ATCSQR.andestech.com (exmail.andestech.com [60.248.187.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DDE7A82916 for ; Wed, 16 Jun 2021 03:56:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (atcpcs16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id 15G1trYR095998; Wed, 16 Jun 2021 09:55:53 +0800 (GMT-8) (envelope-from ycliang@andestech.com) Received: from andestech.com (10.0.15.65) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Wed, 16 Jun 2021 09:55:50 +0800 Date: Wed, 16 Jun 2021 09:55:50 +0800 From: Leo Liang To: Sean Anderson CC: Subject: Re: [PATCH v3 03/11] clk: k210: Move pll into the rest of the driver Message-ID: <20210616015550.GC6791@andestech.com> References: <20210611041617.1665833-1-seanga2@gmail.com> <20210611041617.1665833-4-seanga2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210611041617.1665833-4-seanga2@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.0.15.65] X-DNSRBL: X-MAIL: ATCSQR.andestech.com 15G1trYR095998 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Jun 11, 2021 at 12:16:09PM +0800, Sean Anderson wrote: > Now that there no separate PLL driver, we can no longer make the PLL > functions static. By moving the PLL driver in with the rest of the clock > code, we can make these functions static again. We still keep the pll > header for unit testing, but it is pretty reduced. > > Signed-off-by: Sean Anderson > --- > > (no changes since v1) > > drivers/clk/kendryte/Makefile | 2 +- > drivers/clk/kendryte/clk.c | 606 +++++++++++++++++++++++++++++++++- > drivers/clk/kendryte/pll.c | 587 -------------------------------- > include/kendryte/clk.h | 35 -- > include/kendryte/pll.h | 34 -- > 5 files changed, 601 insertions(+), 663 deletions(-) > delete mode 100644 drivers/clk/kendryte/pll.c > delete mode 100644 include/kendryte/clk.h Reviewed-by: Leo Yu-Chi Liang