* [PATCH -next] apply: use DEFINE_SPINLOCK() instead of spin_lock_init().
@ 2021-06-16 3:17 ` Yu Jiahua
0 siblings, 0 replies; 4+ messages in thread
From: Yu Jiahua @ 2021-06-16 3:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-omap, linux-fbdev, linux-kernel, yujiahua1
From: Jiahua Yu <yujiahua1@huawei.com>
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().
Signed-off-by: Jiahua Yu <yujiahua1@huawei.com>
---
drivers/video/fbdev/omap2/omapfb/dss/apply.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/apply.c b/drivers/video/fbdev/omap2/omapfb/dss/apply.c
index c71021091828..acca991c7540 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/apply.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/apply.c
@@ -108,7 +108,7 @@ static struct {
} dss_data;
/* protects dss_data */
-static spinlock_t data_lock;
+static DEFINE_SPINLOCK(data_lock);
/* lock for blocking functions */
static DEFINE_MUTEX(apply_lock);
static DECLARE_COMPLETION(extra_updated_completion);
@@ -131,8 +131,6 @@ static void apply_init_priv(void)
struct mgr_priv_data *mp;
int i;
- spin_lock_init(&data_lock);
-
for (i = 0; i < num_ovls; ++i) {
struct ovl_priv_data *op;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH -next] apply: use DEFINE_SPINLOCK() instead of spin_lock_init().
@ 2021-06-16 3:17 ` Yu Jiahua
0 siblings, 0 replies; 4+ messages in thread
From: Yu Jiahua @ 2021-06-16 3:17 UTC (permalink / raw)
To: dri-devel; +Cc: linux-fbdev, linux-omap, linux-kernel, yujiahua1
From: Jiahua Yu <yujiahua1@huawei.com>
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().
Signed-off-by: Jiahua Yu <yujiahua1@huawei.com>
---
drivers/video/fbdev/omap2/omapfb/dss/apply.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/apply.c b/drivers/video/fbdev/omap2/omapfb/dss/apply.c
index c71021091828..acca991c7540 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/apply.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/apply.c
@@ -108,7 +108,7 @@ static struct {
} dss_data;
/* protects dss_data */
-static spinlock_t data_lock;
+static DEFINE_SPINLOCK(data_lock);
/* lock for blocking functions */
static DEFINE_MUTEX(apply_lock);
static DECLARE_COMPLETION(extra_updated_completion);
@@ -131,8 +131,6 @@ static void apply_init_priv(void)
struct mgr_priv_data *mp;
int i;
- spin_lock_init(&data_lock);
-
for (i = 0; i < num_ovls; ++i) {
struct ovl_priv_data *op;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] apply: use DEFINE_SPINLOCK() instead of spin_lock_init().
2021-06-16 3:17 ` Yu Jiahua
@ 2021-06-17 17:43 ` Daniel Vetter
-1 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2021-06-17 17:43 UTC (permalink / raw)
To: Yu Jiahua; +Cc: dri-devel, linux-fbdev, linux-omap, linux-kernel
On Tue, Jun 15, 2021 at 07:17:13PM -0800, Yu Jiahua wrote:
> From: Jiahua Yu <yujiahua1@huawei.com>
>
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
>
> Signed-off-by: Jiahua Yu <yujiahua1@huawei.com>
Stuffed into drm-misc-next. The subject looked a bit strange, so I fixed
that up.
-Daniel
> ---
> drivers/video/fbdev/omap2/omapfb/dss/apply.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/apply.c b/drivers/video/fbdev/omap2/omapfb/dss/apply.c
> index c71021091828..acca991c7540 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/apply.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/apply.c
> @@ -108,7 +108,7 @@ static struct {
> } dss_data;
>
> /* protects dss_data */
> -static spinlock_t data_lock;
> +static DEFINE_SPINLOCK(data_lock);
> /* lock for blocking functions */
> static DEFINE_MUTEX(apply_lock);
> static DECLARE_COMPLETION(extra_updated_completion);
> @@ -131,8 +131,6 @@ static void apply_init_priv(void)
> struct mgr_priv_data *mp;
> int i;
>
> - spin_lock_init(&data_lock);
> -
> for (i = 0; i < num_ovls; ++i) {
> struct ovl_priv_data *op;
>
> --
> 2.17.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] apply: use DEFINE_SPINLOCK() instead of spin_lock_init().
@ 2021-06-17 17:43 ` Daniel Vetter
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Vetter @ 2021-06-17 17:43 UTC (permalink / raw)
To: Yu Jiahua; +Cc: linux-fbdev, linux-omap, linux-kernel, dri-devel
On Tue, Jun 15, 2021 at 07:17:13PM -0800, Yu Jiahua wrote:
> From: Jiahua Yu <yujiahua1@huawei.com>
>
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
>
> Signed-off-by: Jiahua Yu <yujiahua1@huawei.com>
Stuffed into drm-misc-next. The subject looked a bit strange, so I fixed
that up.
-Daniel
> ---
> drivers/video/fbdev/omap2/omapfb/dss/apply.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/apply.c b/drivers/video/fbdev/omap2/omapfb/dss/apply.c
> index c71021091828..acca991c7540 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/apply.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/apply.c
> @@ -108,7 +108,7 @@ static struct {
> } dss_data;
>
> /* protects dss_data */
> -static spinlock_t data_lock;
> +static DEFINE_SPINLOCK(data_lock);
> /* lock for blocking functions */
> static DEFINE_MUTEX(apply_lock);
> static DECLARE_COMPLETION(extra_updated_completion);
> @@ -131,8 +131,6 @@ static void apply_init_priv(void)
> struct mgr_priv_data *mp;
> int i;
>
> - spin_lock_init(&data_lock);
> -
> for (i = 0; i < num_ovls; ++i) {
> struct ovl_priv_data *op;
>
> --
> 2.17.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-17 17:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 3:17 [PATCH -next] apply: use DEFINE_SPINLOCK() instead of spin_lock_init() Yu Jiahua
2021-06-16 3:17 ` Yu Jiahua
2021-06-17 17:43 ` Daniel Vetter
2021-06-17 17:43 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.