From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02612C48BE5 for ; Wed, 16 Jun 2021 12:10:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19F616115C for ; Wed, 16 Jun 2021 12:10:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19F616115C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 998AA828EB; Wed, 16 Jun 2021 14:10:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qBM8O1F6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5CC2182958; Wed, 16 Jun 2021 14:10:16 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7634781107 for ; Wed, 16 Jun 2021 14:10:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82f.google.com with SMTP id z4so1648439qts.4 for ; Wed, 16 Jun 2021 05:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qhLKBSbAuqBROuo5SRGQZuyKjBmU88SGx+RdWGvsJsU=; b=qBM8O1F6OUARrXS3dINcCyDsSJMAuHGzY0E3Sg4SvM/Ey0U222R3kgKcfAACfJsz6a cSmXdzhM/xpdx0ZCxkgj3Xwq4OX9HfF/lJbrEbIXf0epNbs6Jltt+WGrKrQcnTfdL/XN Oo7dYLilwYag5rWR8jI4hDyGoL7ju4R2hZ3c8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qhLKBSbAuqBROuo5SRGQZuyKjBmU88SGx+RdWGvsJsU=; b=X/oHTwhZW6a24VMmCANeT3tB1V0EpFrA1gWybP4RbilAHhvzEXRotO+FQ4YVQJG8Lr NNZejWU7gMDS4U9DFbgQwtDBpp3IOaUEhXyHl49kunybAA8jERLc3a1TM2OTFaJwepOB R7UJT1ojrqGhclWXF3Gjc3+DyQDDz2E495DwZKvNwd76HJtK0PALmuK+cFDmdhUqXG2n GNfcmJq51mzuTKsNQJYPCoKRcCIyHZG73RyZk5QTVUumAgA7OjUN84+JKZg/Wmoo0zHQ qcoT/dnsSvdT5RkTERWJ5XoXLK5xoDyGP/homE6IKLvuU9jFfyE6c4Z9dK2AITWcZoC6 T/cQ== X-Gm-Message-State: AOAM531qOXbqTF2FCG4S9A9xiGtW1Xjw7wq4dMcgXZdaOudwzKPsQO5a qT0vbieW1mH8udCULdscHRMIdw== X-Google-Smtp-Source: ABdhPJxiatFUxGP8EJ7xaIPNErCCNt2UTKnuuQiIbyj47jti9F7Fj56J+BLIqJBWKEyrGuwnGQfn5g== X-Received: by 2002:aed:2065:: with SMTP id 92mr4672930qta.283.1623845411313; Wed, 16 Jun 2021 05:10:11 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-507d-0469-e510-a4e0.res6.spectrum.com. [2603:6081:7b01:cbda:507d:469:e510:a4e0]) by smtp.gmail.com with ESMTPSA id h14sm1109632qtp.46.2021.06.16.05.10.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jun 2021 05:10:10 -0700 (PDT) Date: Wed, 16 Jun 2021 08:10:08 -0400 From: Tom Rini To: Ivaylo Dimitrov Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , maemo-leste@lists.dyne.org, u-boot@lists.denx.de, Merlijn Wajer Subject: Re: [maemo-leste] [PATCH] arm: Remove nokia_rx51 board Message-ID: <20210616121008.GR9516@bill-the-cat> References: <20210519012640.5970-1-trini@konsulko.com> <20210519132748.mgzyukuvfmlx3uch@pali> <20210519155203.GZ17669@bill-the-cat> <20210521144418.GI17669@bill-the-cat> <20210521213645.2y5dawkvr6wfaymy@pali> <20210615123436.GH9516@bill-the-cat> <5848e9c9-4dab-00cc-07dc-ffa57b9417cd@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="06QVapOOS70QnETl" Content-Disposition: inline In-Reply-To: <5848e9c9-4dab-00cc-07dc-ffa57b9417cd@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --06QVapOOS70QnETl Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 16, 2021 at 09:02:16AM +0300, Ivaylo Dimitrov wrote: > Hi, >=20 > On 15.06.21 =D0=B3. 15:34 =D1=87., Tom Rini wrote: > > On Tue, Jun 15, 2021 at 08:40:30AM +0300, Ivaylo Dimitrov wrote: > > > Hi, > > >=20 > > > On 22.05.21 =D0=B3. 0:36 =D1=87., Pali Roh=C3=A1r wrote: > > > > On Friday 21 May 2021 10:44:18 Tom Rini wrote: > > > > > On Wed, May 19, 2021 at 11:52:03AM -0400, Tom Rini wrote: > > > > > > On Wed, May 19, 2021 at 03:27:48PM +0200, Pali Roh=C3=A1r wrote: > > > > > >=20 > > > > > > > On Tuesday 18 May 2021 21:26:40 Tom Rini wrote: > > > > > > > > This board has not been converted to CONFIG_DM_USB by the d= eadline. > > > > > > > > Remove it. > > > > > > >=20 > > > > > > > I'm very disappointed that you want to remove Nokia N900 from= U-Boot. > > > > > > >=20 > > > > > > > I was waiting waiting half of year because other developers d= id not > > > > > > > react to issues which were introduced and neither to patches = which I > > > > > > > sent (+ trying to remind open issues). And also I was waiting= another > > > > > > > half of year until other N900 related patches were merged. So= the whole > > > > > > > slowdown was not caused by me, why it is taking so long. > > > > > > >=20 > > > > > > > Now there is still one N900 DM related patch waiting for revi= ew. I'm > > > > > > > converting code step by step. > > > > > > >=20 > > > > > > > So the ball is not on my side. > > > > > >=20 > > > > > > So, what patch(es) need to be applied to get DM_USB enabled? T= hanks. > > > > >=20 > > > > > I don't see any open patches from you that look related to enabli= ng > > > > > DM_USB on the platform. If you want to disable USB on the platfo= rm for > > > > > now instead, that's fine too. > > > >=20 > > >=20 > > > I tried to migrate the latest master to DM_USB, but unfortunately the > > > results are pretty much sad - adding OF_CONTROL (which is a prerequis= ite to > > > have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds ~100k= to the > > > size of the u-boot binary, so it becomes 370284 bytes. Given that we = have > > > less than 256k of storage space for the u-boot, the produced binary c= annot > > > be used on n900 the same way current (no DM_USB) binary is used. > > >=20 > > > As I see it, there are not much options left - u-boot on N900 is not = SPL, so > > > we can't use OF_PLATDATA, which in turn always links libfdt. > > > Also, if I read the code (usb-uclass.c) correctly, enabling DM_USB re= quires > > > the board to be converted to DT and this is way bigger change. > > >=20 > > > Please advice on how to proceed. > >=20 > > Please post your WIP patches, thanks. > >=20 >=20 > Sorry, I am not sure I understand what patches you want me to post: >=20 > WDT patch has already been sent couple of months ago - > https://lists.denx.de/pipermail/u-boot/2021-March/443868.html > Do you want it to be rebased and resend? >=20 > DM_USB, I just started writing one and I immediately hit the OF_CONTROL > requirement. Enabling OF_CONTROL requires a full blown migration to DT, > which is a huge task and not really equal to "Please update the board to = use > CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures: >=20 > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > DWARF error: could not find abbrev number 3998 > /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind': > :(.text+0x5672): undefined reference to > `ofnode_read_u32_default' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > :(.text+0x568c): undefined reference to > `ofnode_read_u32_default' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device': > :(.text+0x6c84): undefined reference to `ofnode_first_subnode' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > :(.text+0x6c96): undefined reference to `ofnode_read_u32' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > :(.text+0x6ca4): undefined reference to `ofnode_next_subnode' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+0x8): > undefined reference to `dm_scan_fdt_dev' > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueabi/bin/= ld: > /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_hub+0x= 8): > undefined reference to `dm_scan_fdt_dev' >=20 > Fixing those requires enabling of OF_CONTROL and this in turn means the > board must be migrated to DT, unless I am missing something. That's why my > "please advice..." stance. Please post the patches that bring you to the above link errors, yes, thanks. --=20 Tom --06QVapOOS70QnETl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDJ6iAACgkQFHw5/5Y0 tyy2yAv+JaqJxdaxvY4SkjHkwrxFXd0tZCKo/nLh+RN2Jn56MA88jpKlF07QoeGG 8oNXYf5UiMNd1MbJgpjytZ6w0zeedP6o5HGmXafuvTh8me9xES/TwRUvi6uTjpGZ J9TiNE+xbqYWMqK5R9mwxFiP6Gs88Inv1jKmqweX8KKKzXGI5myw8sUaMSE4NLQ4 McDaiy6cjNHB+oSZA6fN60Wl/rPycpEdFJkG9c8IpsQIBfjsVTpNWkZfyjD86GwX HYV8o0Ntw6Hx3NdB8+pElElAoZPaAlnuvT99RYTbrwK2BjmuNYt7gD+l9LeECsyi qXU5Xm4e5cdVdNbL7fy4eTDVyNLEcRyLH7LxqZzoryLnisvB21whHj6kfR0NPR9r yoHN5riFpDUb39GQyn41TwgCUfnn2mADSIRuToS9t2+JQc8RcHX2ofKvsqHXy9UV PQQrdVLBNHKm3VpwryUnACxzUTo4Z9iJOWZPNo5qKYQ6TlqxwpUnVrEoWJL2iZFD 7m3E7EkV =M3g7 -----END PGP SIGNATURE----- --06QVapOOS70QnETl--