All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: return DRIVER_NAME for the fence driver name
@ 2021-06-16 12:28 ` Matthew Auld
  0 siblings, 0 replies; 10+ messages in thread
From: Matthew Auld @ 2021-06-16 12:28 UTC (permalink / raw)
  To: intel-gfx; +Cc: Michael Mason, dri-devel

The first tracepoint for a request is trace_dma_fence_init which is
called in the ctor before we have properly setup the request->engine. So
if it's a non-recycled request the rq->engine might be NULL, or some
garbage value, which leads to a crash.

Since we are not permitted to use kmem_cache_zalloc() here with
SLAB_TYPESAFE_BY_RCU, one approach is simply to return DRIVER_NAME. We
can then revisit this later if we decide to get rid of
SLAB_TYPESAFE_BY_RCU.

Fixes: 855e39e65cfc ("drm/i915: Initialise basic fence before acquiring seqno")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Michael Mason <michael.w.mason@intel.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
 drivers/gpu/drm/i915/i915_request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
index 1014c71cf7f5..55fa94bde22e 100644
--- a/drivers/gpu/drm/i915/i915_request.c
+++ b/drivers/gpu/drm/i915/i915_request.c
@@ -61,7 +61,7 @@ static struct i915_global_request {
 
 static const char *i915_fence_get_driver_name(struct dma_fence *fence)
 {
-	return dev_name(to_request(fence)->engine->i915->drm.dev);
+	return DRIVER_NAME;
 }
 
 static const char *i915_fence_get_timeline_name(struct dma_fence *fence)
-- 
2.26.3


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-06-23 10:12 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16 12:28 [PATCH] drm/i915: return DRIVER_NAME for the fence driver name Matthew Auld
2021-06-16 12:28 ` [Intel-gfx] " Matthew Auld
2021-06-16 13:32 ` Daniel Vetter
2021-06-16 13:32   ` [Intel-gfx] " Daniel Vetter
2021-06-16 19:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-06-16 22:40 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-06-22 21:32 ` [PATCH] " Mason, Michael W
2021-06-22 21:32   ` [Intel-gfx] " Mason, Michael W
2021-06-23 10:12 ` Thomas Zimmermann
2021-06-23 10:12   ` [Intel-gfx] " Thomas Zimmermann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.