All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alain Michaud <alainm@chromium.org>
To: linux-bluetooth@vger.kernel.org
Cc: Alain Michaud <alainm@chromium.org>, Yu Liu <yudiliu@google.com>
Subject: [Bluez PATCH v2] monitor: Adding missing device found flag in the parser
Date: Wed, 16 Jun 2021 12:42:29 +0000	[thread overview]
Message-ID: <20210616124229.1059905-1-alainm@chromium.org> (raw)

A new flag was added to the kernel implementation of the Device Found
event, but had not been added to the parser leading to an "Unknown device
flag" error in btmon.

Reviewed-by: Yu Liu <yudiliu@google.com>

Signed-off-by: Alain Michaud <alainm@chromium.org>
---

Changes in v2:
- Addressing Marcel's feedback

 monitor/packet.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 82513a63c..5a928c296 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -12030,9 +12030,10 @@ static void mgmt_print_io_capability(uint8_t capability)
 }
 
 static const struct bitfield_data mgmt_device_flags_table[] = {
-	{  0, "Confirm Name"	},
-	{  1, "Legacy Pairing"	},
-	{  2, "Not Connectable"	},
+	{  0, "Confirm Name"			},
+	{  1, "Legacy Pairing"			},
+	{  2, "Not Connectable"			},
+	{  3, "Connection Locally Initiated"	},
 	{ }
 };
 
-- 
2.32.0.272.g935e593368-goog


             reply	other threads:[~2021-06-16 12:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 12:42 Alain Michaud [this message]
2021-06-16 13:46 ` [Bluez,v2] monitor: Adding missing device found flag in the parser bluez.test.bot
2021-06-16 22:44   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210616124229.1059905-1-alainm@chromium.org \
    --to=alainm@chromium.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=yudiliu@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.