From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19BF9C48BE5 for ; Wed, 16 Jun 2021 14:14:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED34961059 for ; Wed, 16 Jun 2021 14:14:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233871AbhFPOQ4 (ORCPT ); Wed, 16 Jun 2021 10:16:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:53604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233398AbhFPOQz (ORCPT ); Wed, 16 Jun 2021 10:16:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A4E5F60200; Wed, 16 Jun 2021 14:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623852888; bh=gddT+iJoudoVpablFQEYkqg+MNl5OKYIo4Jvk+UWE58=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=YtNSVLEva/mHnZOnQojvcTftq7t0/Oo64rh4bnsnxAC8JdGaA1nSOyEOHrDTqh38+ XXeEAZgP77UFd9D/ijnXBf5GcJao/AS7f8AwpssnqJ1J9QiL5hQ2r6wjEycEUcYLnA DMhIjmqg5g7gNpqJQWY2MZ4J52bsL6LLuJR7cgxhxJVN4vLO8JRjuAT+VUnv4Oi1yE gcoeSupDdv/VpkZ2uswF8T3XOUd9am0Ip2oXIlAqgzMP63Ie/IlMjJJ8gWM/xMeCvA FsuaxHHclYPydDVXzztTgO08uOBaay5xH46rOZ6ORXj3NSpQdzfPB6LUSE7+x0PPFR Lner0uMJtLBPQ== Date: Wed, 16 Jun 2021 09:14:47 -0500 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Qi Liu , will@kernel.org, mark.rutland@arm.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, zhangshaokun@hisilicon.com Subject: Re: [PATCH v6 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Message-ID: <20210616141447.GA2973335@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210611233355.GA183580@rocinante> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 12, 2021 at 01:33:55AM +0200, Krzysztof Wilczyński wrote: > > +static ssize_t hisi_pcie_bus_show(struct device *dev, > > + struct device_attribute *attr, char *buf) > > +{ > > + struct hisi_pcie_pmu *pcie_pmu = to_pcie_pmu(dev_get_drvdata(dev)); > > + > > + return sysfs_emit(buf, "0x%02x\n", PCI_BUS_NUM(pcie_pmu->bdf_min)); > > +} > > Same as above, what about "%#02x"? I think you'd need "%#04x" because the field width includes the leading "0x", so printing 1 with "%#02x" would result in "0x1" instead of "0x01". From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92BE8C48BE6 for ; Wed, 16 Jun 2021 14:16:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 691A760200 for ; Wed, 16 Jun 2021 14:16:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 691A760200 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=YaL4TfaehjhZ/HmTqdpznICWrLxq5qvlafTt9VWFnzQ=; b=KSBOgdaviMK4xQ uvmRpUUgaYIKEFH2/BCKuC5GrXG6N940qzsksTPriP+LDG48+RX+pfNsvPiwx33voLqxFxu9ZD5dW NdtGuxndBinY+mg4ARazLZ4vODHdRyDXXtS9PS4T03Zfs0zfL6Tb0uEUg6SQIP7jL18WXZpFB6aWR ySXE3p4AMj+Mc66hg4jKFlZV5w5FSK7MorSsMHpuRWjWSQitBM8NQOPAObiirIawuz/D1E9cCpuzB 9G+3/mVafiXrRN4rzcRhwnHgl9m+OUSmFaAPlhv1t7WC0nK9GVRibGuLbkHnBbiCyHBxRhjQUPJmK P2e/RMCwYC9af0g7eIzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltWJg-006h2r-9m; Wed, 16 Jun 2021 14:14:52 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltWJd-006h2G-9K for linux-arm-kernel@lists.infradead.org; Wed, 16 Jun 2021 14:14:50 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id A4E5F60200; Wed, 16 Jun 2021 14:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623852888; bh=gddT+iJoudoVpablFQEYkqg+MNl5OKYIo4Jvk+UWE58=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=YtNSVLEva/mHnZOnQojvcTftq7t0/Oo64rh4bnsnxAC8JdGaA1nSOyEOHrDTqh38+ XXeEAZgP77UFd9D/ijnXBf5GcJao/AS7f8AwpssnqJ1J9QiL5hQ2r6wjEycEUcYLnA DMhIjmqg5g7gNpqJQWY2MZ4J52bsL6LLuJR7cgxhxJVN4vLO8JRjuAT+VUnv4Oi1yE gcoeSupDdv/VpkZ2uswF8T3XOUd9am0Ip2oXIlAqgzMP63Ie/IlMjJJ8gWM/xMeCvA FsuaxHHclYPydDVXzztTgO08uOBaay5xH46rOZ6ORXj3NSpQdzfPB6LUSE7+x0PPFR Lner0uMJtLBPQ== Date: Wed, 16 Jun 2021 09:14:47 -0500 From: Bjorn Helgaas To: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Cc: Qi Liu , will@kernel.org, mark.rutland@arm.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, zhangshaokun@hisilicon.com Subject: Re: [PATCH v6 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Message-ID: <20210616141447.GA2973335@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210611233355.GA183580@rocinante> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210616_071449_405793_D76222A8 X-CRM114-Status: UNSURE ( 8.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKdW4gMTIsIDIwMjEgYXQgMDE6MzM6NTVBTSArMDIwMCwgS3J6eXN6dG9mIFdpbGN6 ecWEc2tpIHdyb3RlOgoKPiA+ICtzdGF0aWMgc3NpemVfdCBoaXNpX3BjaWVfYnVzX3Nob3coc3Ry dWN0IGRldmljZSAqZGV2LAo+ID4gKwkJCQkgIHN0cnVjdCBkZXZpY2VfYXR0cmlidXRlICphdHRy LCBjaGFyICpidWYpCj4gPiArewo+ID4gKwlzdHJ1Y3QgaGlzaV9wY2llX3BtdSAqcGNpZV9wbXUg PSB0b19wY2llX3BtdShkZXZfZ2V0X2RydmRhdGEoZGV2KSk7Cj4gPiArCj4gPiArCXJldHVybiBz eXNmc19lbWl0KGJ1ZiwgIjB4JTAyeFxuIiwgUENJX0JVU19OVU0ocGNpZV9wbXUtPmJkZl9taW4p KTsKPiA+ICt9Cj4gCj4gU2FtZSBhcyBhYm92ZSwgd2hhdCBhYm91dCAiJSMwMngiPwoKSSB0aGlu ayB5b3UnZCBuZWVkICIlIzA0eCIgYmVjYXVzZSB0aGUgZmllbGQgd2lkdGggaW5jbHVkZXMgdGhl CmxlYWRpbmcgIjB4Iiwgc28gcHJpbnRpbmcgMSB3aXRoICIlIzAyeCIgd291bGQgcmVzdWx0IGlu ICIweDEiIGluc3RlYWQKb2YgIjB4MDEiLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=