From: Christoph Hellwig <hch@lst.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Roman Skakun <rm.skakun@gmail.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
Roman Skakun <roman_skakun@epam.com>,
Andrii Anisov <andrii_anisov@epam.com>
Subject: Re: [PATCH 2/2] swiotlb-xen: override common mmap and get_sgtable dma ops
Date: Wed, 16 Jun 2021 17:35:19 +0200 [thread overview]
Message-ID: <20210616153519.GA6476@lst.de> (raw)
In-Reply-To: <83353b34-2abb-9dfc-bed6-21d500abf49f@oracle.com>
On Wed, Jun 16, 2021 at 11:33:50AM -0400, Boris Ostrovsky wrote:
> Isn't the expectation of virt_to_page() that it only works on non-vmalloc'd addresses? (This is not a rhetorical question, I actually don't know).
Yes. Thus is why I'd suggest to just do the vmalloc_to_page or
virt_to_page dance in ops_helpers.c and just continue using that.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Roman Skakun <rm.skakun@gmail.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
linux-kernel@vger.kernel.org,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
iommu@lists.linux-foundation.org,
Andrii Anisov <andrii_anisov@epam.com>,
Roman Skakun <roman_skakun@epam.com>,
xen-devel@lists.xenproject.org,
Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 2/2] swiotlb-xen: override common mmap and get_sgtable dma ops
Date: Wed, 16 Jun 2021 17:35:19 +0200 [thread overview]
Message-ID: <20210616153519.GA6476@lst.de> (raw)
In-Reply-To: <83353b34-2abb-9dfc-bed6-21d500abf49f@oracle.com>
On Wed, Jun 16, 2021 at 11:33:50AM -0400, Boris Ostrovsky wrote:
> Isn't the expectation of virt_to_page() that it only works on non-vmalloc'd addresses? (This is not a rhetorical question, I actually don't know).
Yes. Thus is why I'd suggest to just do the vmalloc_to_page or
virt_to_page dance in ops_helpers.c and just continue using that.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-06-16 15:36 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 9:55 [PATCH] swiotlb-xen: override common mmap and get_sgtable dma ops Roman Skakun
2021-06-11 9:55 ` Roman Skakun
2021-06-11 15:19 ` Boris Ostrovsky
2021-06-11 15:19 ` Boris Ostrovsky
2021-06-14 12:47 ` Roman Skakun
2021-06-14 12:47 ` Roman Skakun
2021-06-14 12:47 ` Roman Skakun
2021-06-14 15:45 ` Boris Ostrovsky
2021-06-14 15:45 ` Boris Ostrovsky
2021-06-16 11:45 ` Roman Skakun
2021-06-16 11:45 ` Roman Skakun
2021-06-16 11:45 ` Roman Skakun
2021-06-16 11:42 ` [PATCH 1/2] Revert "swiotlb-xen: remove xen_swiotlb_dma_mmap and xen_swiotlb_dma_get_sgtable" Roman Skakun
2021-06-16 11:42 ` Roman Skakun
2021-06-16 11:42 ` [PATCH 2/2] swiotlb-xen: override common mmap and get_sgtable dma ops Roman Skakun
2021-06-16 11:42 ` Roman Skakun
2021-06-16 14:12 ` Boris Ostrovsky
2021-06-16 14:12 ` Boris Ostrovsky
2021-06-16 14:21 ` Christoph Hellwig
2021-06-16 14:21 ` Christoph Hellwig
2021-06-16 15:33 ` Boris Ostrovsky
2021-06-16 15:33 ` Boris Ostrovsky
2021-06-16 15:35 ` Christoph Hellwig [this message]
2021-06-16 15:35 ` Christoph Hellwig
2021-06-16 15:39 ` Boris Ostrovsky
2021-06-16 15:39 ` Boris Ostrovsky
2021-06-16 15:44 ` Christoph Hellwig
2021-06-16 15:44 ` Christoph Hellwig
2021-06-22 13:34 ` [PATCH v2] dma-mapping: use vmalloc_to_page for vmalloc addresses Roman Skakun
2021-06-22 13:34 ` Roman Skakun
2021-07-14 0:15 ` Konrad Rzeszutek Wilk
2021-07-14 0:15 ` Konrad Rzeszutek Wilk
2021-07-15 7:39 ` Roman Skakun
2021-07-15 7:39 ` Roman Skakun
2021-07-15 7:39 ` Roman Skakun
2021-07-15 16:58 ` Boris Ostrovsky
2021-07-15 16:58 ` Boris Ostrovsky
2021-07-15 17:00 ` Christoph Hellwig
2021-07-15 17:00 ` Christoph Hellwig
2021-07-16 8:39 ` Roman Skakun
2021-07-16 8:39 ` Roman Skakun
2021-07-16 9:35 ` Christoph Hellwig
2021-07-16 9:35 ` Christoph Hellwig
2021-07-16 12:53 ` Roman Skakun
2021-07-16 12:53 ` Roman Skakun
2021-07-16 12:53 ` Roman Skakun
2021-07-16 15:29 ` Stefano Stabellini
2021-07-16 15:29 ` Stefano Stabellini
2021-07-16 15:29 ` Stefano Stabellini
2021-07-17 8:39 ` Roman Skakun
2021-07-17 8:39 ` Roman Skakun
2021-07-17 8:39 ` Roman Skakun
2021-07-19 9:22 ` Christoph Hellwig
2021-07-19 9:22 ` Christoph Hellwig
2021-07-21 18:39 ` Roman Skakun
2021-07-21 18:39 ` Roman Skakun
2021-07-21 18:39 ` Roman Skakun
2021-07-14 1:23 ` Stefano Stabellini
2021-07-14 1:23 ` Stefano Stabellini
2021-07-14 1:23 ` Stefano Stabellini
2021-07-15 7:31 ` Roman Skakun
2021-07-15 7:31 ` Roman Skakun
2021-07-15 7:31 ` Roman Skakun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210616153519.GA6476@lst.de \
--to=hch@lst.de \
--cc=andrii_anisov@epam.com \
--cc=boris.ostrovsky@oracle.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=rm.skakun@gmail.com \
--cc=roman_skakun@epam.com \
--cc=sstabellini@kernel.org \
--cc=volodymyr_babchuk@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.