From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FEBC48BE6 for ; Wed, 16 Jun 2021 15:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8689061164 for ; Wed, 16 Jun 2021 15:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235017AbhFPP7x (ORCPT ); Wed, 16 Jun 2021 11:59:53 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:46732 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234698AbhFPP7X (ORCPT ); Wed, 16 Jun 2021 11:59:23 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 4D62F21A32; Wed, 16 Jun 2021 15:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623859034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MzEXeyUJtYhb/jhKtsstzQNYPYyugeSQ7deyI5/x/eg=; b=QluPc+xaSD6lMsYHFrTXOo9S19BGMh1dPOZCU9V9lAjMlVkbzEPC76NIYkzAlyHL6z0G2X 6V1D7RAO4dKfvHWXp9WKGolBz/Xim2qqndj/0aTBqw4NNJ/W710NpTjVSzVtUU+bCo6ztK HR1Cd37auJvcp2UU0GST9EsPQ8ys2k8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623859034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MzEXeyUJtYhb/jhKtsstzQNYPYyugeSQ7deyI5/x/eg=; b=jHTUUdWi2cy0yZq6g8W0CohAQJWdKoqUkM3WbwT5QWy5M/vj4YqpLcOCdoKxgHFiAm+6jn h8dOe0bJlFuiCtAw== Received: from quack2.suse.cz (unknown [10.100.200.198]) by relay2.suse.de (Postfix) with ESMTP id 638F1A3BAE; Wed, 16 Jun 2021 15:57:13 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 4FE0F1F2C68; Wed, 16 Jun 2021 17:57:12 +0200 (CEST) Date: Wed, 16 Jun 2021 17:57:12 +0200 From: Jan Kara To: "Darrick J. Wong" Cc: Jan Kara , Christoph Hellwig , linux-fsdevel@vger.kernel.org, Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox , Pavel Reichl , Dave Chinner , Eric Sandeen Subject: Re: [PATCH 07/14] xfs: Refactor xfs_isilocked() Message-ID: <20210616155712.GC28250@quack2.suse.cz> References: <20210615090844.6045-1-jack@suse.cz> <20210615091814.28626-7-jack@suse.cz> <20210616085304.GA28250@quack2.suse.cz> <20210616154705.GE158209@locust> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210616154705.GE158209@locust> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Wed 16-06-21 08:47:05, Darrick J. Wong wrote: > On Wed, Jun 16, 2021 at 10:53:04AM +0200, Jan Kara wrote: > > On Wed 16-06-21 06:37:12, Christoph Hellwig wrote: > > > On Tue, Jun 15, 2021 at 11:17:57AM +0200, Jan Kara wrote: > > > > From: Pavel Reichl > > > > > > > > Refactor xfs_isilocked() to use newly introduced __xfs_rwsem_islocked(). > > > > __xfs_rwsem_islocked() is a helper function which encapsulates checking > > > > state of rw_semaphores hold by inode. > > > > > > __xfs_rwsem_islocked doesn't seem to actually existing in any tree I > > > checked yet? > > > > __xfs_rwsem_islocked is introduced by this patch so I'm not sure what are > > you asking about... :) > > The sentence structure implies that __xfs_rwsem_islocked was previously > introduced. You might change the commit message to read: > > "Introduce a new __xfs_rwsem_islocked predicate to encapsulate checking > the state of a rw_semaphore, then refactor xfs_isilocked to use it." > > Since it's not quite a straight copy-paste of the old code. Ah, ok. Sure, I can rephrase the changelog (or we can just update it on commit if that's the only problem with this series...). Oh, now I've remembered I've promised you a branch to pull :) Here it is with this change and Christoph's Reviewed-by tags: git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git hole_punch_fixes Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FBFFC48BE5 for ; Wed, 16 Jun 2021 15:57:48 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E069261042; Wed, 16 Jun 2021 15:57:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E069261042 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.92.3) (envelope-from ) id 1ltXvE-00044p-JK; Wed, 16 Jun 2021 15:57:44 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) (envelope-from ) id 1ltXv6-00044T-B2 for linux-f2fs-devel@lists.sourceforge.net; Wed, 16 Jun 2021 15:57:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MzEXeyUJtYhb/jhKtsstzQNYPYyugeSQ7deyI5/x/eg=; b=O5vYZaoziMLVznYRukm2JfzU3j QV/GKpRsO3dMT3LHnVdLR+yJ5YuK5tWIgk+eaxtKGb6chpXdKQ7PAmqM2qWW9wjItam2vV69AVZ14 PfQtxAWU0ClsxOPixSilw0t0SXzrU6KKzdk5w8jQ6sNivNO2XEKnq+wPrInRfcTnHjgk=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=MzEXeyUJtYhb/jhKtsstzQNYPYyugeSQ7deyI5/x/eg=; b=WSxwBX3Wc5tqRYyHomGE3Z0evf E06Jt5IJyyNN6Wm3m/KnENi0zhNb3bTtw9ZBTfmvdrtCCJCOTSYHWcN2rgmAJrs0RRZbmor2VlMhw F/KSvTuNQkmNIpb4RncU1afjObz6SMwFS01Fv6vBbAiJ9NlNIm5OtvTHtJN6U2lf26yc=; Received: from smtp-out1.suse.de ([195.135.220.28]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.3) id 1ltXux-0000Ab-1R for linux-f2fs-devel@lists.sourceforge.net; Wed, 16 Jun 2021 15:57:36 +0000 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 4D62F21A32; Wed, 16 Jun 2021 15:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623859034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MzEXeyUJtYhb/jhKtsstzQNYPYyugeSQ7deyI5/x/eg=; b=QluPc+xaSD6lMsYHFrTXOo9S19BGMh1dPOZCU9V9lAjMlVkbzEPC76NIYkzAlyHL6z0G2X 6V1D7RAO4dKfvHWXp9WKGolBz/Xim2qqndj/0aTBqw4NNJ/W710NpTjVSzVtUU+bCo6ztK HR1Cd37auJvcp2UU0GST9EsPQ8ys2k8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623859034; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MzEXeyUJtYhb/jhKtsstzQNYPYyugeSQ7deyI5/x/eg=; b=jHTUUdWi2cy0yZq6g8W0CohAQJWdKoqUkM3WbwT5QWy5M/vj4YqpLcOCdoKxgHFiAm+6jn h8dOe0bJlFuiCtAw== Received: from quack2.suse.cz (unknown [10.100.200.198]) by relay2.suse.de (Postfix) with ESMTP id 638F1A3BAE; Wed, 16 Jun 2021 15:57:13 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 4FE0F1F2C68; Wed, 16 Jun 2021 17:57:12 +0200 (CEST) Date: Wed, 16 Jun 2021 17:57:12 +0200 From: Jan Kara To: "Darrick J. Wong" Message-ID: <20210616155712.GC28250@quack2.suse.cz> References: <20210615090844.6045-1-jack@suse.cz> <20210615091814.28626-7-jack@suse.cz> <20210616085304.GA28250@quack2.suse.cz> <20210616154705.GE158209@locust> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210616154705.GE158209@locust> User-Agent: Mutt/1.10.1 (2018-07-13) X-Headers-End: 1ltXux-0000Ab-1R Subject: Re: [f2fs-dev] [PATCH 07/14] xfs: Refactor xfs_isilocked() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jan Kara , Dave Chinner , linux-mm@kvack.org, linux-cifs@vger.kernel.org, "Darrick J. Wong" , Matthew Wilcox , Christoph Hellwig , linux-ext4@vger.kernel.org, Eric Sandeen , Dave Chinner , Jaegeuk Kim , ceph-devel@vger.kernel.org, linux-xfs@vger.kernel.org, Damien Le Moal , Ted Tso , Miklos Szeredi , Jeff Layton , linux-f2fs-devel@lists.sourceforge.net, Steve French , linux-fsdevel@vger.kernel.org, Pavel Reichl , Johannes Thumshirn Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed 16-06-21 08:47:05, Darrick J. Wong wrote: > On Wed, Jun 16, 2021 at 10:53:04AM +0200, Jan Kara wrote: > > On Wed 16-06-21 06:37:12, Christoph Hellwig wrote: > > > On Tue, Jun 15, 2021 at 11:17:57AM +0200, Jan Kara wrote: > > > > From: Pavel Reichl > > > > > > > > Refactor xfs_isilocked() to use newly introduced __xfs_rwsem_islocked(). > > > > __xfs_rwsem_islocked() is a helper function which encapsulates checking > > > > state of rw_semaphores hold by inode. > > > > > > __xfs_rwsem_islocked doesn't seem to actually existing in any tree I > > > checked yet? > > > > __xfs_rwsem_islocked is introduced by this patch so I'm not sure what are > > you asking about... :) > > The sentence structure implies that __xfs_rwsem_islocked was previously > introduced. You might change the commit message to read: > > "Introduce a new __xfs_rwsem_islocked predicate to encapsulate checking > the state of a rw_semaphore, then refactor xfs_isilocked to use it." > > Since it's not quite a straight copy-paste of the old code. Ah, ok. Sure, I can rephrase the changelog (or we can just update it on commit if that's the only problem with this series...). Oh, now I've remembered I've promised you a branch to pull :) Here it is with this change and Christoph's Reviewed-by tags: git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git hole_punch_fixes Honza -- Jan Kara SUSE Labs, CR _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel