From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D0BC48BE6 for ; Wed, 16 Jun 2021 17:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27B3F610A1 for ; Wed, 16 Jun 2021 17:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231286AbhFPR3w (ORCPT ); Wed, 16 Jun 2021 13:29:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:49086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbhFPR3v (ORCPT ); Wed, 16 Jun 2021 13:29:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 73D4160D07; Wed, 16 Jun 2021 17:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623864465; bh=DOHk4jFxa0NKi1FRc0HymIfKoP5GJ5H3EDosFnFv5Js=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gLrPfuXgXvISAFK/Xj3+3dMcYQ5Y+BoJFpphr24AQUF3EzaPFFzeEYNguSozK4i2L IO8wv/q/84ImD66N3hh6pumYPGdcd7PMwFgoE8ti2l1OwM4bTQ/HgYTjukAF5YIIF+ gLxtazSVeY/wcbQoVVllYASxgJlT7HYXAq7FpBARhcovkECI7vhDTUqHs1ZNVl+4t/ D7VYtaxspe5ZwwuYyBkWhks2ojHGEePp0o2nWDlI+ab/zKC7amfUPoLzrL0wgNc8A4 np/EwmWDPlxr6DjaF/KKCMdRAUYNlVmF/H/6gt7I7bnsaS1Dp9cX4yfiN363C0fPrZ bzea0zQym0dEw== Date: Wed, 16 Jun 2021 18:27:39 +0100 From: Will Deacon To: Bjorn Helgaas Cc: "liuqi (BA)" , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Linuxarm , mark.rutland@arm.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, zhangshaokun@hisilicon.com Subject: Re: [PATCH v6 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Message-ID: <20210616172739.GA23280@willie-the-truck> References: <20210616152343.GA2977964@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210616152343.GA2977964@bjorn-Precision-5520> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 16, 2021 at 10:23:43AM -0500, Bjorn Helgaas wrote: > On Wed, Jun 16, 2021 at 09:09:40AM +0800, liuqi (BA) wrote: > > On 2021/6/12 7:33, Krzysztof Wilczyński wrote: > > > > > +static ssize_t hisi_pcie_event_sysfs_show(struct device *dev, > > > > + struct device_attribute *attr, char *buf) > > > > +{ > > > > + struct dev_ext_attribute *eattr; > > > > + > > > > + eattr = container_of(attr, struct dev_ext_attribute, attr); > > > > + > > > > + return sysfs_emit(buf, "config=0x%lx\n", (unsigned long)eattr->var); > > > > +} > > > > > > I am not that familiar with the perf drivers, thus I might be completely > > > wrong here, but usually for sysfs objects a single value is preferred, > > > so that this "config=" technically would not be needed, unless this is > > > somewhat essential to the consumers of this attribute to know what the > > > value is?  What do you think? > > > > "config=" is a supported for userspace tool, it is a kind of alias, so > > cannot be remover here, thanks. > > I don't understand this part. This is brand-new functionality for the > kernel, so there's no requirement to maintain compatibility for > existing userspace tools. > > If there's a similar sysfs show function for other perf drivers, and > you need to be compatible with *that*, fine. But if this is merely > about being compatible with userspace that uses out-of-tree kernel > functionality, that's not a real factor. Right, I think this is standard for all perf drivers as it is how the perf tool figures out how to select a given event in the perf_event_attr (which has a 'config' field, which is what this refers to). Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4BAFC48BE5 for ; Wed, 16 Jun 2021 17:29:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8924F60D07 for ; Wed, 16 Jun 2021 17:29:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8924F60D07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8yQjMLKIVb3fiIaect5hzeCVTgov9ifTlXOqHySHUEc=; b=ngWBh8jQlMcPkM Bn8Om6p8qWxfj+OweCEgky7L93IVTc3sxGMvUvn/OKLHRJBslpWBpSGLTnWNBxj+jKIeVcK28qBqV pGiK2RuCqxk3wAPy3AGSFTMxpVBljRYKcKCc46Jzi7hOuQiyOfsiw0XQhuH23RSb7904aFiJC7slX zDDjkzXORo5FLbaoSdNTappCYqo5Il/ddw6EbrYDHdr8wHO5grdDNUXaBBBkD3Sd5CrAvEr18uMue eDneddqcd902cAx33jpbFoBCcqG+NrMlbS13EZtsBXkj2PjxfdOUGqmPh4XvZ/EumjsBqM+tsUuY7 6C2WzaQIfLxoqEubGlFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltZKO-007JPQ-MZ; Wed, 16 Jun 2021 17:27:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltZKL-007JOm-GR for linux-arm-kernel@lists.infradead.org; Wed, 16 Jun 2021 17:27:46 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 73D4160D07; Wed, 16 Jun 2021 17:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623864465; bh=DOHk4jFxa0NKi1FRc0HymIfKoP5GJ5H3EDosFnFv5Js=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gLrPfuXgXvISAFK/Xj3+3dMcYQ5Y+BoJFpphr24AQUF3EzaPFFzeEYNguSozK4i2L IO8wv/q/84ImD66N3hh6pumYPGdcd7PMwFgoE8ti2l1OwM4bTQ/HgYTjukAF5YIIF+ gLxtazSVeY/wcbQoVVllYASxgJlT7HYXAq7FpBARhcovkECI7vhDTUqHs1ZNVl+4t/ D7VYtaxspe5ZwwuYyBkWhks2ojHGEePp0o2nWDlI+ab/zKC7amfUPoLzrL0wgNc8A4 np/EwmWDPlxr6DjaF/KKCMdRAUYNlVmF/H/6gt7I7bnsaS1Dp9cX4yfiN363C0fPrZ bzea0zQym0dEw== Date: Wed, 16 Jun 2021 18:27:39 +0100 From: Will Deacon To: Bjorn Helgaas Cc: "liuqi (BA)" , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Linuxarm , mark.rutland@arm.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, zhangshaokun@hisilicon.com Subject: Re: [PATCH v6 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU Message-ID: <20210616172739.GA23280@willie-the-truck> References: <20210616152343.GA2977964@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210616152343.GA2977964@bjorn-Precision-5520> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210616_102745_607035_AA9EA8B5 X-CRM114-Status: GOOD ( 24.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBKdW4gMTYsIDIwMjEgYXQgMTA6MjM6NDNBTSAtMDUwMCwgQmpvcm4gSGVsZ2FhcyB3 cm90ZToKPiBPbiBXZWQsIEp1biAxNiwgMjAyMSBhdCAwOTowOTo0MEFNICswODAwLCBsaXVxaSAo QkEpIHdyb3RlOgo+ID4gT24gMjAyMS82LzEyIDc6MzMsIEtyenlzenRvZiBXaWxjennFhHNraSB3 cm90ZToKPiAKPiA+ID4gPiArc3RhdGljIHNzaXplX3QgaGlzaV9wY2llX2V2ZW50X3N5c2ZzX3No b3coc3RydWN0IGRldmljZSAqZGV2LAo+ID4gPiA+ICsJCQkJICAgc3RydWN0IGRldmljZV9hdHRy aWJ1dGUgKmF0dHIsIGNoYXIgKmJ1ZikKPiA+ID4gPiArewo+ID4gPiA+ICsJc3RydWN0IGRldl9l eHRfYXR0cmlidXRlICplYXR0cjsKPiA+ID4gPiArCj4gPiA+ID4gKwllYXR0ciA9IGNvbnRhaW5l cl9vZihhdHRyLCBzdHJ1Y3QgZGV2X2V4dF9hdHRyaWJ1dGUsIGF0dHIpOwo+ID4gPiA+ICsKPiA+ ID4gPiArCXJldHVybiBzeXNmc19lbWl0KGJ1ZiwgImNvbmZpZz0weCVseFxuIiwgKHVuc2lnbmVk IGxvbmcpZWF0dHItPnZhcik7Cj4gPiA+ID4gK30KPiA+ID4gCj4gPiA+IEkgYW0gbm90IHRoYXQg ZmFtaWxpYXIgd2l0aCB0aGUgcGVyZiBkcml2ZXJzLCB0aHVzIEkgbWlnaHQgYmUgY29tcGxldGVs eQo+ID4gPiB3cm9uZyBoZXJlLCBidXQgdXN1YWxseSBmb3Igc3lzZnMgb2JqZWN0cyBhIHNpbmds ZSB2YWx1ZSBpcyBwcmVmZXJyZWQsCj4gPiA+IHNvIHRoYXQgdGhpcyAiY29uZmlnPSIgdGVjaG5p Y2FsbHkgd291bGQgbm90IGJlIG5lZWRlZCwgdW5sZXNzIHRoaXMgaXMKPiA+ID4gc29tZXdoYXQg ZXNzZW50aWFsIHRvIHRoZSBjb25zdW1lcnMgb2YgdGhpcyBhdHRyaWJ1dGUgdG8ga25vdyB3aGF0 IHRoZQo+ID4gPiB2YWx1ZSBpcz8gwqBXaGF0IGRvIHlvdSB0aGluaz8KPiA+Cj4gPiAiY29uZmln PSIgaXMgYSBzdXBwb3J0ZWQgZm9yIHVzZXJzcGFjZSB0b29sLCBpdCBpcyBhIGtpbmQgb2YgYWxp YXMsIHNvCj4gPiBjYW5ub3QgYmUgcmVtb3ZlciBoZXJlLCB0aGFua3MuCj4gCj4gSSBkb24ndCB1 bmRlcnN0YW5kIHRoaXMgcGFydC4gIFRoaXMgaXMgYnJhbmQtbmV3IGZ1bmN0aW9uYWxpdHkgZm9y IHRoZQo+IGtlcm5lbCwgc28gdGhlcmUncyBubyByZXF1aXJlbWVudCB0byBtYWludGFpbiBjb21w YXRpYmlsaXR5IGZvcgo+IGV4aXN0aW5nIHVzZXJzcGFjZSB0b29scy4KPiAKPiBJZiB0aGVyZSdz IGEgc2ltaWxhciBzeXNmcyBzaG93IGZ1bmN0aW9uIGZvciBvdGhlciBwZXJmIGRyaXZlcnMsIGFu ZAo+IHlvdSBuZWVkIHRvIGJlIGNvbXBhdGlibGUgd2l0aCAqdGhhdCosIGZpbmUuICBCdXQgaWYg dGhpcyBpcyBtZXJlbHkKPiBhYm91dCBiZWluZyBjb21wYXRpYmxlIHdpdGggdXNlcnNwYWNlIHRo YXQgdXNlcyBvdXQtb2YtdHJlZSBrZXJuZWwKPiBmdW5jdGlvbmFsaXR5LCB0aGF0J3Mgbm90IGEg cmVhbCBmYWN0b3IuCgpSaWdodCwgSSB0aGluayB0aGlzIGlzIHN0YW5kYXJkIGZvciBhbGwgcGVy ZiBkcml2ZXJzIGFzIGl0IGlzIGhvdyB0aGUgcGVyZgp0b29sIGZpZ3VyZXMgb3V0IGhvdyB0byBz ZWxlY3QgYSBnaXZlbiBldmVudCBpbiB0aGUgcGVyZl9ldmVudF9hdHRyICh3aGljaApoYXMgYSAn Y29uZmlnJyBmaWVsZCwgd2hpY2ggaXMgd2hhdCB0aGlzIHJlZmVycyB0bykuCgpXaWxsCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==