From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32A41C48BE6 for ; Wed, 16 Jun 2021 21:12:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0A8A613DF for ; Wed, 16 Jun 2021 21:12:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0A8A613DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B40548060C; Wed, 16 Jun 2021 23:12:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="fMG0cskc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CCA4981E53; Wed, 16 Jun 2021 23:12:20 +0200 (CEST) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2520B8020E for ; Wed, 16 Jun 2021 23:12:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x836.google.com with SMTP id r20so3057264qtp.3 for ; Wed, 16 Jun 2021 14:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Tk6AoGcGZtl4ttHlrGX6ZBt/av+yyZMwDDIHUH3ETdM=; b=fMG0cskcmXxxDkAXotIiQzNhmKihJajOt3/FC2Qa8WoTX4vTwlHJ6tzQiX/3RNMzGH VRtCBMzFR+3qZ+RtuN21vJ2I6bApyrj8bYrpzJub+wBN11ZoUEKq6pQrrd5IxcwdI8W1 xRrl35pqZ4mX7DxFM03DwZ1X+OHKmaQ0dCPEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Tk6AoGcGZtl4ttHlrGX6ZBt/av+yyZMwDDIHUH3ETdM=; b=HaN1kEmzJiUUI0TbGxAPRZrhjRskdKj3GlCQK3L/mBo4oc8HqokDOjWM54Idg4EcdJ Yd0dYoJWkFt2KSEIruOSUgwDQRVuN97gGPxRHZfRQGzFsCwHHDDZX28Hkyv8h2A5ddZ5 mlmSPulc9gddHTQeXB5PLK0TavndXYJ4QebA9G5AB/P/tPjx8cw4lrAMFoJiXXrLew75 ViFuNO7nSJHP6nXlAnHPUXipPIESgXQEu8aDSluq0njLFFVv+4t8AHWivWZ7Yo896Wkh 3jwR2HJUNzI7RpOoFrU41SQ1F1k6aXH9xISfgXdn4RvhT2HqhCZVabjB8VzLzvbSgs99 kbPA== X-Gm-Message-State: AOAM530GwJOzG3a9QGKs6ppjcjEPIGwwbK6R18mIjfEPU0pP+fCIvd5g /ujfAB1q57WNKbUpHnPZ7yYRKQ== X-Google-Smtp-Source: ABdhPJyuRcnbN8CcZanCH8GDciBcPIYqd3942fTYj44SeLQcauJDRX92uXCyiLMWsQpbgtfMAyu8rg== X-Received: by 2002:a05:622a:1183:: with SMTP id m3mr1802021qtk.251.1623877935775; Wed, 16 Jun 2021 14:12:15 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-8009-22e2-67e2-281e.res6.spectrum.com. [2603:6081:7b01:cbda:8009:22e2:67e2:281e]) by smtp.gmail.com with ESMTPSA id y128sm314543qke.113.2021.06.16.14.12.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jun 2021 14:12:15 -0700 (PDT) Date: Wed, 16 Jun 2021 17:12:13 -0400 From: Tom Rini To: Ivaylo Dimitrov Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , maemo-leste@lists.dyne.org, u-boot@lists.denx.de, Merlijn Wajer Subject: Re: [maemo-leste] [PATCH] arm: Remove nokia_rx51 board Message-ID: <20210616211213.GZ9516@bill-the-cat> References: <20210521144418.GI17669@bill-the-cat> <20210521213645.2y5dawkvr6wfaymy@pali> <20210615123436.GH9516@bill-the-cat> <5848e9c9-4dab-00cc-07dc-ffa57b9417cd@gmail.com> <20210616121008.GR9516@bill-the-cat> <20210616121313.GS9516@bill-the-cat> <20210616173702.GW9516@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ksW2gnyJUpgiZE5W" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --ksW2gnyJUpgiZE5W Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 17, 2021 at 12:03:15AM +0300, Ivaylo Dimitrov wrote: > Hi Tom, >=20 > On 16.06.21 =D0=B3. 20:37 =D1=87., Tom Rini wrote: > > On Wed, Jun 16, 2021 at 08:25:28PM +0300, Ivaylo Dimitrov wrote: > > > Hi, > > >=20 > > > On 16.06.21 =D0=B3. 15:13 =D1=87., Tom Rini wrote: > > > > On Wed, Jun 16, 2021 at 08:10:08AM -0400, Tom Rini wrote: > > > > > On Wed, Jun 16, 2021 at 09:02:16AM +0300, Ivaylo Dimitrov wrote: > > > > > > Hi, > > > > > >=20 > > > > > > On 15.06.21 =D0=B3. 15:34 =D1=87., Tom Rini wrote: > > > > > > > On Tue, Jun 15, 2021 at 08:40:30AM +0300, Ivaylo Dimitrov wro= te: > > > > > > > > Hi, > > > > > > > >=20 > > > > > > > > On 22.05.21 =D0=B3. 0:36 =D1=87., Pali Roh=C3=A1r wrote: > > > > > > > > > On Friday 21 May 2021 10:44:18 Tom Rini wrote: > > > > > > > > > > On Wed, May 19, 2021 at 11:52:03AM -0400, Tom Rini wrot= e: > > > > > > > > > > > On Wed, May 19, 2021 at 03:27:48PM +0200, Pali Roh=C3= =A1r wrote: > > > > > > > > > > >=20 > > > > > > > > > > > > On Tuesday 18 May 2021 21:26:40 Tom Rini wrote: > > > > > > > > > > > > > This board has not been converted to CONFIG_DM_US= B by the deadline. > > > > > > > > > > > > > Remove it. > > > > > > > > > > > >=20 > > > > > > > > > > > > I'm very disappointed that you want to remove Nokia= N900 from U-Boot. > > > > > > > > > > > >=20 > > > > > > > > > > > > I was waiting waiting half of year because other de= velopers did not > > > > > > > > > > > > react to issues which were introduced and neither t= o patches which I > > > > > > > > > > > > sent (+ trying to remind open issues). And also I w= as waiting another > > > > > > > > > > > > half of year until other N900 related patches were = merged. So the whole > > > > > > > > > > > > slowdown was not caused by me, why it is taking so = long. > > > > > > > > > > > >=20 > > > > > > > > > > > > Now there is still one N900 DM related patch waitin= g for review. I'm > > > > > > > > > > > > converting code step by step. > > > > > > > > > > > >=20 > > > > > > > > > > > > So the ball is not on my side. > > > > > > > > > > >=20 > > > > > > > > > > > So, what patch(es) need to be applied to get DM_USB e= nabled? Thanks. > > > > > > > > > >=20 > > > > > > > > > > I don't see any open patches from you that look related= to enabling > > > > > > > > > > DM_USB on the platform. If you want to disable USB on = the platform for > > > > > > > > > > now instead, that's fine too. > > > > > > > > >=20 > > > > > > > >=20 > > > > > > > > I tried to migrate the latest master to DM_USB, but unfortu= nately the > > > > > > > > results are pretty much sad - adding OF_CONTROL (which is a= prerequisite to > > > > > > > > have DM_USB IIUC) and OF_BOARD (so binary to be compiled), = adds ~100k to the > > > > > > > > size of the u-boot binary, so it becomes 370284 bytes. Give= n that we have > > > > > > > > less than 256k of storage space for the u-boot, the produce= d binary cannot > > > > > > > > be used on n900 the same way current (no DM_USB) binary is = used. > > > > > > > >=20 > > > > > > > > As I see it, there are not much options left - u-boot on N9= 00 is not SPL, so > > > > > > > > we can't use OF_PLATDATA, which in turn always links libfdt. > > > > > > > > Also, if I read the code (usb-uclass.c) correctly, enabling= DM_USB requires > > > > > > > > the board to be converted to DT and this is way bigger chan= ge. > > > > > > > >=20 > > > > > > > > Please advice on how to proceed. > > > > > > >=20 > > > > > > > Please post your WIP patches, thanks. > > > > > > >=20 > > > > > >=20 > > > > > > Sorry, I am not sure I understand what patches you want me to p= ost: > > > > > >=20 > > > > > > WDT patch has already been sent couple of months ago - > > > > > > https://lists.denx.de/pipermail/u-boot/2021-March/443868.html > > > > > > Do you want it to be rebased and resend? > > > > > >=20 > > > > > > DM_USB, I just started writing one and I immediately hit the OF= _CONTROL > > > > > > requirement. Enabling OF_CONTROL requires a full blown migratio= n to DT, > > > > > > which is a huge task and not really equal to "Please update the= board to use > > > > > > CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failur= es: > > > > > >=20 > > > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gn= ueabi/bin/ld: > > > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gn= ueabi/bin/ld: > > > > > > DWARF error: could not find abbrev number 3998 > > > > > > /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bin= d': > > > > > > :(.text+0x5672): undefined reference to > > > > > > `ofnode_read_u32_default' > > > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gn= ueabi/bin/ld: > > > > > > :(.text+0x568c): undefined reference to > > > > > > `ofnode_read_u32_default' > > > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gn= ueabi/bin/ld: > > > > > > /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device': > > > > > > :(.text+0x6c84): undefined reference to `ofnode_fir= st_subnode' > > > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gn= ueabi/bin/ld: > > > > > > :(.text+0x6c96): undefined reference to `ofnode_rea= d_u32' > > > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gn= ueabi/bin/ld: > > > > > > :(.text+0x6ca4): undefined reference to `ofnode_nex= t_subnode' > > > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gn= ueabi/bin/ld: > > > > > > /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_= usb+0x8): > > > > > > undefined reference to `dm_scan_fdt_dev' > > > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gn= ueabi/bin/ld: > > > > > > /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_= usb_hub+0x8): > > > > > > undefined reference to `dm_scan_fdt_dev' > > > > > >=20 > > > > > > Fixing those requires enabling of OF_CONTROL and this in turn m= eans the > > > > > > board must be migrated to DT, unless I am missing something. Th= at's why my > > > > > > "please advice..." stance. > > > > >=20 > > > > > Please post the patches that bring you to the above link errors, = yes, > > > > > thanks. > > > >=20 > > > > To be clearer, finish up a patch that completes the migration but i= s too > > > > large to install on the hardware so that others can take a look. > > >=20 > > > I am not sure I understand that - a patch that completes the migratio= n to > > > DM_USB cannot be done ATM as the binary does not link without OF_CONT= ROL. > > > And I am not going to enable OF_CONTROL as this means I will have to = migrate > > > everything to DT. That's why I enable DM_USB only - see reply to the = other > > > mail. > >=20 > > My advise is to provide a linkable but not runnable (or, only runnable > > in QEMU, the problem is the fixed layout of the actual device flash, > > right?) patch so that we can figure out how and what needs to be tuned > > where so that we can see what to do about this platform. > >=20 >=20 > What about the following patch (once you confirm I am on the right track,= I > will send a proper patch as well). Enabling thumb is a must, otherwise > binary does not fit. With the below changes code compiles and runs on a r= eal > HW: Wait, why is thumb disabled? That's something I'd really like to know why on as my first guess is there's units with old enough cores that have some thumb errata maybe? For the second part, how are you binding the device? And oh, we didn't disable the EFI loader support already? Yeah, that would be another pretty easy choice to win back a bunch of space. So yes, this is certainly on the right track, thanks! --=20 Tom --ksW2gnyJUpgiZE5W Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDKaSoACgkQFHw5/5Y0 tyyXKgwArfVprCrbegKAAyZ1NqU5oSepbtdceAVv0ANDulc+le0E/jKbNz4CqHzD zcsbiozkrA/WQzad2Nm+TmGqqgXTfSOvALlLPz+gCJF6YXDiEKIYxNZgC9uhCK/A DtIgzzKBXE1bnB593k4qemHk9wdmJUFtxQIXyi8vSNrVy/qzzaFgP6cpJtbOPA2E FOtm/HURdy4Jkzno8AQCWcdJEaOZaj+gz7AjXiHGe9What0Ld+OnyUqDqHtb4xQv enpFcFTOTRcjtJgVu3ZDAwU6kl/bQ62wr/QfqP8Dq4AXTkEuJhgokOgdAWWcmGZO PprmCcCVxngEPlDWo1HSwnlsppKOavfVFYVFAwqCkHsURevg42hLBo9PRaEa/3Px 1QjXcyvjNpeoaPuHO13OP0lhHlZlwD2OZ0K+d9FhQv5gFrtrW4eXKtY5MLcTM4lv fe1jAzkfd7nIpeb+Uo8pRXYoICpdXu/6ldL/ubmINGODYbFmwzJY9SB+6t/WQ298 NbADV78u =5Qse -----END PGP SIGNATURE----- --ksW2gnyJUpgiZE5W--