All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: guaneryu@gmail.com, Chandan Babu R <chandanrlinux@gmail.com>,
	Allison Henderson <allison.henderson@oracle.com>,
	linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me,
	amir73il@gmail.com
Subject: Re: [PATCH 03/13] fstests: refactor test boilerplate code
Date: Wed, 16 Jun 2021 17:02:08 -0700	[thread overview]
Message-ID: <20210617000208.GG158209@locust> (raw)
In-Reply-To: <YMpjZGaR9IKfzGax@sol.localdomain>

On Wed, Jun 16, 2021 at 01:47:32PM -0700, Eric Biggers wrote:
> On Mon, Jun 14, 2021 at 01:59:15PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > Create two new helper functions to deal with boilerplate test code:
> > 
> > A helper function to set the seq and seqnum variables.  We will expand
> > on this in the next patch so that fstests can autogenerate group files
> > from now on.
> > 
> > A helper function to register cleanup code that will run if the test
> > exits or trips over a standard range of signals.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
> > Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> 
> Looks good:
> 
> Reviewed-by: Eric Biggers <ebiggers@google.com>
> 
> A couple nits below:
> 
> > +# Standard cleanup function.  Individual tests should override this.
> > +_cleanup()
> > +{
> > +	cd /
> > +	rm -r -f $tmp.*
> > +}
> 
> It should say "can override this", not "should override this".

Fixed.

> > +# Initialize the global seq, seqres, here, tmp, and status variables to their
> > +# defaults.  Group memberships are the only arguments to this helper.
> > +_begin_fstest()
> > +{
> 
> This function does more than what the comment says.  It should say something
> more along the lines of "Prepare for executing a fstest by initializing some
> global variables, registering a default cleanup function, importing helper
> functions, and removing $seqres.full.  This must be passed the list of groups to
> which the test belongs."

Ok, I'll change that.

# Prepare to run a fstest by initializing the global seq, seqres, here,
# tmp, and status variables to their defaults, importing common
# functions, registering a cleanup function, and removing the
# $seqres.full file.
#
# The list of group memberships for this test (e.g. auto quick rw) must
# be passed as arguments to this helper.  It is not necessary to name
# this test explicitly as a member of the 'all' group.

--D

> 
> - Eric

  reply	other threads:[~2021-06-17  0:02 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 20:58 [PATCHSET v2 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-14 20:59 ` [PATCH 01/13] fstests: fix group check in new script Darrick J. Wong
2021-06-16  5:40   ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 02/13] misc: move exit status into trap handler Darrick J. Wong
2021-06-16  5:41   ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 03/13] fstests: refactor test boilerplate code Darrick J. Wong
2021-06-16  5:42   ` Christoph Hellwig
2021-06-16 20:47   ` Eric Biggers
2021-06-17  0:02     ` Darrick J. Wong [this message]
2021-06-14 20:59 ` [PATCH 04/13] fstests: add tool migrate group membership data to test files Darrick J. Wong
2021-06-16  7:29   ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 05/13] fstests: move test group info " Darrick J. Wong
2021-06-16 20:53   ` Eric Biggers
2021-06-14 20:59 ` [PATCH 06/13] fstests: clean up open-coded golden output Darrick J. Wong
2021-06-16  5:45   ` Christoph Hellwig
2021-06-17  0:06     ` Darrick J. Wong
2021-06-14 20:59 ` [PATCH 07/13] fstests: automatically generate group files Darrick J. Wong
2021-06-16  7:32   ` Christoph Hellwig
2021-06-17  0:13     ` Darrick J. Wong
2021-06-17  7:56       ` Christoph Hellwig
2021-06-17 17:15         ` Darrick J. Wong
2021-06-18 13:45           ` Christoph Hellwig
2021-06-18 15:32             ` Amir Goldstein
2021-06-18 15:56               ` Darrick J. Wong
2021-06-21  5:25                 ` Christoph Hellwig
2021-06-21  6:38                   ` Eryu Guan
2021-06-21 16:14                     ` Darrick J. Wong
2021-06-21  5:20               ` Christoph Hellwig
2021-06-14 20:59 ` [PATCH 08/13] fstests: convert nextid to use automatic group generation Darrick J. Wong
2021-06-16 20:54   ` Eric Biggers
2021-06-14 20:59 ` [PATCH 09/13] fstests: adapt the new test script to our new group tagging scheme Darrick J. Wong
2021-06-14 20:59 ` [PATCH 10/13] check: use generated group files Darrick J. Wong
2021-06-16 20:55   ` Eric Biggers
2021-06-14 20:59 ` [PATCH 11/13] fstests: remove " Darrick J. Wong
2021-06-16 20:56   ` Eric Biggers
2021-06-14 21:00 ` [PATCH 12/13] fstests: remove test group management code Darrick J. Wong
2021-06-16 20:58   ` Eric Biggers
2021-06-17  0:08     ` Darrick J. Wong
2021-06-14 21:00 ` [PATCH 13/13] misc: update documentation to reflect auto-generated group files Darrick J. Wong
2021-06-16 21:00   ` Eric Biggers
2021-06-17  0:11     ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2021-06-21 23:10 [PATCHSET v3 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-21 23:10 ` [PATCH 03/13] fstests: refactor test boilerplate code Darrick J. Wong
2021-06-08 17:19 [PATCHSET v1 00/13] fstests: move test group lists into test files Darrick J. Wong
2021-06-08 17:19 ` [PATCH 03/13] fstests: refactor test boilerplate code Darrick J. Wong
2021-06-10  8:44   ` Chandan Babu R
2021-06-11 21:55   ` Allison Henderson
2021-06-12  0:08   ` Eric Biggers
2021-06-12  0:34     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210617000208.GG158209@locust \
    --to=djwong@kernel.org \
    --cc=allison.henderson@oracle.com \
    --cc=amir73il@gmail.com \
    --cc=chandanrlinux@gmail.com \
    --cc=ebiggers@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    --subject='Re: [PATCH 03/13] fstests: refactor test boilerplate code' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.