All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drm/amd/display: remove unused variable 'dc'
@ 2021-06-17  1:16 ` Pu Lehui
  0 siblings, 0 replies; 9+ messages in thread
From: Pu Lehui @ 2021-06-17  1:16 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	Xinhui.Pan, airlied, daniel, Anson.Jacob, Nicholas.Kazlauskas,
	roman.li
  Cc: amd-gfx, dri-devel, linux-kernel, pulehui, zhangjinhao2

GCC reports the following warning with W=1:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
warning:
 variable ‘dc’ set but not used [-Wunused-but-set-variable]
    70 |  struct dc *dc = NULL;
       |             ^~

This variable is not used in function, this commit remove it to
fix the warning.

Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
index f7c77ae0d965..70a554f1e725 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
@@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
 	struct dc_link *link = NULL;
 	struct psr_config psr_config = {0};
 	struct psr_context psr_context = {0};
-	struct dc *dc = NULL;
 	bool ret = false;
 
 	if (stream == NULL)
 		return false;
 
 	link = stream->link;
-	dc = link->ctx->dc;
 
 	psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH -next] drm/amd/display: remove unused variable 'dc'
@ 2021-06-17  1:16 ` Pu Lehui
  0 siblings, 0 replies; 9+ messages in thread
From: Pu Lehui @ 2021-06-17  1:16 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	Xinhui.Pan, airlied, daniel, Anson.Jacob, Nicholas.Kazlauskas,
	roman.li
  Cc: zhangjinhao2, pulehui, dri-devel, amd-gfx, linux-kernel

GCC reports the following warning with W=1:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
warning:
 variable ‘dc’ set but not used [-Wunused-but-set-variable]
    70 |  struct dc *dc = NULL;
       |             ^~

This variable is not used in function, this commit remove it to
fix the warning.

Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
index f7c77ae0d965..70a554f1e725 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
@@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
 	struct dc_link *link = NULL;
 	struct psr_config psr_config = {0};
 	struct psr_context psr_context = {0};
-	struct dc *dc = NULL;
 	bool ret = false;
 
 	if (stream == NULL)
 		return false;
 
 	link = stream->link;
-	dc = link->ctx->dc;
 
 	psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH -next] drm/amd/display: remove unused variable 'dc'
@ 2021-06-17  1:16 ` Pu Lehui
  0 siblings, 0 replies; 9+ messages in thread
From: Pu Lehui @ 2021-06-17  1:16 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	Xinhui.Pan, airlied, daniel, Anson.Jacob, Nicholas.Kazlauskas,
	roman.li
  Cc: zhangjinhao2, pulehui, dri-devel, amd-gfx, linux-kernel

GCC reports the following warning with W=1:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
warning:
 variable ‘dc’ set but not used [-Wunused-but-set-variable]
    70 |  struct dc *dc = NULL;
       |             ^~

This variable is not used in function, this commit remove it to
fix the warning.

Signed-off-by: Pu Lehui <pulehui@huawei.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
index f7c77ae0d965..70a554f1e725 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
@@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
 	struct dc_link *link = NULL;
 	struct psr_config psr_config = {0};
 	struct psr_context psr_context = {0};
-	struct dc *dc = NULL;
 	bool ret = false;
 
 	if (stream == NULL)
 		return false;
 
 	link = stream->link;
-	dc = link->ctx->dc;
 
 	psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
 
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'
  2021-06-17  1:16 ` Pu Lehui
  (?)
@ 2021-06-17 19:04   ` Harry Wentland
  -1 siblings, 0 replies; 9+ messages in thread
From: Harry Wentland @ 2021-06-17 19:04 UTC (permalink / raw)
  To: Pu Lehui, sunpeng.li, alexander.deucher, christian.koenig,
	Xinhui.Pan, airlied, daniel, Anson.Jacob, Nicholas.Kazlauskas,
	roman.li
  Cc: amd-gfx, dri-devel, linux-kernel, zhangjinhao2



On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> GCC reports the following warning with W=1:
> 
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> warning:
>  variable ‘dc’ set but not used [-Wunused-but-set-variable]
>     70 |  struct dc *dc = NULL;
>        |             ^~
> 
> This variable is not used in function, this commit remove it to
> fix the warning.
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> index f7c77ae0d965..70a554f1e725 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
>  	struct dc_link *link = NULL;
>  	struct psr_config psr_config = {0};
>  	struct psr_context psr_context = {0};
> -	struct dc *dc = NULL;
>  	bool ret = false;
>  
>  	if (stream == NULL)
>  		return false;
>  
>  	link = stream->link;
> -	dc = link->ctx->dc;
>  
>  	psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
>  
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'
@ 2021-06-17 19:04   ` Harry Wentland
  0 siblings, 0 replies; 9+ messages in thread
From: Harry Wentland @ 2021-06-17 19:04 UTC (permalink / raw)
  To: Pu Lehui, sunpeng.li, alexander.deucher, christian.koenig,
	Xinhui.Pan, airlied, daniel, Anson.Jacob, Nicholas.Kazlauskas,
	roman.li
  Cc: zhangjinhao2, dri-devel, amd-gfx, linux-kernel



On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> GCC reports the following warning with W=1:
> 
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> warning:
>  variable ‘dc’ set but not used [-Wunused-but-set-variable]
>     70 |  struct dc *dc = NULL;
>        |             ^~
> 
> This variable is not used in function, this commit remove it to
> fix the warning.
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> index f7c77ae0d965..70a554f1e725 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
>  	struct dc_link *link = NULL;
>  	struct psr_config psr_config = {0};
>  	struct psr_context psr_context = {0};
> -	struct dc *dc = NULL;
>  	bool ret = false;
>  
>  	if (stream == NULL)
>  		return false;
>  
>  	link = stream->link;
> -	dc = link->ctx->dc;
>  
>  	psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
>  
> 


^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'
@ 2021-06-17 19:04   ` Harry Wentland
  0 siblings, 0 replies; 9+ messages in thread
From: Harry Wentland @ 2021-06-17 19:04 UTC (permalink / raw)
  To: Pu Lehui, sunpeng.li, alexander.deucher, christian.koenig,
	Xinhui.Pan, airlied, daniel, Anson.Jacob, Nicholas.Kazlauskas,
	roman.li
  Cc: zhangjinhao2, dri-devel, amd-gfx, linux-kernel



On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> GCC reports the following warning with W=1:
> 
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> warning:
>  variable ‘dc’ set but not used [-Wunused-but-set-variable]
>     70 |  struct dc *dc = NULL;
>        |             ^~
> 
> This variable is not used in function, this commit remove it to
> fix the warning.
> 
> Signed-off-by: Pu Lehui <pulehui@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> index f7c77ae0d965..70a554f1e725 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
>  	struct dc_link *link = NULL;
>  	struct psr_config psr_config = {0};
>  	struct psr_context psr_context = {0};
> -	struct dc *dc = NULL;
>  	bool ret = false;
>  
>  	if (stream == NULL)
>  		return false;
>  
>  	link = stream->link;
> -	dc = link->ctx->dc;
>  
>  	psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
>  
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'
  2021-06-17 19:04   ` Harry Wentland
  (?)
@ 2021-06-18 20:34     ` Alex Deucher
  -1 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-06-18 20:34 UTC (permalink / raw)
  To: Harry Wentland
  Cc: Pu Lehui, Leo (Sunpeng) Li, Deucher, Alexander, Christian Koenig,
	xinhui pan, Dave Airlie, Daniel Vetter, Anson Jacob, Kazlauskas,
	Nicholas, Roman Li, zhangjinhao2, Maling list - DRI developers,
	amd-gfx list, LKML

Applied.  Thanks!

On Thu, Jun 17, 2021 at 3:04 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
>
>
> On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> > GCC reports the following warning with W=1:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> > warning:
> >  variable ‘dc’ set but not used [-Wunused-but-set-variable]
> >     70 |  struct dc *dc = NULL;
> >        |             ^~
> >
> > This variable is not used in function, this commit remove it to
> > fix the warning.
> >
> > Signed-off-by: Pu Lehui <pulehui@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > index f7c77ae0d965..70a554f1e725 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
> >       struct dc_link *link = NULL;
> >       struct psr_config psr_config = {0};
> >       struct psr_context psr_context = {0};
> > -     struct dc *dc = NULL;
> >       bool ret = false;
> >
> >       if (stream == NULL)
> >               return false;
> >
> >       link = stream->link;
> > -     dc = link->ctx->dc;
> >
> >       psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
> >
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'
@ 2021-06-18 20:34     ` Alex Deucher
  0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-06-18 20:34 UTC (permalink / raw)
  To: Harry Wentland
  Cc: Anson Jacob, Leo (Sunpeng) Li, LKML, xinhui pan, Roman Li,
	Maling list - DRI developers, Kazlauskas, Nicholas, zhangjinhao2,
	Dave Airlie, amd-gfx list, Pu Lehui, Deucher, Alexander,
	Christian Koenig

Applied.  Thanks!

On Thu, Jun 17, 2021 at 3:04 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
>
>
> On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> > GCC reports the following warning with W=1:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> > warning:
> >  variable ‘dc’ set but not used [-Wunused-but-set-variable]
> >     70 |  struct dc *dc = NULL;
> >        |             ^~
> >
> > This variable is not used in function, this commit remove it to
> > fix the warning.
> >
> > Signed-off-by: Pu Lehui <pulehui@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > index f7c77ae0d965..70a554f1e725 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
> >       struct dc_link *link = NULL;
> >       struct psr_config psr_config = {0};
> >       struct psr_context psr_context = {0};
> > -     struct dc *dc = NULL;
> >       bool ret = false;
> >
> >       if (stream == NULL)
> >               return false;
> >
> >       link = stream->link;
> > -     dc = link->ctx->dc;
> >
> >       psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
> >
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/amd/display: remove unused variable 'dc'
@ 2021-06-18 20:34     ` Alex Deucher
  0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-06-18 20:34 UTC (permalink / raw)
  To: Harry Wentland
  Cc: Anson Jacob, Daniel Vetter, Leo (Sunpeng) Li, LKML, xinhui pan,
	Roman Li, Maling list - DRI developers, Kazlauskas, Nicholas,
	zhangjinhao2, Dave Airlie, amd-gfx list, Pu Lehui, Deucher,
	Alexander, Christian Koenig

Applied.  Thanks!

On Thu, Jun 17, 2021 at 3:04 PM Harry Wentland <harry.wentland@amd.com> wrote:
>
>
>
> On 2021-06-16 9:16 p.m., Pu Lehui wrote:
> > GCC reports the following warning with W=1:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_psr.c:70:13:
> > warning:
> >  variable ‘dc’ set but not used [-Wunused-but-set-variable]
> >     70 |  struct dc *dc = NULL;
> >        |             ^~
> >
> > This variable is not used in function, this commit remove it to
> > fix the warning.
> >
> > Signed-off-by: Pu Lehui <pulehui@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > index f7c77ae0d965..70a554f1e725 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> > @@ -67,14 +67,12 @@ bool amdgpu_dm_link_setup_psr(struct dc_stream_state *stream)
> >       struct dc_link *link = NULL;
> >       struct psr_config psr_config = {0};
> >       struct psr_context psr_context = {0};
> > -     struct dc *dc = NULL;
> >       bool ret = false;
> >
> >       if (stream == NULL)
> >               return false;
> >
> >       link = stream->link;
> > -     dc = link->ctx->dc;
> >
> >       psr_config.psr_version = link->dpcd_caps.psr_caps.psr_version;
> >
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-06-18 20:35 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17  1:16 [PATCH -next] drm/amd/display: remove unused variable 'dc' Pu Lehui
2021-06-17  1:16 ` Pu Lehui
2021-06-17  1:16 ` Pu Lehui
2021-06-17 19:04 ` Harry Wentland
2021-06-17 19:04   ` Harry Wentland
2021-06-17 19:04   ` Harry Wentland
2021-06-18 20:34   ` Alex Deucher
2021-06-18 20:34     ` Alex Deucher
2021-06-18 20:34     ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.