From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 3/3] controllers/memcg: accept non-zero max_usage_in_bytes after reset
Date: Thu, 17 Jun 2021 09:07:30 +0200 [thread overview]
Message-ID: <20210617070730.7699-4-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210617070730.7699-1-krzysztof.kozlowski@canonical.com>
Several Linux kernel versions report a non-zero max_usage_in_bytes after
resetting the counter. For example v5.4, v5.8, v5.10, v5.11, v5.12 and
5.13.0-rc5:
memcg_max_usage_in_bytes_test 4 TINFO: Test reset memory.memsw.max_usage_in_bytes
memcg_max_usage_in_bytes_test 4 TINFO: Running memcg_process --mmap-anon -s 4194304
memcg_max_usage_in_bytes_test 4 TINFO: Warming up pid: 1416
memcg_max_usage_in_bytes_test 4 TINFO: Process is still here after warm up: 1416
memcg_max_usage_in_bytes_test 4 TFAIL: memory.memsw.max_usage_in_bytes is 4325376, 4194304 expected
memcg_max_usage_in_bytes_test 4 TFAIL: memory.memsw.max_usage_in_bytes is 122880, 0 expected
It seems that recent Linux kernel still notices some memory allocation
by the memcg tool. Accept therefore a range from 0 to 32 pages.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
.../memcg/functional/memcg_max_usage_in_bytes_test.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/controllers/memcg/functional/memcg_max_usage_in_bytes_test.sh b/testcases/kernel/controllers/memcg/functional/memcg_max_usage_in_bytes_test.sh
index a940606cbd34..8f0fc33996f3 100755
--- a/testcases/kernel/controllers/memcg/functional/memcg_max_usage_in_bytes_test.sh
+++ b/testcases/kernel/controllers/memcg/functional/memcg_max_usage_in_bytes_test.sh
@@ -40,7 +40,11 @@ test_max_usage_in_bytes()
if [ $check_after_reset -eq 1 ]; then
echo 0 > $item
- check_mem_stat $item 0
+ # Recent Linux kernels (at least v5.4) started reporting
+ # a non-zero max_usage_in_bytes after resetting the counter.
+ # The typical values are 0, 4096, 8096 and up to 122880.
+ # Cause is not known, so let's just be flexible.
+ check_mem_stat $item 0 $((PAGESIZE * 32))
fi
stop_memcg_process
--
2.27.0
next prev parent reply other threads:[~2021-06-17 7:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 7:07 [LTP] [PATCH v2 0/3] controllers/memcg: fixes for newer kernels Krzysztof Kozlowski
2021-06-17 7:07 ` [LTP] [PATCH v2 1/3] controllers/memcg: accept range of max_usage_in_bytes Krzysztof Kozlowski
2021-06-17 7:07 ` [LTP] [PATCH v2 2/3] controllers/memcg: accept range of usage_in_bytes Krzysztof Kozlowski
2021-06-17 7:07 ` Krzysztof Kozlowski [this message]
2021-06-17 7:32 ` [LTP] [PATCH v2 0/3] controllers/memcg: fixes for newer kernels Richard Palethorpe
2021-06-24 19:31 ` Krzysztof Kozlowski
2021-06-25 8:21 ` Li Wang
2021-06-25 9:13 ` Krzysztof Kozlowski
2021-06-25 9:24 ` Joerg Vehlow
2021-06-25 11:55 ` Krzysztof Kozlowski
2021-07-02 10:49 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617070730.7699-4-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.