From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0052360046293681832==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] memory: tegra: fix debugfs_simple_attr.cocci warnings Date: Thu, 17 Jun 2021 17:58:58 +0800 Message-ID: <20210617095858.GA45126@d641290d9800> In-Reply-To: <202106171758.yqVPuduD-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============0052360046293681832== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: Linux Memory Management List TO: Dmitry Osipenko CC: Thierry Reding CC: Krzysztof Kozlowski CC: Jonathan Hunter CC: Viresh Kumar CC: Chanwoo Choi CC: linux-kernel(a)vger.kernel.org CC: linux-tegra(a)vger.kernel.org From: kernel test robot drivers/memory/tegra/tegra20-emc.c:744:0-23: WARNING: tegra_emc_debug_max_r= ate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE drivers/memory/tegra/tegra20-emc.c:714:0-23: WARNING: tegra_emc_debug_min_r= ate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci Fixes: 56ebc9b0d77e ("memory: tegra: Enable compile testing for all drivers= ") CC: Dmitry Osipenko Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git= master head: c7d4c1fd91ab4a6d2620497921a9c6bf54650ab8 commit: 56ebc9b0d77e0406aba2d900c82e79204cc7dc32 [6065/10489] memory: tegra= : Enable compile testing for all drivers :::::: branch date: 21 hours ago :::::: commit date: 2 weeks ago Please take the patch only if it's a positive warning. Thanks! tegra20-emc.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) --- a/drivers/memory/tegra/tegra20-emc.c +++ b/drivers/memory/tegra/tegra20-emc.c @@ -711,9 +711,9 @@ static int tegra_emc_debug_min_rate_set( return 0; } = -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_min_rate_fops, - tegra_emc_debug_min_rate_get, - tegra_emc_debug_min_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_min_rate_fops, + tegra_emc_debug_min_rate_get, + tegra_emc_debug_min_rate_set, "%llu\n"); = static int tegra_emc_debug_max_rate_get(void *data, u64 *rate) { @@ -741,9 +741,9 @@ static int tegra_emc_debug_max_rate_set( return 0; } = -DEFINE_SIMPLE_ATTRIBUTE(tegra_emc_debug_max_rate_fops, - tegra_emc_debug_max_rate_get, - tegra_emc_debug_max_rate_set, "%llu\n"); +DEFINE_DEBUGFS_ATTRIBUTE(tegra_emc_debug_max_rate_fops, + tegra_emc_debug_max_rate_get, + tegra_emc_debug_max_rate_set, "%llu\n"); = static void tegra_emc_debugfs_init(struct tegra_emc *emc) { @@ -783,10 +783,10 @@ static void tegra_emc_debugfs_init(struc = debugfs_create_file("available_rates", 0444, emc->debugfs.root, emc, &tegra_emc_debug_available_rates_fops); - debugfs_create_file("min_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_min_rate_fops); - debugfs_create_file("max_rate", 0644, emc->debugfs.root, - emc, &tegra_emc_debug_max_rate_fops); + debugfs_create_file_unsafe("min_rate", 0644, emc->debugfs.root, emc, + &tegra_emc_debug_min_rate_fops); + debugfs_create_file_unsafe("max_rate", 0644, emc->debugfs.root, emc, + &tegra_emc_debug_max_rate_fops); } = static inline struct tegra_emc * --===============0052360046293681832==--