From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 718E7C2B9F4 for ; Thu, 17 Jun 2021 11:35:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5234261403 for ; Thu, 17 Jun 2021 11:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232583AbhFQLha (ORCPT ); Thu, 17 Jun 2021 07:37:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231695AbhFQLh1 (ORCPT ); Thu, 17 Jun 2021 07:37:27 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42A68C061574; Thu, 17 Jun 2021 04:35:19 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id g142so2726433qke.4; Thu, 17 Jun 2021 04:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=8tErQQGqVARuWTPJ1UZnyWbISdS7OqCTl4R1CLBW1Bw=; b=rZOgBxNZ5BtwSpmkYY+as1qvp1TbrqJ0z57PQkLfw1swif02hqM2t3ddSmm12goxP7 5rzGLL3ijB2rNQ7d9tJ+AiQUj31PuPwM/ILmpA3dNUvBsZ8ZnCVXG4H8mDNusWZPWvkZ 1jW/4PmJM6x9UxKd9H4usq7jqu+TBfv80XZpAdhwKT03+93nKzte+SIxS+msrftT0d+h EeIlZCBo9wP3Mn1y9LzgjQF2n9ptqbMem6VXoN1WnqYnHzC90MRLI2nRHisW0eOkRSAU 2BzaogoZcyOXoBsMDx9NEck5auNah20J2Nu59lPcoUA78T0XKszLlMvLnd4LslXqxP0D gSoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=8tErQQGqVARuWTPJ1UZnyWbISdS7OqCTl4R1CLBW1Bw=; b=QBwgVOfec2daXiustEpbOijx6rbO3uFgj7n6OCJ4sC5AH57SXM6uGVpoghD+7oBsv7 kMrNuTz8/KDHh7PFSUwWM1FVrU9mj8aoFxMVUGdcA/01/irT3rxyIuh2kwA2sGrUOITG 1CTm9vMhkoV4nFKoF1PbLGjCo46zpR/PV/SKc4DLtQKOSnPG5mrAVqV/onVODYEBzCVZ hbA6HI7UDXvcLhoJ2v8i/SSR8cyDDPpMUSyRFOLIvbJaM2qdukkczqbAc2s8A8doawcm khXBS1ow86pecSw+g04ZdJvseTKNlilO6ybJyd/JLnH2/Z6ehU53vZbc8uZotgXidix6 aE1A== X-Gm-Message-State: AOAM530BwjDnkPMhjtLL/RIN5TbYRqp93mYqvBFHDXWavVf1sexSK8W9 TRAv0QJfB3yOO65UbGwqaVQ= X-Google-Smtp-Source: ABdhPJwvYMe52BcZr+JE8BaqGbvb1iv78gnjVOMlpQLdxJauIyJdXY4BjI+L07ic566Orq7pHwZFMQ== X-Received: by 2002:a05:620a:140c:: with SMTP id d12mr3277055qkj.228.1623929718452; Thu, 17 Jun 2021 04:35:18 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id t30sm1489260qkm.11.2021.06.17.04.35.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 04:35:17 -0700 (PDT) From: SeongJae Park X-Google-Original-From: SeongJae Park To: "Boehme, Markus" Cc: "sj38.park@gmail.com" , "akpm@linux-foundation.org" , "Foerster, Leonard" , "guoju.fgj@alibaba-inc.com" , "brendanhiggins@google.com" , "riel@surriel.com" , "greg@kroah.com" , "linux-damon@amazon.com" , "david@redhat.com" , "rientjes@google.com" , "Heyne, Maximilian" , "peterz@infradead.org" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "Gowans, James" , "Park, Seongjae" , "snu@zelle79.org" , "Woodhouse, David" , "Jonathan.Cameron@Huawei.com" , "Sieber, Fernand" , "namhyung@kernel.org" , "rppt@kernel.org" , "shuah@kernel.org" , "vbabka@suse.cz" , "zgf574564920@gmail.com" , "mgorman@suse.de" , "amit@kernel.org" , "fan.du@intel.com" , "minchan@kernel.org" , "rostedt@goodmis.org" , "acme@kernel.org" , "mingo@redhat.com" , "alexander.shishkin@linux.intel.com" , "gthelen@google.com" , "shakeelb@google.com" , "elver@google.com" , "vdavydov.dev@gmail.com" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v30 12/13] mm/damon: Add user space selftests Date: Thu, 17 Jun 2021 11:35:04 +0000 Message-Id: <20210617113504.5525-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <1ad122038f283961b787b26bb838a063ff7c43cf.camel@amazon.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: SeongJae Park Hello Markus, On Thu, 17 Jun 2021 11:29:41 +0000 "Boehme, Markus" wrote: > On Thu, 2021-06-17 at 11:28 +0000, Boehme, Markus wrote: > > On Wed, 2021-06-16 at 07:31 +0000, SeongJae Park wrote: > > > From: SeongJae Park > > > > > > This commit adds a simple user space tests for DAMON. The tests > > > are > > > using kselftest framework. > > > > > > Signed-off-by: SeongJae Park > > > --- > > > tools/testing/selftests/damon/Makefile | 7 ++ > > > .../selftests/damon/_chk_dependency.sh | 28 +++++++ > > > .../testing/selftests/damon/debugfs_attrs.sh | 75 > > > +++++++++++++++++++ > > > 3 files changed, 110 insertions(+) > > > create mode 100644 tools/testing/selftests/damon/Makefile > > > create mode 100644 > > > tools/testing/selftests/damon/_chk_dependency.sh > > > create mode 100755 tools/testing/selftests/damon/debugfs_attrs.sh > > > > > > [...] > > > diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh > > > b/tools/testing/selftests/damon/debugfs_attrs.sh > > > new file mode 100755 > > > index 000000000000..60342d6c86d8 > > > --- /dev/null > > > +++ b/tools/testing/selftests/damon/debugfs_attrs.sh [...] > > > + > > > +test_content() { > > > + file=$1 > > > + orig_content=$2 > > > + expected=$3 > > > + expect_reason=$4 > > > + > > > + content=$(cat "$file") > > > + if [ "$content" != "$content" ] > > > > That'll always evaluate false and should compare against "expected" > > instead. Good catch, I will fix so in the next spin. > > > > Feel free to add Reviewed-by: Markus Boehme when > this is fixed. Thank you! > > > > + then > > > + echo "reading $file expected $expected but $content" > > > + echo "expected because: $expect_reason" > > > + echo "$orig_content" > "$file" > > > + exit 1 > > > + fi > > > +} Thanks, SeongJae Park [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D3CC2B9F4 for ; Thu, 17 Jun 2021 11:35:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8DBF361403 for ; Thu, 17 Jun 2021 11:35:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DBF361403 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2C7136B0070; Thu, 17 Jun 2021 07:35:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29D496B0071; Thu, 17 Jun 2021 07:35:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13EBC6B0072; Thu, 17 Jun 2021 07:35:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id D9A576B0070 for ; Thu, 17 Jun 2021 07:35:19 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5D518181AC544 for ; Thu, 17 Jun 2021 11:35:19 +0000 (UTC) X-FDA: 78263009958.31.B5CD190 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf06.hostedemail.com (Postfix) with ESMTP id 857A0C0091AE for ; Thu, 17 Jun 2021 11:35:08 +0000 (UTC) Received: by mail-qk1-f179.google.com with SMTP id 5so2710110qkc.8 for ; Thu, 17 Jun 2021 04:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=8tErQQGqVARuWTPJ1UZnyWbISdS7OqCTl4R1CLBW1Bw=; b=rZOgBxNZ5BtwSpmkYY+as1qvp1TbrqJ0z57PQkLfw1swif02hqM2t3ddSmm12goxP7 5rzGLL3ijB2rNQ7d9tJ+AiQUj31PuPwM/ILmpA3dNUvBsZ8ZnCVXG4H8mDNusWZPWvkZ 1jW/4PmJM6x9UxKd9H4usq7jqu+TBfv80XZpAdhwKT03+93nKzte+SIxS+msrftT0d+h EeIlZCBo9wP3Mn1y9LzgjQF2n9ptqbMem6VXoN1WnqYnHzC90MRLI2nRHisW0eOkRSAU 2BzaogoZcyOXoBsMDx9NEck5auNah20J2Nu59lPcoUA78T0XKszLlMvLnd4LslXqxP0D gSoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=8tErQQGqVARuWTPJ1UZnyWbISdS7OqCTl4R1CLBW1Bw=; b=Q4s3PGw9bywt3X2ds9+DIDkjOjvVabZDd+GoqbAGC2LYNtypGxZcD07CNQBzRXbCfb xbIV909P62IqpDUKDKAdP8rKf3O4EUGgLsZg+WH06AChLU26M2Z9hDQyEeF2F01ym/r+ JmhgPgxUdwpLeFhUQSI5qQy9RNcrtzHZgVjsFRuLuQJufHVJ1o6ZizHcsjV+8lLQoMff lPyhh7Z+PL5W5ETCDFbfym5JHcmDfnjGpDvxNhT1IRSOmkSky6JgL3+Z66aOOJ1UBePj OzMqb2ZhtQj2IvoutX3UPGYkZHX1e667mTDxvNXMf/q0Ueae+Uasmsxs2iaaYS7jvpin 7NuA== X-Gm-Message-State: AOAM5330dntyEI9RY/PLqAvTwU9q5ka9Y2jRsNBdAgrjz2rXj0fOKXxd atrF//7osm+cpU2k90stf0I= X-Google-Smtp-Source: ABdhPJwvYMe52BcZr+JE8BaqGbvb1iv78gnjVOMlpQLdxJauIyJdXY4BjI+L07ic566Orq7pHwZFMQ== X-Received: by 2002:a05:620a:140c:: with SMTP id d12mr3277055qkj.228.1623929718452; Thu, 17 Jun 2021 04:35:18 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id t30sm1489260qkm.11.2021.06.17.04.35.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jun 2021 04:35:17 -0700 (PDT) From: SeongJae Park X-Google-Original-From: SeongJae Park To: "Boehme, Markus" Cc: "sj38.park@gmail.com" , "akpm@linux-foundation.org" , "Foerster, Leonard" , "guoju.fgj@alibaba-inc.com" , "brendanhiggins@google.com" , "riel@surriel.com" , "greg@kroah.com" , "linux-damon@amazon.com" , "david@redhat.com" , "rientjes@google.com" , "Heyne, Maximilian" , "peterz@infradead.org" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "Gowans, James" , "Park, Seongjae" , "snu@zelle79.org" , "Woodhouse, David" , "Jonathan.Cameron@Huawei.com" , "Sieber, Fernand" , "namhyung@kernel.org" , "rppt@kernel.org" , "shuah@kernel.org" , "vbabka@suse.cz" , "zgf574564920@gmail.com" , "mgorman@suse.de" , "amit@kernel.org" , "fan.du@intel.com" , "minchan@kernel.org" , "rostedt@goodmis.org" , "acme@kernel.org" , "mingo@redhat.com" , "alexander.shishkin@linux.intel.com" , "gthelen@google.com" , "shakeelb@google.com" , "elver@google.com" , "vdavydov.dev@gmail.com" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v30 12/13] mm/damon: Add user space selftests Date: Thu, 17 Jun 2021 11:35:04 +0000 Message-Id: <20210617113504.5525-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <1ad122038f283961b787b26bb838a063ff7c43cf.camel@amazon.de> Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=rZOgBxNZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of sj38park@gmail.com designates 209.85.222.179 as permitted sender) smtp.mailfrom=sj38park@gmail.com X-Stat-Signature: kmwmh8ifkixf693ktuh17mk54xaf53h1 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 857A0C0091AE X-HE-Tag: 1623929708-297083 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park Hello Markus, On Thu, 17 Jun 2021 11:29:41 +0000 "Boehme, Markus" wrote: > On Thu, 2021-06-17 at 11:28 +0000, Boehme, Markus wrote: > > On Wed, 2021-06-16 at 07:31 +0000, SeongJae Park wrote: > > > From: SeongJae Park > > > > > > This commit adds a simple user space tests for DAMON. The tests > > > are > > > using kselftest framework. > > > > > > Signed-off-by: SeongJae Park > > > --- > > > tools/testing/selftests/damon/Makefile | 7 ++ > > > .../selftests/damon/_chk_dependency.sh | 28 +++++++ > > > .../testing/selftests/damon/debugfs_attrs.sh | 75 > > > +++++++++++++++++++ > > > 3 files changed, 110 insertions(+) > > > create mode 100644 tools/testing/selftests/damon/Makefile > > > create mode 100644 > > > tools/testing/selftests/damon/_chk_dependency.sh > > > create mode 100755 tools/testing/selftests/damon/debugfs_attrs.sh > > > > > > [...] > > > diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh > > > b/tools/testing/selftests/damon/debugfs_attrs.sh > > > new file mode 100755 > > > index 000000000000..60342d6c86d8 > > > --- /dev/null > > > +++ b/tools/testing/selftests/damon/debugfs_attrs.sh [...] > > > + > > > +test_content() { > > > + file=$1 > > > + orig_content=$2 > > > + expected=$3 > > > + expect_reason=$4 > > > + > > > + content=$(cat "$file") > > > + if [ "$content" != "$content" ] > > > > That'll always evaluate false and should compare against "expected" > > instead. Good catch, I will fix so in the next spin. > > > > Feel free to add Reviewed-by: Markus Boehme when > this is fixed. Thank you! > > > > + then > > > + echo "reading $file expected $expected but $content" > > > + echo "expected because: $expect_reason" > > > + echo "$orig_content" > "$file" > > > + exit 1 > > > + fi > > > +} Thanks, SeongJae Park [...]