All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Pooja Trivedi <pooja.trivedi@stackpath.com>,
	Mallesham Jatharkonda <mallesham.jatharkonda@oneconvergence.com>,
	Josh Tway <josh.tway@stackpath.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: Hangs during tls multi_chunk_sendfile selftest
Date: Thu, 17 Jun 2021 14:22:34 -0700	[thread overview]
Message-ID: <20210617142234.272cc686@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <YMumgy19CXCk5rZD@ubuntu-x1>

On Thu, 17 Jun 2021 14:46:11 -0500 Seth Forshee wrote:
> I've observed that the tls multi_chunk_sendfile selftest hangs during
> recv() and ultimately times out, and it seems to have done so even when
> the test was first introduced. 

It hangs yet it passes? I lost track of this issue because the test
does pass on my system:

# PASSED: 183 / 183 tests passed.
# Totals: pass:183 fail:0 xfail:0 xpass:0 skip:0 error:0

$ uname -r
5.12.9-300.fc34.x86_64

> Reading through the commit message when
> it was added (0e6fbe39bdf7 "net/tls(TLS_SW): Add selftest for 'chunked'
> sendfile test") I get the impression that the test is meant to
> demonstrate a problem with ktls, but there's no indication that the
> problem has been fixed.

Yeah, the fix was discussed here:

https://lore.kernel.org/netdev/1591392508-14592-1-git-send-email-pooja.trivedi@stackpath.com/

IDK why it stalled to be honest :S

> Am I right that the expectation is that this test will fail? If that's
> the case, shouldn't this test be removed until the problem is fixed?


  reply	other threads:[~2021-06-17 21:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 19:46 Hangs during tls multi_chunk_sendfile selftest Seth Forshee
2021-06-17 21:22 ` Jakub Kicinski [this message]
2021-06-17 23:03   ` Seth Forshee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210617142234.272cc686@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=josh.tway@stackpath.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mallesham.jatharkonda@oneconvergence.com \
    --cc=netdev@vger.kernel.org \
    --cc=pooja.trivedi@stackpath.com \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.