From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E620AC2B9F4 for ; Thu, 17 Jun 2021 15:42:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C2CB561019 for ; Thu, 17 Jun 2021 15:42:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233328AbhFQPoO (ORCPT ); Thu, 17 Jun 2021 11:44:14 -0400 Received: from mga11.intel.com ([192.55.52.93]:61391 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232540AbhFQPoO (ORCPT ); Thu, 17 Jun 2021 11:44:14 -0400 IronPort-SDR: Z8QBuhE89bAgtQR6igJgWGQFnv+7RZvVjHKnPKVRpuCvbjfYm8/HlIxn+keDWD87PPZf/V66Ps 0DG5mIOuGeVg== X-IronPort-AV: E=McAfee;i="6200,9189,10018"; a="203369145" X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="203369145" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 08:41:37 -0700 IronPort-SDR: mytfaOilOdXvYMEbtHvbfBDM13SCmLv/Wm7VsvDxgcKC++yQ4jC5pJb8LDnGmrew5xiPiW01Ps Py9rX4QwFM+Q== X-IronPort-AV: E=Sophos;i="5.83,280,1616482800"; d="scan'208";a="451057047" Received: from mkalyani-mobl.amr.corp.intel.com (HELO intel.com) ([10.252.138.30]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2021 08:41:36 -0700 Date: Thu, 17 Jun 2021 08:41:33 -0700 From: Ben Widawsky To: Alison Schofield Cc: Dan Williams , Ira Weiny , Vishal Verma , Jonathan Cameron , linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v3 0/2] CXL ACPI tables for object creation Message-ID: <20210617154133.zb54zf46foxcss3c@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 21-06-16 18:11:06, Alison Schofield wrote: > Jonathan - I updated Patch 2 so I didn't keep your Reviewed-by tag. > > Changes since v2 [1]: > - Warn and continue, rather than error out, on these acpi table parsing issues: > table length mismatch for either CHBS or CFMWS; duplicate uid's for CHBS. > (Ben, Jonathan) > - Update flow in cxl_acpi_match_chbs() (Ben, Jonathan) > - Improve naming cedt_table->acpi_cedt, cedt_base->cedt_subtable (Ben) > - Emit debug message only if CFMWS is greater than its expected length (Ben) > - Update the dev_err messages wrt the CFMWS expected length failure. > - Remove blank line before error handling block (Jonathan) > - Rebase to the CXL pending branch [2] > > [1]: https://lore.kernel.org/linux-cxl/cover.1623800340.git.alison.schofield@intel.com/ > [2]: https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git/log/?h=pending > > -- > Parse the ACPI CXL Early Discovery Table (CEDT) and use the CHBS & CFMWS > when creating port and decoder objects. > > CHBS: CXL Host Bridge Structure - Patch 1 > CFMWS: CXL Fixed Memory Window Structure - Patch 2 > > Alison Schofield (2): > cxl/acpi: Add the Host Bridge base address to CXL port objects > cxl/acpi: Use the ACPI CFMWS to create static decoder objects > > drivers/cxl/acpi.c | 217 +++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 212 insertions(+), 5 deletions(-) > > > base-commit: 21083f51521fb0f60dbac591f175c3ed48435af4 It might be nice to add a header kdoc for acpi.c now that it's become sufficiently complex. Can be follow-on patch. Both are: Reviewed-by: Ben Widawsky