All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miao-chen Chou <mcchou@chromium.org>
To: Bluetooth Kernel Mailing List <linux-bluetooth@vger.kernel.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
	Alain Michaud <alainm@chromium.org>,
	Luiz Augusto von Dentz <luiz.von.dentz@intel.com>,
	Howard Chung <howardchung@google.com>,
	Miao-chen Chou <mcchou@chromium.org>
Subject: [BlueZ PATCH v1 3/3] client: Print error code for connect methods
Date: Thu, 17 Jun 2021 17:16:02 -0700	[thread overview]
Message-ID: <20210617170013.BlueZ.v1.3.I226fdcdd12b13e4875c8cd03b42fc52283920cc4@changeid> (raw)
In-Reply-To: <20210618001559.1284204-1-mcchou@chromium.org>

The following steps were performed.
- Issuing repeated commands to connect the same BLE device.
- Verifying the print in bluetoothctl console

Reviewed-by: Alain Michaud <alainm@chromium.org>
Reviewed-by: Howard Chung <howardchung@google.com>
---

 client/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/client/main.c b/client/main.c
index da877b546..488a24bf6 100644
--- a/client/main.c
+++ b/client/main.c
@@ -1949,7 +1949,8 @@ static void connect_reply(DBusMessage *message, void *user_data)
 	dbus_error_init(&error);
 
 	if (dbus_set_error_from_message(&error, message) == TRUE) {
-		bt_shell_printf("Failed to connect: %s\n", error.name);
+		bt_shell_printf("Failed to connect: %s %s\n", error.name,
+				error.message);
 		dbus_error_free(&error);
 		return bt_shell_noninteractive_quit(EXIT_FAILURE);
 	}
-- 
2.32.0.288.g62a8d224e6-goog


  parent reply	other threads:[~2021-06-18  0:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18  0:15 [BlueZ PATCH v1 0/3] Detailed error code Miao-chen Chou
2021-06-18  0:15 ` [BlueZ PATCH v1 1/3] error: BR/EDR and LE connection failure reasons Miao-chen Chou
2021-06-18  1:30   ` Detailed error code bluez.test.bot
2021-06-18 18:18   ` [BlueZ PATCH v1 1/3] error: BR/EDR and LE connection failure reasons Luiz Augusto von Dentz
2021-06-26  1:51     ` Miao-chen Chou
2021-06-18  0:16 ` [BlueZ PATCH v1 2/3] device: Include BtdError code in Connect() return Miao-chen Chou
2021-06-18  0:16 ` Miao-chen Chou [this message]
2021-06-18 18:40 ` [BlueZ PATCH v1 0/3] Detailed error code Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210617170013.BlueZ.v1.3.I226fdcdd12b13e4875c8cd03b42fc52283920cc4@changeid \
    --to=mcchou@chromium.org \
    --cc=alainm@chromium.org \
    --cc=howardchung@google.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.von.dentz@intel.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.