All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: Colin Ian King <colin.king@canonical.com>,
	netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
	Jacob Keller <jacob.e.keller@intel.com>
Subject: [PATCH net-next 8/8] ice: remove redundant continue statement in a for-loop
Date: Thu, 17 Jun 2021 10:01:45 -0700	[thread overview]
Message-ID: <20210617170145.4092904-9-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20210617170145.4092904-1-anthony.l.nguyen@intel.com>

From: Colin Ian King <colin.king@canonical.com>

The continue statement in the for-loop is redundant. Re-work the hw_lock
check to remove it.

Addresses-Coverity: ("Continue has no effect")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
index 267312fad59a..3eca0e4eab0b 100644
--- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
+++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
@@ -410,13 +410,11 @@ bool ice_ptp_lock(struct ice_hw *hw)
 	for (i = 0; i < MAX_TRIES; i++) {
 		hw_lock = rd32(hw, PFTSYN_SEM + (PFTSYN_SEM_BYTES * hw->pf_id));
 		hw_lock = hw_lock & PFTSYN_SEM_BUSY_M;
-		if (hw_lock) {
-			/* Somebody is holding the lock */
-			usleep_range(10000, 20000);
-			continue;
-		} else {
+		if (!hw_lock)
 			break;
-		}
+
+		/* Somebody is holding the lock */
+		usleep_range(10000, 20000);
 	}
 
 	return !hw_lock;
-- 
2.26.2


  parent reply	other threads:[~2021-06-17 16:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 17:01 [PATCH net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2021-06-17 Tony Nguyen
2021-06-17 17:01 ` [PATCH net-next 1/8] ice: fix incorrect payload indicator on PTYPE Tony Nguyen
2021-06-17 17:01 ` [PATCH net-next 2/8] ice: mark PTYPE 2 as reserved Tony Nguyen
2021-06-17 17:01 ` [PATCH net-next 3/8] ice: reduce scope of variables Tony Nguyen
2021-06-17 17:01 ` [PATCH net-next 4/8] ice: remove local variable Tony Nguyen
2021-06-17 17:01 ` [PATCH net-next 5/8] ice: Remove the repeated declaration Tony Nguyen
2021-06-17 17:01 ` [PATCH net-next 6/8] ice: remove unnecessary NULL checks before ptp_read_system_* Tony Nguyen
2021-06-17 17:01 ` [PATCH net-next 7/8] net: ice: ptp: fix compilation warning if PTP_1588_CLOCK is disabled Tony Nguyen
2021-06-17 17:01 ` Tony Nguyen [this message]
2021-06-17 19:20 ` [PATCH net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2021-06-17 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210617170145.4092904-9-anthony.l.nguyen@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=colin.king@canonical.com \
    --cc=davem@davemloft.net \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.