All of
 help / color / mirror / Atom feed
From: Kees Cook <>
To: Shuah Khan <>
Cc: Kees Cook <>,,
	Guillaume Tucker <>,,
Subject: [PATCH] selftests/lkdtm: Use /bin/sh not $SHELL
Date: Thu, 17 Jun 2021 16:10:27 -0700	[thread overview]
Message-ID: <> (raw)

Some environments (e.g. do not set $SHELL for their test
environment. There's no need to use $SHELL here anyway, so just replace
it with hard-coded /bin/sh instead. Without this, the LKDTM tests would
never actually run on

Fixes: 46d1a0f03d66 ("selftests/lkdtm: Add tests for LKDTM targets")
Signed-off-by: Kees Cook <>
 tools/testing/selftests/lkdtm/ | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/lkdtm/ b/tools/testing/selftests/lkdtm/
index bb7a1775307b..968ff3cf5667 100755
--- a/tools/testing/selftests/lkdtm/
+++ b/tools/testing/selftests/lkdtm/
@@ -79,7 +79,7 @@ dmesg > "$DMESG"
 # Most shells yell about signals and we're expecting the "cat" process
 # to usually be killed by the kernel. So we have to run it in a sub-shell
 # and silence errors.
-($SHELL -c 'cat <(echo '"$test"') >'"$TRIGGER" 2>/dev/null) || true
+(/bin/sh -c 'cat <(echo '"$test"') >'"$TRIGGER" 2>/dev/null) || true
 # Record and dump the results
 dmesg | comm --nocheck-order -13 "$DMESG" - > "$LOG" || true

             reply	other threads:[~2021-06-17 23:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17 23:10 Kees Cook [this message]
2021-06-18 19:29 ` [PATCH] selftests/lkdtm: Use /bin/sh not $SHELL Guillaume Tucker
2021-06-19  3:02   ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.