All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Davey <paul.davey@alliedtelesis.co.nz>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Paul Davey <paul.davey@alliedtelesis.co.nz>
Subject: [PATCH 1/2] bus: mhi: Fix pm_state conversion to string
Date: Fri, 18 Jun 2021 15:31:31 +1200	[thread overview]
Message-ID: <20210618033132.24839-2-paul.davey@alliedtelesis.co.nz> (raw)
In-Reply-To: <20210618033132.24839-1-paul.davey@alliedtelesis.co.nz>

On big endian architectures the mhi debugfs files which report pm state
give "Invalid State" for all states.

Fix to_mhi_pm_state_str by using a local unsigned long as an intemediate
to pass the state to find_last_bit to avoid endianness issues with cast
from enum mhi_pm_state * to unsigned long *.

Signed-off-by: Paul Davey <paul.davey@alliedtelesis.co.nz>
---
 drivers/bus/mhi/core/init.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
index c81b377fca8f..87cc0c449078 100644
--- a/drivers/bus/mhi/core/init.c
+++ b/drivers/bus/mhi/core/init.c
@@ -79,7 +79,8 @@ static const char * const mhi_pm_state_str[] = {
 
 const char *to_mhi_pm_state_str(enum mhi_pm_state state)
 {
-	int index = find_last_bit((unsigned long *)&state, 32);
+	unsigned long tmp = state;
+	int index = find_last_bit((unsigned long *)&tmp, 32);
 
 	if (index >= ARRAY_SIZE(mhi_pm_state_str))
 		return "Invalid State";
-- 
2.32.0


  reply	other threads:[~2021-06-18  3:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18  3:31 [PATCH 0/2] bus: mhi: Fix MHI on big endian architectures Paul Davey
2021-06-18  3:31 ` Paul Davey [this message]
2021-06-18  6:12   ` [PATCH 1/2] bus: mhi: Fix pm_state conversion to string Manivannan Sadhasivam
2021-06-18 21:41   ` Hemant Kumar
2021-06-18  3:31 ` [PATCH 2/2] bus: mhi: Fix MHI DMA structure endianness Paul Davey
2021-06-18  6:29   ` Manivannan Sadhasivam
2021-06-18  6:32     ` Manivannan Sadhasivam
2021-06-22  1:31       ` Bhaumik Bhatt
2021-06-18  5:44 ` [PATCH 0/2] bus: mhi: Fix MHI on big endian architectures Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210618033132.24839-2-paul.davey@alliedtelesis.co.nz \
    --to=paul.davey@alliedtelesis.co.nz \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.