From: Andrew Jeffery <andrew@aj.id.au>
To: openbmc@lists.ozlabs.org
Subject: [PATCH linux dev-5.10 0/7] Rework use of KCS devices for P10 platforms
Date: Fri, 18 Jun 2021 13:28:51 +0930 [thread overview]
Message-ID: <20210618035858.4024689-1-andrew@aj.id.au> (raw)
Hello,
This is a bit of a cleanup series mostly specific to the OpenBMC kernel
tree, though there are some exceptions which I'll get to in a moment.
Firstly, v4 of the KCS series has been applied upstream by Corey, and this has
been backported by Joel into dev-5.10. There was a fix sent by Colin for a
signedness issue that was discovered, which is patch 1 in this series.
Patch 2 adds a raw KCS driver that was one of the original motivations for the
upstream series. This raw driver replaces the hacky mctp-lpc driver we've been
carrying in the OpenBMC tree. The mctp-lpc driver only worked with one of the
Aspeed BMC KCS devices and didn't integrate at all with the existing kcs_bmc
framework; the raw KCS driver fixes that by working with any of the KCS devices
on either the Aspeed or Nuvoton SoCs. For IBM's purposes, this allows us to
migrate the MCTP LPC binding between KCS devices on the Aspeed SoCs.
The raw KCS driver is a stopgap solution until we have Jeremy's in-kernel,
socket-based MCTP work merged, at which point we'll migrate the LPC MCTP binding
implementation into the kernel and drop the raw KCS driver altogether. Its
temporary nature is why I didn't push on getting it merged upstream.
From there we clean up the Rainier devicetree by removing the hacky
openbmc,mctp-lpc compatible node and replace it with the standard KCS 4 node
from aspeed-g6.dtsi in patch 4. Once that's removed, we drop the obsolete driver
in patch 5.
From there it's a clear run to switch the KCS device we use for MCTP from
channel 4 to channel 3 in patch 6 to avoid some conflicts with the reset state
of the status bits, and finally enable KCS channel 2 on Rainier which we're
using for the debug-trigger application.
Shortly I'll send upstream the patches to enable KCS channels 2 and 3 for
Rainier.
Please review!
Andrew
Andrew Jeffery (6):
ipmi: kcs_bmc: Add a "raw" character device interface
ARM: configs: Enable IPMI KCS raw chardev
ARM: dts: rainier: Drop the openbmc,mctp-lpc node
misc: Remove obsolete mctp-lpc chardev
ARM: dts: rainier: Switch to KCS 3 for MCTP binding
ARM: dts: rainier: Enable KCS channel 2
Colin Ian King (1):
ipmi: kcs_bmc_aspeed: Fix less than zero comparison of a unsigned int
Documentation/ABI/testing/dev-raw-kcs | 25 ++
arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts | 16 +-
arch/arm/configs/aspeed_g5_defconfig | 2 +-
drivers/char/ipmi/Kconfig | 17 +
drivers/char/ipmi/Makefile | 1 +
drivers/char/ipmi/kcs_bmc_aspeed.c | 8 +-
drivers/char/ipmi/kcs_bmc_cdev_raw.c | 441 ++++++++++++++++++
drivers/misc/Kconfig | 7 -
drivers/misc/Makefile | 1 -
drivers/misc/mctp-lpc.c | 443 -------------------
10 files changed, 501 insertions(+), 460 deletions(-)
create mode 100644 Documentation/ABI/testing/dev-raw-kcs
create mode 100644 drivers/char/ipmi/kcs_bmc_cdev_raw.c
delete mode 100644 drivers/misc/mctp-lpc.c
--
2.30.2
next reply other threads:[~2021-06-18 4:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 3:58 Andrew Jeffery [this message]
2021-06-18 3:58 ` [PATCH linux dev-5.10 1/7] ipmi: kcs_bmc_aspeed: Fix less than zero comparison of a unsigned int Andrew Jeffery
2021-06-18 3:58 ` [PATCH linux dev-5.10 2/7] ipmi: kcs_bmc: Add a "raw" character device interface Andrew Jeffery
2021-06-23 0:47 ` Andrew Jeffery
2021-06-23 1:04 ` Joel Stanley
2021-06-23 3:20 ` Andrew Jeffery
2021-06-18 3:58 ` [PATCH linux dev-5.10 3/7] ARM: configs: Enable IPMI KCS raw chardev Andrew Jeffery
2021-06-18 3:58 ` [PATCH linux dev-5.10 4/7] ARM: dts: rainier: Drop the openbmc, mctp-lpc node Andrew Jeffery
2021-06-18 3:58 ` [PATCH linux dev-5.10 5/7] misc: Remove obsolete mctp-lpc chardev Andrew Jeffery
2021-06-18 3:58 ` [PATCH linux dev-5.10 6/7] ARM: dts: rainier: Switch to KCS 3 for MCTP binding Andrew Jeffery
2021-06-18 3:58 ` [PATCH linux dev-5.10 7/7] ARM: dts: rainier: Enable KCS channel 2 Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618035858.4024689-1-andrew@aj.id.au \
--to=andrew@aj.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.