From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0659AC49EA2 for ; Fri, 18 Jun 2021 04:18:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCBBF6117A for ; Fri, 18 Jun 2021 04:18:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230447AbhFREUs (ORCPT ); Fri, 18 Jun 2021 00:20:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230419AbhFREUr (ORCPT ); Fri, 18 Jun 2021 00:20:47 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE14EC061760 for ; Thu, 17 Jun 2021 21:18:37 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id t8so2025193pfe.3 for ; Thu, 17 Jun 2021 21:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=A7veP2+rvJhREGxZ7bA2MKokj7fOMWmnWBdu22Gjixs=; b=plDYr7URR38B4jGYMsxSURthpcFrTWdDpgkJZiOYCuF4iliXpJ56Mn3TIhtq6Hj3Ko DcJqLB0QmDx+XU5q97EHRY8Z+3l44WgV8KsrWl60QLCgykxwjoenpSzt8r2PsJABEnbV jnUqsGTAemSR2cNPF1fsD5PWJxUjOSGKN7tNFoyi8QHGOfI8Oe9DhyP6lplAOsox9rYM ToHvttUNsT80qTybhX19aohlNodJS1Z9II5W3Ul1On1PDhnZ8W8YRoo7Uz+uitlVLP7s NQ8zh9QQXrgGvYeR/5Vu3hiRaPODOYGYDR6en/M34Md65klj78jhxoKpPolvM3Pjk9BT KtZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=A7veP2+rvJhREGxZ7bA2MKokj7fOMWmnWBdu22Gjixs=; b=c7PZ83I5hh/RxrV4/QPkk3l6XdzAqmcM1uWV3XuLeddW928GoZTk/YF7Rsz0rvmZ4X cs5f3tqfURZa8lqLDjv/aZTUy1YmMgj6hAejK1GrrEVCG/NVTRp+7ILXdTLo5MJUHG4u BsHUs00MWVeHOGtszz7d5ZxW99iKKfUn53Q4wN7A3U5XFW0YasCZDJSkVuqBkX9ycnnw CMM61w7qAwWk+mgL0rDmS/OZ/MCPME6zAoNXdCmQpdxBRexQRLSY04cU26wSCzrAcCPB TZ4P+XncyjmJm0pmTIGQzofzQJYQZVwao+mmOOkAAFP0jnVXJwKpvYYpaQYqbcVZ3QWu e2XA== X-Gm-Message-State: AOAM5302lh2yCUllsf24GKY/esbHK/5HE1FdxCLOSY3RvJ5uRZRwRvjS FJDSCejxTne1yVw/sRn2J9CG X-Google-Smtp-Source: ABdhPJz5nIO0obUzGfQWU2OY7LlyNmGKp7Hy07h54AzlLuFHm3eedis+rYyTYKWqhR+BwvY3pYmALw== X-Received: by 2002:a63:3246:: with SMTP id y67mr8193050pgy.244.1623989917247; Thu, 17 Jun 2021 21:18:37 -0700 (PDT) Received: from workstation ([120.138.13.238]) by smtp.gmail.com with ESMTPSA id s13sm6431308pjm.34.2021.06.17.21.18.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 17 Jun 2021 21:18:35 -0700 (PDT) Date: Fri, 18 Jun 2021 09:48:31 +0530 From: Manivannan Sadhasivam To: Sibi Sankar Cc: bjorn.andersson@linaro.org, jassisinghbrar@gmail.com, agross@kernel.org, rananta@codeaurora.org, vnkgutta@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mailbox: qcom-ipcc: Fix IPCC mbox channel exhaustion Message-ID: <20210618041831.GA3682@workstation> References: <1623865378-1943-1-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623865378-1943-1-git-send-email-sibis@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Jun 16, 2021 at 11:12:58PM +0530, Sibi Sankar wrote: > Fix IPCC (Inter-Processor Communication Controller) channel exhaustion by > setting the channel private data to NULL on mbox shutdown. > > Err Logs: > remoteproc: MBA booted without debug policy, loading mpss > remoteproc: glink-edge: failed to acquire IPC channel > remoteproc: failed to probe subdevices for remoteproc: -16 > > Fixes: fa74a0257f45 ("mailbox: Add support for Qualcomm IPCC") > Signed-off-by: Sibi Sankar Reviewed-by: Manivannan Sadhasivam Thanks, Mani > Cc: stable@vger.kernel.org > --- > drivers/mailbox/qcom-ipcc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c > index 2d13c72944c6..584700cd1585 100644 > --- a/drivers/mailbox/qcom-ipcc.c > +++ b/drivers/mailbox/qcom-ipcc.c > @@ -155,6 +155,11 @@ static int qcom_ipcc_mbox_send_data(struct mbox_chan *chan, void *data) > return 0; > } > > +static void qcom_ipcc_mbox_shutdown(struct mbox_chan *chan) > +{ > + chan->con_priv = NULL; > +} > + > static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox, > const struct of_phandle_args *ph) > { > @@ -184,6 +189,7 @@ static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox, > > static const struct mbox_chan_ops ipcc_mbox_chan_ops = { > .send_data = qcom_ipcc_mbox_send_data, > + .shutdown = qcom_ipcc_mbox_shutdown, > }; > > static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >